Browse Source

Remove class loaders checking

pull/108/head
Decebal Suiu 9 years ago
parent
commit
a163a7457c
  1. 14
      pf4j/src/main/java/ro/fortsoft/pf4j/AbstractExtensionFinder.java
  2. 2
      pf4j/src/main/java/ro/fortsoft/pf4j/PluginClassLoader.java

14
pf4j/src/main/java/ro/fortsoft/pf4j/AbstractExtensionFinder.java

@ -70,20 +70,6 @@ public abstract class AbstractExtensionFinder implements ExtensionFinder, Plugin
ClassLoader classLoader = (pluginId != null) ? pluginManager.getPluginClassLoader(pluginId) : getClass().getClassLoader(); ClassLoader classLoader = (pluginId != null) ? pluginManager.getPluginClassLoader(pluginId) : getClass().getClassLoader();
// performs some check
if (log.isTraceEnabled()) { // an alternative may be the use of a system property
ClassLoader typeClassLoader = type.getClassLoader();
if (!classLoader.equals(typeClassLoader))
{
// in this scenario the method 'isAssignableFrom' returns only FALSE
// see http://www.coderanch.com/t/557846/java/java/FWIW-FYI-isAssignableFrom-isInstance-differing
log.error("Different class loaders: '{}' (E) and '{}' (EP)", classLoader, typeClassLoader);
// below line is commented because I wish to see the next log.trace line
// continue;
}
}
for (String className : entry.getValue()) { for (String className : entry.getValue()) {
try { try {
log.debug("Loading class '{}' using class loader '{}'", className, classLoader); log.debug("Loading class '{}' using class loader '{}'", className, classLoader);

2
pf4j/src/main/java/ro/fortsoft/pf4j/PluginClassLoader.java

@ -90,7 +90,7 @@ public class PluginClassLoader extends URLClassLoader {
} }
// look in dependencies // look in dependencies
log.trace("Look in dependencies for class '{}'", className); log.trace("Search in dependencies for class '{}'", className);
List<PluginDependency> dependencies = pluginDescriptor.getDependencies(); List<PluginDependency> dependencies = pluginDescriptor.getDependencies();
for (PluginDependency dependency : dependencies) { for (PluginDependency dependency : dependencies) {
PluginClassLoader classLoader = pluginManager.getPluginClassLoader(dependency.getPluginId()); PluginClassLoader classLoader = pluginManager.getPluginClassLoader(dependency.getPluginId());

Loading…
Cancel
Save