From b57fba603af7e7d222f335e981736ef2940d4879 Mon Sep 17 00:00:00 2001 From: Stanislav Oaserele Date: Tue, 12 Dec 2017 17:47:02 +0200 Subject: [PATCH] Fixing pagination issue when using _p & _size When using _p ang _size query params in URL, the first row is skipped. Example: _p = 1 & _size = 20 reqParams._index will be = (1 - 1) * 20 + 1 = 1; Generated SQL will be SELECT * FROM ? LIMIT 1,20. This SQL skips first element (with index 0) Correct SQL that should be generated is SELECT * FROM ? LIMIT 0,20 --- lib/xsql.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/xsql.js b/lib/xsql.js index 0386454541..3cb18b1f28 100644 --- a/lib/xsql.js +++ b/lib/xsql.js @@ -197,7 +197,7 @@ class Xsql { } if ('_p' in reqParams && parseInt(reqParams._p) > 0) { - reqParams._index = (parseInt(reqParams._p) - 1) * reqParams._len + 1; + reqParams._index = (parseInt(reqParams._p) - 1) * reqParams._len; } //console.log(reqParams._index, reqParams._len);