From fa444fc126bf2e5dc20b2e381fb9f590d1690d53 Mon Sep 17 00:00:00 2001
From: mertmit <mertmit99@gmail.com>
Date: Thu, 18 Apr 2024 11:33:17 +0000
Subject: [PATCH] feat: improve extension update

---
 .../components/extensions/Extension.vue       |  6 +++-
 packages/nc-gui/composables/useExtensions.ts  | 28 +++++++++++++++----
 2 files changed, 27 insertions(+), 7 deletions(-)

diff --git a/packages/nc-gui/components/extensions/Extension.vue b/packages/nc-gui/components/extensions/Extension.vue
index e882fa8e66..26cc3b837f 100644
--- a/packages/nc-gui/components/extensions/Extension.vue
+++ b/packages/nc-gui/components/extensions/Extension.vue
@@ -126,6 +126,10 @@ const closeFullscreen = (e: MouseEvent) => {
                   </NcMenuItem>
                   <NcDivider />
                 </template>
+                <NcMenuItem data-rec="true" class="!text-red-500 !hover:bg-red-50" @click="extension.clear()">
+                  <GeneralIcon icon="reload" />
+                  Clear Data
+                </NcMenuItem>
                 <NcMenuItem data-rec="true" class="!text-red-500 !hover:bg-red-50" @click="extension.delete()">
                   <GeneralIcon icon="delete" />
                   Delete
@@ -177,7 +181,7 @@ const closeFullscreen = (e: MouseEvent) => {
                 class="extension-content"
                 :class="{ 'border-1': !fullscreen, 'h-[calc(100%-40px)]': fullscreen }"
               >
-                <component :is="component" />
+                <component :is="component" :key="extension.uiKey" />
               </div>
             </div>
           </div>
diff --git a/packages/nc-gui/composables/useExtensions.ts b/packages/nc-gui/composables/useExtensions.ts
index 3ad918f44b..5899abb00a 100644
--- a/packages/nc-gui/composables/useExtensions.ts
+++ b/packages/nc-gui/composables/useExtensions.ts
@@ -17,6 +17,7 @@ interface ExtensionManifest {
 
 abstract class ExtensionType {
   abstract id: string
+  abstract uiKey: number
   abstract baseId: string
   abstract fkUserId: string
   abstract extensionId: string
@@ -28,6 +29,7 @@ abstract class ExtensionType {
   abstract clear(): Promise<any>
   abstract delete(): Promise<any>
   abstract serialize(): any
+  abstract deserialize(data: any): void
 }
 
 export { ExtensionType }
@@ -92,14 +94,14 @@ export const useExtensions = createSharedComposable(() => {
       return
     }
 
-    let updatedExtension = await $api.extensions.update(extensionId, extension)
+    const updatedExtension = await $api.extensions.update(extensionId, extension)
 
     if (updatedExtension) {
-      updatedExtension = new Extension(updatedExtension)
+      const extension = baseExtensions.value[base.value.id].extensions.find((ext: any) => ext.id === extensionId)
 
-      baseExtensions.value[base.value.id].extensions = baseExtensions.value[base.value.id].extensions.map((ext: any) =>
-        ext.id === extensionId ? updatedExtension : ext,
-      )
+      if (extension) {
+        extension.deserialize(updatedExtension)
+      }
     }
 
     return updatedExtension
@@ -233,6 +235,8 @@ export const useExtensions = createSharedComposable(() => {
     private _kvStore: KvStore
     private _meta: any
 
+    public uiKey = 0
+
     constructor(data: any) {
       this._id = data.id
       this._baseId = data.base_id
@@ -283,6 +287,16 @@ export const useExtensions = createSharedComposable(() => {
       }
     }
 
+    deserialize(data: any) {
+      this._id = data.id
+      this._baseId = data.base_id
+      this._fkUserId = data.fk_user_id
+      this._extensionId = data.extension_id
+      this._title = data.title
+      this._kvStore = new KvStore(this._id, data.kv_store)
+      this._meta = data.meta
+    }
+
     setTitle(title: string): Promise<any> {
       return updateExtension(this.id, { title })
     }
@@ -292,7 +306,9 @@ export const useExtensions = createSharedComposable(() => {
     }
 
     clear(): Promise<any> {
-      return clearKvStore(this.id)
+      return clearKvStore(this.id).then(() => {
+        this.uiKey++
+      })
     }
 
     delete(): Promise<any> {