From c8a19964a3434145f350a64a548ec7a1aa9058f2 Mon Sep 17 00:00:00 2001 From: Naveen MR Date: Mon, 17 Jun 2024 21:08:33 +0100 Subject: [PATCH] chore : remove mssql ref from readme and docs. From internal analysis mssql has been rarely used --- README.md | 11 --------- docker-compose/mssql/docker-compose.yml | 31 ------------------------- markdown/readme/languages/chinese.md | 11 --------- markdown/readme/languages/dutch.md | 8 +------ markdown/readme/languages/french.md | 9 +------ markdown/readme/languages/german.md | 10 +------- markdown/readme/languages/indonesian.md | 10 -------- markdown/readme/languages/italian.md | 10 +------- markdown/readme/languages/japanese.md | 10 +------- markdown/readme/languages/korean.md | 10 +------- markdown/readme/languages/portuguese.md | 10 +------- markdown/readme/languages/russian.md | 10 +------- markdown/readme/languages/spanish.md | 10 +------- packages/nocodb/README.md | 8 ------- 14 files changed, 9 insertions(+), 149 deletions(-) delete mode 100644 docker-compose/mssql/docker-compose.yml diff --git a/README.md b/README.md index b1dcda2f1a..f9d6dc192a 100644 --- a/README.md +++ b/README.md @@ -93,14 +93,6 @@ docker run -d --name nocodb-postgres \ -e NC_AUTH_JWT_SECRET="569a1821-0a93-45e8-87ab-eb857f20a010" \ nocodb/nocodb:latest -# for MSSQL -docker run -d --name nocodb-mssql \ --v "$(pwd)"/nocodb:/usr/app/data/ \ --p 8080:8080 \ --e NC_DB="mssql://host.docker.internal:1433?u=root&p=password&d=d1" \ --e NC_AUTH_JWT_SECRET="569a1821-0a93-45e8-87ab-eb857f20a010" \ -nocodb/nocodb:latest -``` > To persist data in docker you can mount volume at `/usr/app/data/` since 0.10.6. Otherwise your data will be lost after recreating the container. @@ -158,9 +150,6 @@ git clone https://github.com/nocodb/nocodb cd nocodb/docker-compose/mysql # for PostgreSQL cd nocodb/docker-compose/pg -# for MSSQL -cd nocodb/docker-compose/mssql -docker-compose up -d ``` > To persist data in docker, you can mount volume at `/usr/app/data/` since 0.10.6. Otherwise your data will be lost after recreating the container. diff --git a/docker-compose/mssql/docker-compose.yml b/docker-compose/mssql/docker-compose.yml deleted file mode 100644 index 287839a0b2..0000000000 --- a/docker-compose/mssql/docker-compose.yml +++ /dev/null @@ -1,31 +0,0 @@ -version: "2.4" -services: - nocodb: - depends_on: - root_db: - condition: service_healthy - environment: - NC_DB: "mssql://root_db:1433?u=sa&p=Password123.&d=root_db" - image: "nocodb/nocodb:latest" - ports: - - "8080:8080" - restart: always - volumes: - - "nc_data:/usr/app/data" - root_db: - environment: - ACCEPT_EULA: "Y" - SA_PASSWORD: Password123. - healthcheck: - interval: 10s - retries: 10 - start_period: 10s - test: "/opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P \"$$SA_PASSWORD\" -Q \"SELECT 1\" || exit 1" - timeout: 3s - image: "mcr.microsoft.com/mssql/server:2017-latest" - restart: always - volumes: - - "db_data:/var/opt/mssql" -volumes: - db_data: {} - nc_data: {} diff --git a/markdown/readme/languages/chinese.md b/markdown/readme/languages/chinese.md index 1d8cd4e8c7..c7caa09ee0 100644 --- a/markdown/readme/languages/chinese.md +++ b/markdown/readme/languages/chinese.md @@ -79,14 +79,6 @@ docker run -d --name nocodb-postgres \ -e NC_AUTH_JWT_SECRET="569a1821-0a93-45e8-87ab-eb857f20a010" \ nocodb/nocodb:latest -# 如果使用 MSSQL 的话 -docker run -d --name nocodb-mssql \ --v "$(pwd)"/nocodb:/usr/app/data/ \ --p 8080:8080 \ --e NC_DB="mssql://host.docker.internal:1433?u=root&p=password&d=d1" \ --e NC_AUTH_JWT_SECRET="569a1821-0a93-45e8-87ab-eb857f20a010" \ -nocodb/nocodb:latest -``` > 你可以通过在 0.10.6 以上的版本中挂载 `/usr/app/data/` 来持久化数据,否则你的数据会在重新创建容器后完全丢失。 @@ -102,9 +94,6 @@ git clone https://github.com/nocodb/nocodb cd nocodb/docker-compose/mysql # 如果使用 PostgreSQL 的话 cd nocodb/docker-compose/pg -# 如果使用 MSSQL 的话 -cd nocodb/docker-compose/mssql -docker-compose up -d ``` > 你可以通过在 0.10.6 以上的版本中挂载 `/usr/app/data/` 来持久化数据,否则你的数据会在重新创建容器后完全丢失。 diff --git a/markdown/readme/languages/dutch.md b/markdown/readme/languages/dutch.md index 1b9930db72..fe230eab7e 100644 --- a/markdown/readme/languages/dutch.md +++ b/markdown/readme/languages/dutch.md @@ -162,12 +162,6 @@ docker run -d -p 8080:8080 \ #### Example SQL Server -``` -docker run -d -p 8080:8080 \ - -e NC_DB="mssql://host:port?u=user&p=password&d=database" \ - -e NC_AUTH_JWT_SECRET="569a1821-0a93-45e8-87ab-eb857f20a010" \ - nocodb/nocodb:latest -``` ## Docker Compose @@ -175,7 +169,7 @@ docker run -d -p 8080:8080 \ git clone https://github.com/nocodb/nocodb cd nocodb cd docker-compose -cd mysql or pg or mssql +cd mysql or pg docker-compose up -d ``` diff --git a/markdown/readme/languages/french.md b/markdown/readme/languages/french.md index e21c91cf79..23763f35ab 100644 --- a/markdown/readme/languages/french.md +++ b/markdown/readme/languages/french.md @@ -163,20 +163,13 @@ docker run -d -p 8080:8080 \ nocodb/nocodb:latest ``` -#### Exemple SQL Server -``` -docker run -d -p 8080:8080 \ - -e NC_DB="mssql://host:port?u=user&p=password&d=database" \ - -e NC_AUTH_JWT_SECRET="569a1821-0a93-45e8-87ab-eb857f20a010" \ - nocodb/nocodb:latest -``` ## Docker Compose ``` git clone https://github.com/nocodb/nocodb cd nocodb cd docker-compose -cd mysql or pg or mssql +cd mysql or pg docker-compose up -d ``` diff --git a/markdown/readme/languages/german.md b/markdown/readme/languages/german.md index 32f3d8b6d1..24647d66cb 100644 --- a/markdown/readme/languages/german.md +++ b/markdown/readme/languages/german.md @@ -169,14 +169,6 @@ docker run -d -p 8080:8080 \ nocodb/nocodb:latest ``` -#### Beispiel MS SQL Server - -``` -docker run -d -p 8080:8080 \ - -e NC_DB="mssql://host:port?u=user&p=password&d=database" \ - -e NC_AUTH_JWT_SECRET="569a1821-0a93-45e8-87ab-eb857f20a010" \ - nocodb/nocodb:latest -``` ## Docker Compose @@ -184,7 +176,7 @@ docker run -d -p 8080:8080 \ git clone https://github.com/nocodb/nocodb cd nocodb cd docker-compose -cd mysql or pg or mssql +cd mysql or pg docker-compose up -d ``` diff --git a/markdown/readme/languages/indonesian.md b/markdown/readme/languages/indonesian.md index 76aef028e5..ea55926202 100644 --- a/markdown/readme/languages/indonesian.md +++ b/markdown/readme/languages/indonesian.md @@ -82,14 +82,6 @@ docker run -d --name nocodb-postgres \ -e NC_AUTH_JWT_SECRET="569a1821-0a93-45e8-87ab-eb857f20a010" \ nocodb/nocodb:latest -# for MSSQL -docker run -d --name nocodb-mssql \ --v "$(pwd)"/nocodb:/usr/app/data/ \ --p 8080:8080 \ --e NC_DB="mssql://host.docker.internal:1433?u=root&p=password&d=d1" \ --e NC_AUTH_JWT_SECRET="569a1821-0a93-45e8-87ab-eb857f20a010" \ -nocodb/nocodb:latest -``` > Untuk menyimpan data di dalam Docker, Anda dapat melakukan mount volume di direktori /usr/app/data/ mulai dari versi 0.10.6. Jika tidak, data Anda akan hilang setelah mengulang pembuatan kontainer. @@ -145,8 +137,6 @@ git clone https://github.com/nocodb/nocodb cd nocodb/docker-compose/mysql # for PostgreSQL cd nocodb/docker-compose/pg -# for MSSQL -cd nocodb/docker-compose/mssql docker-compose up -d ``` diff --git a/markdown/readme/languages/italian.md b/markdown/readme/languages/italian.md index cb66e8a2b6..f933d0ab82 100644 --- a/markdown/readme/languages/italian.md +++ b/markdown/readme/languages/italian.md @@ -164,14 +164,6 @@ docker run -d -p 8080:8080 \ nocodb/nocodb:latest ``` -#### Esempio con SQL Server - -``` -docker run -d -p 8080:8080 \ - -e NC_DB="mssql://host:port?u=user&p=password&d=database" \ - -e NC_AUTH_JWT_SECRET="569a1821-0a93-45e8-87ab-eb857f20a010" \ - nocodb/nocodb:latest -``` ## Docker Compose @@ -179,7 +171,7 @@ docker run -d -p 8080:8080 \ git clone https://github.com/nocodb/nocodb cd nocodb cd docker-compose -cd mysql or pg or mssql +cd mysql or pg docker-compose up -d ``` diff --git a/markdown/readme/languages/japanese.md b/markdown/readme/languages/japanese.md index f0ba8fd5e8..26094d4547 100644 --- a/markdown/readme/languages/japanese.md +++ b/markdown/readme/languages/japanese.md @@ -163,14 +163,6 @@ docker run -d -p 8080:8080 \ nocodb/nocodb:latest ``` -#### SQL Serverの例 - -``` -docker run -d -p 8080:8080 \ - -e NC_DB="mssql://host:port?u=user&p=password&d=database" \ - -e NC_AUTH_JWT_SECRET="569a1821-0a93-45e8-87ab-eb857f20a010" \ - nocodb/nocodb:latest -``` ## Docker Compose @@ -178,7 +170,7 @@ docker run -d -p 8080:8080 \ git clone https://github.com/nocodb/nocodb cd nocodb cd docker-compose -cd mysql or pg or mssql +cd mysql or pg docker-compose up -d ``` diff --git a/markdown/readme/languages/korean.md b/markdown/readme/languages/korean.md index 5dcee7be44..7ecb046f86 100644 --- a/markdown/readme/languages/korean.md +++ b/markdown/readme/languages/korean.md @@ -163,14 +163,6 @@ docker run -d -p 8080:8080 \ nocodb/nocodb:latest ``` -#### SQL Server 예제 - -``` -docker run -d -p 8080:8080 \ - -e NC_DB="mssql://host:port?u=user&p=password&d=database" \ - -e NC_AUTH_JWT_SECRET="569a1821-0a93-45e8-87ab-eb857f20a010" \ - nocodb/nocodb:latest -``` ## Docker Compose @@ -178,7 +170,7 @@ docker run -d -p 8080:8080 \ git clone https://github.com/nocodb/nocodb cd nocodb cd docker-compose -cd mysql or pg or mssql +cd mysql or pg docker-compose up -d ``` diff --git a/markdown/readme/languages/portuguese.md b/markdown/readme/languages/portuguese.md index 22540aefbc..faa914ce38 100644 --- a/markdown/readme/languages/portuguese.md +++ b/markdown/readme/languages/portuguese.md @@ -162,14 +162,6 @@ docker run -d -p 8080:8080 \ nocodb/nocodb:latest ``` -#### Example SQL Server - -``` -docker run -d -p 8080:8080 \ - -e NC_DB="mssql://host:port?u=user&p=password&d=database" \ - -e NC_AUTH_JWT_SECRET="569a1821-0a93-45e8-87ab-eb857f20a010" \ - nocodb/nocodb:latest -``` ## Docker Compose @@ -177,7 +169,7 @@ docker run -d -p 8080:8080 \ git clone https://github.com/nocodb/nocodb cd nocodb cd docker-compose -cd mysql or pg or mssql +cd mysql or pg docker-compose up -d ``` diff --git a/markdown/readme/languages/russian.md b/markdown/readme/languages/russian.md index 2012382c49..0362edd49d 100644 --- a/markdown/readme/languages/russian.md +++ b/markdown/readme/languages/russian.md @@ -164,14 +164,6 @@ docker run -d -p 8080:8080 \ nocodb/nocodb:latest ``` -#### Пример SQL Server - -``` -docker run -d -p 8080:8080 \ - -e NC_DB="mssql://host:port?u=user&p=password&d=database" \ - -e NC_AUTH_JWT_SECRET="569a1821-0a93-45e8-87ab-eb857f20a010" \ - nocodb/nocodb:latest -``` ## Docker Compose @@ -179,7 +171,7 @@ docker run -d -p 8080:8080 \ git clone https://github.com/nocodb/nocodb cd nocodb cd docker-compose -cd mysql or pg or mssql +cd mysql or pg docker-compose up -d ``` diff --git a/markdown/readme/languages/spanish.md b/markdown/readme/languages/spanish.md index 8930d0178b..a80b113d6b 100644 --- a/markdown/readme/languages/spanish.md +++ b/markdown/readme/languages/spanish.md @@ -161,14 +161,6 @@ docker run -d -p 8080:8080 \ nocodb/nocodb:latest ``` -#### Ejemplo SQL Server - -``` -docker run -d -p 8080:8080 \ - -e NC_DB="mssql://host:port?u=user&p=password&d=database" \ - -e NC_AUTH_JWT_SECRET="569a1821-0a93-45e8-87ab-eb857f20a010" \ - nocodb/nocodb:latest -``` ## Docker Compose @@ -176,7 +168,7 @@ docker run -d -p 8080:8080 \ git clone https://github.com/nocodb/nocodb cd nocodb cd docker-compose -cd mysql or pg or mssql +cd mysql or pg docker-compose up -d ``` diff --git a/packages/nocodb/README.md b/packages/nocodb/README.md index fa02c1c80c..f1ac4f8589 100644 --- a/packages/nocodb/README.md +++ b/packages/nocodb/README.md @@ -114,14 +114,6 @@ docker run -d --name nocodb-postgres \ -e NC_AUTH_JWT_SECRET="569a1821-0a93-45e8-87ab-eb857f20a010" \ nocodb/nocodb:latest -# for MSSQL -docker run -d --name nocodb-mssql \ --v "$(pwd)"/nocodb:/usr/app/data/ \ --p 8080:8080 \ --e NC_DB="mssql://host.docker.internal:1433?u=root&p=password&d=d1" \ --e NC_AUTH_JWT_SECRET="569a1821-0a93-45e8-87ab-eb857f20a010" \ -nocodb/nocodb:latest -``` > To persist data in docker you can mount volume at `/usr/app/data/` since 0.10.6. Otherwise your data will be lost after recreating the container.