From f7d3fd72dd4215667fd085f6bd2fbe72ca538f65 Mon Sep 17 00:00:00 2001
From: Pranav C <pranavxc@gmail.com>
Date: Fri, 17 May 2024 18:47:53 +0530
Subject: [PATCH] test: update audit tab opening steps

Signed-off-by: Pranav C <pranavxc@gmail.com>
---
 .../nc-gui/components/dashboard/TreeView/TableNode.vue   | 1 +
 .../nc-gui/components/dashboard/settings/DataSources.vue | 4 ++--
 tests/playwright/pages/Dashboard/Settings/DataSources.ts | 9 +++++++++
 tests/playwright/pages/Dashboard/TreeView.ts             | 2 +-
 .../playwright/tests/db/general/tableOperations.spec.ts  | 6 ++++--
 5 files changed, 17 insertions(+), 5 deletions(-)

diff --git a/packages/nc-gui/components/dashboard/TreeView/TableNode.vue b/packages/nc-gui/components/dashboard/TreeView/TableNode.vue
index 6b8844c24b..8dfae7041c 100644
--- a/packages/nc-gui/components/dashboard/TreeView/TableNode.vue
+++ b/packages/nc-gui/components/dashboard/TreeView/TableNode.vue
@@ -331,6 +331,7 @@ const deleteTable = () => {
                 <NcMenuItem
                   v-if="isUIAllowed('tableRename', { roles: baseRole })"
                   :data-testid="`sidebar-table-rename-${table.title}`"
+                  class="nc-table-rename"
                   @click="openRenameTableDialog(table, base.sources[sourceIndex].id)"
                 >
                   <div v-e="['c:table:rename']" class="flex gap-2 items-center">
diff --git a/packages/nc-gui/components/dashboard/settings/DataSources.vue b/packages/nc-gui/components/dashboard/settings/DataSources.vue
index d013c86b4c..721fedda6e 100644
--- a/packages/nc-gui/components/dashboard/settings/DataSources.vue
+++ b/packages/nc-gui/components/dashboard/settings/DataSources.vue
@@ -297,7 +297,7 @@ const openedTab = ref('erd')
               <LazyDashboardSettingsErd class="h-full overflow-auto" :source-id="activeSource.id" :show-all-columns="false" />
             </div>
           </a-tab-pane>
-          <a-tab-pane v-if="activeSource.is_meta || activeSource.is_local" key="audit">
+          <a-tab-pane v-if="sources && activeSource === sources[0]" key="audit">
             <template #tab>
               <div class="tab" data-testid="nc-audit-tab">
                 <div>{{ $t('title.auditLogs') }}</div>
@@ -334,7 +334,7 @@ const openedTab = ref('erd')
               <LazyDashboardSettingsUIAcl :source-id="activeSource.id" />
             </div>
           </a-tab-pane>
-          <a-tab-pane key="meta-sync">
+          <a-tab-pane v-if="!activeSource.is_meta && !activeSource.is_local" key="meta-sync">
             <template #tab>
               <div class="tab" data-testid="nc-meta-sync-tab">
                 <div>{{ $t('labels.metaSync') }}</div>
diff --git a/tests/playwright/pages/Dashboard/Settings/DataSources.ts b/tests/playwright/pages/Dashboard/Settings/DataSources.ts
index 3878342886..5b15944f49 100644
--- a/tests/playwright/pages/Dashboard/Settings/DataSources.ts
+++ b/tests/playwright/pages/Dashboard/Settings/DataSources.ts
@@ -30,6 +30,15 @@ export class DataSourcesPage extends BasePage {
     await row.click();
     await this.get().getByTestId('nc-erd-tab').click();
   }
+
+  async openAudit({ rowIndex }: { rowIndex: number }) {
+    const row = this.get()
+      .locator('.ds-table-row')
+      .nth(rowIndex + 1);
+    await row.click();
+    await this.get().getByTestId('nc-audit-tab').click();
+  }
+
   async openAcl({ dataSourceName = defaultBaseName }: { dataSourceName?: string } = {}) {
     await this.get().locator('.ds-table-row', { hasText: dataSourceName }).locator('button:has-text("UI ACL")').click();
   }
diff --git a/tests/playwright/pages/Dashboard/TreeView.ts b/tests/playwright/pages/Dashboard/TreeView.ts
index bb11ea9fef..b8e808eda3 100644
--- a/tests/playwright/pages/Dashboard/TreeView.ts
+++ b/tests/playwright/pages/Dashboard/TreeView.ts
@@ -205,7 +205,7 @@ export class TreeViewPage extends BasePage {
     await this.waitForTableOptions({ title });
 
     await this.get().locator(`.nc-base-tree-tbl-${tableTitle}`).locator('.nc-tbl-context-menu').click();
-    await this.rootPage.locator('.ant-dropdown').locator('.nc-menu-item:has-text("Rename")').click();
+    await this.rootPage.locator('.ant-dropdown').locator('.nc-table-rename.nc-menu-item:has-text("Rename")').click();
 
     await this.dashboard.get().locator('[placeholder="Enter table name"]').fill(newTitle);
     await this.dashboard.get().locator('button:has-text("Rename Table")').click();
diff --git a/tests/playwright/tests/db/general/tableOperations.spec.ts b/tests/playwright/tests/db/general/tableOperations.spec.ts
index 9bec93ac98..8b05dcfc68 100644
--- a/tests/playwright/tests/db/general/tableOperations.spec.ts
+++ b/tests/playwright/tests/db/general/tableOperations.spec.ts
@@ -32,8 +32,10 @@ test.describe('Table Operations', () => {
       // Audit logs in clickhouse; locally wont be accessible
 
       await dashboard.treeView.openProject({ title: context.base.title, context });
-      await dashboard.baseView.tab_dataSources.click();
-      await dashboard.baseView.dataSources.openAudit({ rowIndex: 0 });
+
+      await dashboard.treeView.baseSettings({ title: context.base.title });
+      await dashboard.settings.selectTab({ tab: 'dataSources' });
+      await dashboard.settings.dataSources.openAudit({ rowIndex: 0 });
 
       await audit.verifyRow({
         index: 0,