From f7bd2caaa4083e504db7242e08690cc9b018abb4 Mon Sep 17 00:00:00 2001 From: Raju Udava <86527202+dstala@users.noreply.github.com> Date: Mon, 13 Mar 2023 14:06:20 +0530 Subject: [PATCH] refactor: remove baseURL env variable Signed-off-by: Raju Udava <86527202+dstala@users.noreply.github.com> --- .../content/en/getting-started/environment-variables.md | 1 - packages/nocodb/src/lib/controllers/sync/import.ctl.ts | 4 +--- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/noco-docs/content/en/getting-started/environment-variables.md b/packages/noco-docs/content/en/getting-started/environment-variables.md index 5ce104419c..b15712a99b 100644 --- a/packages/noco-docs/content/en/getting-started/environment-variables.md +++ b/packages/noco-docs/content/en/getting-started/environment-variables.md @@ -43,7 +43,6 @@ For production usecases, it is **recommended** to configure | NC_REDIS_URL | Custom Redis URL. Example: `redis://:authpassword@127.0.0.1:6380/4` | Meta data will be stored in memory | | | NC_DISABLE_ERR_REPORT | Disable error reporting | | | | NC_DISABLE_CACHE | To be used only while debugging. On setting this to `true` - meta data be fetched from db instead of redis/cache. | `false` | | -| NC_BASEURL_INTERNAL | Used as base url for internal(server) API calls | Default value in docker will be `http://localhost:$PORT` and in all other case it's populated from request object | | | AWS_ACCESS_KEY_ID | For Litestream - S3 access key id | If Litestream is configured and `NC_DB` is not present. SQLite gets backed up to S3 | | | AWS_SECRET_ACCESS_KEY | For Litestream - S3 secret access key | If Litestream is configured and `NC_DB` is not present. SQLite gets backed up to S3 | | | AWS_BUCKET | For Litestream - S3 bucket | If Litestream is configured and `NC_DB` is not present. SQLite gets backed up to S3 | | diff --git a/packages/nocodb/src/lib/controllers/sync/import.ctl.ts b/packages/nocodb/src/lib/controllers/sync/import.ctl.ts index c497d80735..fb3c06ecda 100644 --- a/packages/nocodb/src/lib/controllers/sync/import.ctl.ts +++ b/packages/nocodb/src/lib/controllers/sync/import.ctl.ts @@ -105,9 +105,7 @@ export default ( // if environment value avail use it // or if it's docker construct using `PORT` - if (process.env.NC_BASEURL_INTERNAL) { - baseURL = process.env.NC_BASEURL_INTERNAL; - } else if (process.env.NC_DOCKER) { + if (process.env.NC_DOCKER) { baseURL = `http://localhost:${process.env.PORT || 8080}`; }