From f49bf52abf5ef37337a8bc1f52454fde187b2627 Mon Sep 17 00:00:00 2001
From: Ramesh Mane <101566080+rameshmane7218@users.noreply.github.com>
Date: Fri, 14 Jun 2024 11:43:26 +0530
Subject: [PATCH] Nc fix/resolve console warnings (#8715)

* fix(nc-gui): some ts warnings

* fix(nc-gui): columnFilter file warnings

* fix(nc-gui): fix ts errors

* fix(nc-gui): pr review changes

* fix(nc-gui): update NcCheckbox change event

* fix(nc-gui): pr review changes
---
 packages/nc-gui/components/dlg/ViewCreate.vue             | 4 ++--
 packages/nc-gui/components/nc/Checkbox.vue                | 4 ++--
 packages/nc-gui/components/shared-view/AskPassword.vue    | 8 +-------
 packages/nc-gui/components/smartsheet/Form.vue            | 4 ++--
 packages/nc-gui/components/smartsheet/Kanban.vue          | 1 -
 .../components/smartsheet/expanded-form/Comments.vue      | 2 +-
 .../nc-gui/components/smartsheet/toolbar/ColumnFilter.vue | 4 ++--
 7 files changed, 10 insertions(+), 17 deletions(-)

diff --git a/packages/nc-gui/components/dlg/ViewCreate.vue b/packages/nc-gui/components/dlg/ViewCreate.vue
index 9b22e0173f..0faaf29d65 100644
--- a/packages/nc-gui/components/dlg/ViewCreate.vue
+++ b/packages/nc-gui/components/dlg/ViewCreate.vue
@@ -13,7 +13,7 @@ interface Props {
   groupingFieldColumnId?: string
   geoDataFieldColumnId?: string
   tableId: string
-  calendarRange: Array<{
+  calendarRange?: Array<{
     fk_from_column_id: string
     fk_to_column_id: string | null // for ee only
   }>
@@ -36,7 +36,7 @@ interface Form {
   // for calendar view only
   calendar_range: Array<{
     fk_from_column_id: string
-    fk_to_column_id: string | undefined // for ee only
+    fk_to_column_id: string | null // for ee only
   }>
 }
 
diff --git a/packages/nc-gui/components/nc/Checkbox.vue b/packages/nc-gui/components/nc/Checkbox.vue
index f3c650da85..865437e457 100644
--- a/packages/nc-gui/components/nc/Checkbox.vue
+++ b/packages/nc-gui/components/nc/Checkbox.vue
@@ -1,6 +1,6 @@
 <script lang="ts" setup>
 interface Props {
-  checked: boolean
+  checked?: boolean
   size?: 'small' | 'default' | 'large'
   disabled?: boolean
 }
@@ -15,7 +15,7 @@ const emit = defineEmits(['change', 'update:checked'])
 const checked = useVModel(props, 'checked', emit)
 
 const onChange = (e: Event) => {
-  emit('change', e, checked.value)
+  emit('change', e, (e.target as HTMLInputElement).checked)
 }
 </script>
 
diff --git a/packages/nc-gui/components/shared-view/AskPassword.vue b/packages/nc-gui/components/shared-view/AskPassword.vue
index dd5efc9a9d..1cce0c76a1 100644
--- a/packages/nc-gui/components/shared-view/AskPassword.vue
+++ b/packages/nc-gui/components/shared-view/AskPassword.vue
@@ -44,13 +44,6 @@ const focus: VNodeRef = (el: typeof InputPassword) => {
   return el && el?.focus?.()
 }
 
-watch(
-  () => formState.value.password,
-  () => {
-    passwordError.value = null
-  },
-)
-
 const bgImageName = computed(() => {
   switch (props.viewType) {
     case ViewTypes.GRID:
@@ -97,6 +90,7 @@ const bgImageName = computed(() => {
             class="!rounded-lg !text-small"
             hide-details
             :placeholder="$t('msg.enterPassword')"
+            @input="passwordError = null"
           />
           <Transition name="layout">
             <div v-if="passwordError" class="mb-2 text-sm text-red-500">{{ passwordError }}</div>
diff --git a/packages/nc-gui/components/smartsheet/Form.vue b/packages/nc-gui/components/smartsheet/Form.vue
index 4a634dc796..16c00d6191 100644
--- a/packages/nc-gui/components/smartsheet/Form.vue
+++ b/packages/nc-gui/components/smartsheet/Form.vue
@@ -969,7 +969,7 @@ useEventListener(
                               :bordered="false"
                               :data-testid="NcForm.heading"
                               :data-title="NcForm.heading"
-                              @update:value="updateView"
+                              @input="updateView"
                               @focus="activeRow = NcForm.heading"
                               @blur="activeRow = ''"
                             />
@@ -1280,7 +1280,7 @@ useEventListener(
                       :placeholder="$t('msg.info.formInput')"
                       @focus="onFocusActiveFieldLabel"
                       @keydown.enter.prevent
-                      @update:value="updateFieldTitle"
+                      @input="updateFieldTitle($event.target.value)"
                       @change="updateColMeta(activeField)"
                     />
 
diff --git a/packages/nc-gui/components/smartsheet/Kanban.vue b/packages/nc-gui/components/smartsheet/Kanban.vue
index 5f888edebb..ec8d80adea 100644
--- a/packages/nc-gui/components/smartsheet/Kanban.vue
+++ b/packages/nc-gui/components/smartsheet/Kanban.vue
@@ -113,7 +113,6 @@ const kanbanContainerRef = ref()
 const selectedStackTitle = ref('')
 
 reloadViewDataHook?.on(async () => {
-  console.log('load')
   await loadKanbanMeta()
   await loadKanbanData()
 })
diff --git a/packages/nc-gui/components/smartsheet/expanded-form/Comments.vue b/packages/nc-gui/components/smartsheet/expanded-form/Comments.vue
index 8d57469c86..aca4c7b6f2 100644
--- a/packages/nc-gui/components/smartsheet/expanded-form/Comments.vue
+++ b/packages/nc-gui/components/smartsheet/expanded-form/Comments.vue
@@ -3,7 +3,7 @@ import { type CommentType, ProjectRoles } from 'nocodb-sdk'
 
 const props = defineProps<{
   loading: boolean
-  primaryKey: string
+  primaryKey: string | null
 }>()
 
 const {
diff --git a/packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue b/packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue
index 985ad6080a..d3942396a3 100644
--- a/packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue
+++ b/packages/nc-gui/components/smartsheet/toolbar/ColumnFilter.vue
@@ -878,7 +878,7 @@ const changeToDynamic = async (filter, i) => {
             'mt-1 mb-2': filters.length,
           }"
         >
-          <NcButton :ref="addFilterBtnRef" size="small" type="text" class="nc-btn-focus" @click.stop="addFilter()">
+          <NcButton size="small" type="text" class="nc-btn-focus" @click.stop="addFilter()">
             <div class="flex items-center gap-1">
               <component :is="iconMap.plus" />
               <!-- Add Filter -->
@@ -904,7 +904,7 @@ const changeToDynamic = async (filter, i) => {
             'mt-1 mb-2': filters.length,
           }"
         >
-          <NcButton :ref="addFilterBtnRef" class="nc-btn-focus" size="small" type="text" @click.stop="addFilter()">
+          <NcButton class="nc-btn-focus" size="small" type="text" @click.stop="addFilter()">
             <div class="flex items-center gap-1">
               <component :is="iconMap.plus" />
               <!-- Add Filter -->