From f47dcc5ad764089213ce36d61ee9c152f33f372d Mon Sep 17 00:00:00 2001
From: Raju Udava <86527202+dstala@users.noreply.github.com>
Date: Sat, 4 Feb 2023 16:32:39 +0530
Subject: [PATCH] test: select filters

Signed-off-by: Raju Udava <86527202+dstala@users.noreply.github.com>
---
 packages/nocodb/tests/unit/factory/row.ts     |  29 +++++
 .../tests/unit/rest/tests/filter.test.ts      | 109 ++++++++++++++++++
 2 files changed, 138 insertions(+)

diff --git a/packages/nocodb/tests/unit/factory/row.ts b/packages/nocodb/tests/unit/factory/row.ts
index 7ed81a64b4..4e4a656614 100644
--- a/packages/nocodb/tests/unit/factory/row.ts
+++ b/packages/nocodb/tests/unit/factory/row.ts
@@ -128,6 +128,31 @@ const rowMixedValue = (column: ColumnType, index: number) => {
     null,
   ];
 
+  const singleSelect = [
+    'jan',
+    'feb',
+    'mar',
+    'apr',
+    'may',
+    'jun',
+    'jul',
+    'aug',
+    'sep',
+    'oct',
+    'nov',
+    'dec',
+    null,
+  ];
+
+  const multiSelect = [
+    'jan,feb,mar',
+    'apr,may,jun',
+    'jul,aug,sep',
+    'oct,nov,dec',
+    'jan,feb,mar',
+    null,
+  ];
+
   switch (column.uidt) {
     case UITypes.Number:
     case UITypes.Percent:
@@ -151,6 +176,10 @@ const rowMixedValue = (column: ColumnType, index: number) => {
       return '2020-01-01';
     case UITypes.URL:
       return urls[index % urls.length];
+    case UITypes.SingleSelect:
+      return singleSelect[index % singleSelect.length];
+    case UITypes.MultiSelect:
+      return multiSelect[index % multiSelect.length];
     default:
       return `test-${index}`;
   }
diff --git a/packages/nocodb/tests/unit/rest/tests/filter.test.ts b/packages/nocodb/tests/unit/rest/tests/filter.test.ts
index 315fe226ab..3c83a22d04 100644
--- a/packages/nocodb/tests/unit/rest/tests/filter.test.ts
+++ b/packages/nocodb/tests/unit/rest/tests/filter.test.ts
@@ -111,6 +111,32 @@ async function retrieveRecordsAndValidate(
           record[title] !== null
       );
       break;
+    case 'anyof':
+      expectedRecords = unfilteredRecords.filter((record) => {
+        const values = filter.value.split(',');
+        const recordValue = record[title]?.split(',');
+        return values.some((value) => recordValue?.includes(value));
+      });
+      break;
+    case 'nanyof':
+      expectedRecords = unfilteredRecords.filter((record) => {
+        const values = filter.value.split(',');
+        const recordValue = record[title]?.split(',');
+        return !values.some((value) => recordValue?.includes(value));
+      });
+      break;
+    case 'allof':
+      expectedRecords = unfilteredRecords.filter((record) => {
+        const values = filter.value.split(',');
+        return values.every((value) => record[title]?.includes(value));
+      });
+      break;
+    case 'nallof':
+      expectedRecords = unfilteredRecords.filter((record) => {
+        const values = filter.value.split(',');
+        return !values.every((value) => record[title]?.includes(value));
+      });
+      break;
   }
 
   // retrieve filtered records
@@ -464,7 +490,90 @@ function filterNumberBased() {
   });
 }
 
+function filterSelectBased() {
+  // prepare data for test cases
+  beforeEach(async function () {
+    context = await init();
+    project = await createProject(context);
+    table = await createTable(context, project, {
+      table_name: 'selectBased',
+      title: 'selectBased',
+      columns: [
+        {
+          column_name: 'Id',
+          title: 'Id',
+          uidt: UITypes.ID,
+        },
+        {
+          column_name: 'SingleSelect',
+          title: 'SingleSelect',
+          uidt: UITypes.SingleSelect,
+          dtxp: "'jan','feb','mar', 'apr', 'may', 'jun', 'jul', 'aug', 'sep', 'oct', 'nov', 'dec'",
+        },
+        {
+          column_name: 'MultiSelect',
+          title: 'MultiSelect',
+          uidt: UITypes.MultiSelect,
+          dtxp: "'jan','feb','mar', 'apr', 'may', 'jun', 'jul', 'aug', 'sep', 'oct', 'nov', 'dec'",
+        },
+      ],
+    });
+
+    columns = await table.getColumns();
+
+    let rowAttributes = [];
+    for (let i = 0; i < 400; i++) {
+      let row = {
+        SingleSelect: rowMixedValue(columns[1], i),
+        MultiSelect: rowMixedValue(columns[2], i),
+      };
+      rowAttributes.push(row);
+    }
+
+    await createBulkRows(context, {
+      project,
+      table,
+      values: rowAttributes,
+    });
+    unfilteredRecords = await listRow({ project, table });
+
+    // verify length of unfiltered records to be 400
+    expect(unfilteredRecords.length).to.equal(400);
+  });
+
+  it('Type: Single select', async () => {
+    let filterList = [
+      { comparison_op: 'eq', value: 'jan' },
+      { comparison_op: 'neq', value: 'jan' },
+      { comparison_op: 'null', value: '' },
+      { comparison_op: 'notnull', value: '' },
+      { comparison_op: 'like', value: 'j' },
+      { comparison_op: 'nlike', value: 'j' },
+      { comparison_op: 'anyof', value: 'jan,feb,mar' },
+      { comparison_op: 'nanyof', value: 'jan,feb,mar' },
+    ];
+    await verifyFilters('SingleSelect', columns[1].id, filterList);
+  });
+
+  it('Type: Multi select', async () => {
+    let filterList = [
+      { comparison_op: 'eq', value: 'jan,feb,mar' },
+      { comparison_op: 'neq', value: 'jan,feb,mar' },
+      { comparison_op: 'null', value: '' },
+      { comparison_op: 'notnull', value: '' },
+      { comparison_op: 'like', value: 'jan' },
+      { comparison_op: 'nlike', value: 'jan' },
+      { comparison_op: 'anyof', value: 'jan,feb,mar' },
+      { comparison_op: 'nanyof', value: 'jan,feb,mar' },
+      { comparison_op: 'allof', value: 'jan,feb,mar' },
+      { comparison_op: 'nallof', value: 'jan,feb,mar' },
+    ];
+    await verifyFilters('MultiSelect', columns[2].id, filterList);
+  });
+}
+
 export default function () {
   describe('Filter: Text based', filterTextBased);
   describe('Filter: Numerical', filterNumberBased);
+  describe('Filter: Select based', filterSelectBased);
 }