From f0be54b0bc61495ef0ba2319b4810b12cea46c17 Mon Sep 17 00:00:00 2001
From: Ramesh Mane <101566080+rameshmane7218@users.noreply.github.com>
Date: Tue, 10 Dec 2024 07:57:58 +0000
Subject: [PATCH] fix(nc-gui): allow only specific column types for display
 value

---
 .../components/smartsheet/header/Menu.vue     |  7 ++--
 packages/nocodb-sdk/src/lib/UITypes.ts        | 32 +++++++++++++++++++
 .../nocodb-sdk/src/lib/helperFunctions.ts     | 18 +++++++++++
 packages/nocodb-sdk/src/lib/index.ts          |  1 +
 4 files changed, 53 insertions(+), 5 deletions(-)

diff --git a/packages/nc-gui/components/smartsheet/header/Menu.vue b/packages/nc-gui/components/smartsheet/header/Menu.vue
index 7643370472..bb97f621c7 100644
--- a/packages/nc-gui/components/smartsheet/header/Menu.vue
+++ b/packages/nc-gui/components/smartsheet/header/Menu.vue
@@ -1,6 +1,6 @@
 <script lang="ts" setup>
 import { type ColumnReqType, type ColumnType, partialUpdateAllowedTypes, readonlyMetaAllowedTypes } from 'nocodb-sdk'
-import { PlanLimitTypes, RelationTypes, UITypes, isLinksOrLTAR, isSystemColumn } from 'nocodb-sdk'
+import { PlanLimitTypes, RelationTypes, UITypes, isLinksOrLTAR, isSystemColumn, isSupportedDisplayValueColumn } from 'nocodb-sdk'
 import { SmartsheetStoreEvents, isColumnInvalid } from '#imports'
 
 const props = defineProps<{ virtual?: boolean; isOpen: boolean; isHiddenCol?: boolean }>()
@@ -578,10 +578,7 @@ const onDeleteColumn = () => {
             {{ isHiddenCol ? $t('general.showField') : $t('general.hideField') }}
           </div>
         </NcMenuItem>
-        <NcMenuItem
-          v-if="(!virtual || column?.uidt === UITypes.Formula) && !column?.pv && !isHiddenCol"
-          @click="setAsDisplayValue"
-        >
+        <NcMenuItem v-if="column && isSupportedDisplayValueColumn(column) && !column?.pv && !isHiddenCol" @click="setAsDisplayValue">
           <div class="nc-column-set-primary nc-header-menu-item item">
             <GeneralLoader v-if="isLoading === 'setDisplay'" size="regular" />
             <GeneralIcon v-else icon="star" class="text-gray-500 !w-4.25 !h-4.25" />
diff --git a/packages/nocodb-sdk/src/lib/UITypes.ts b/packages/nocodb-sdk/src/lib/UITypes.ts
index 813d9687f4..c150be6469 100644
--- a/packages/nocodb-sdk/src/lib/UITypes.ts
+++ b/packages/nocodb-sdk/src/lib/UITypes.ts
@@ -2,6 +2,7 @@ import { ColumnReqType, ColumnType, TableType } from './Api';
 import { FormulaDataTypes } from './formulaHelpers';
 import { LongTextAiMetaProp, RelationTypes } from '~/lib/globals';
 import { parseHelper } from './helperFunctions';
+import { ncParseProp } from './helperFunctions';
 
 enum UITypes {
   ID = 'ID',
@@ -331,3 +332,34 @@ export const getUITypesForFormulaDataType = (
       return [];
   }
 };
+
+export const isSupportedDisplayValueColumn = (column: ColumnType) => {
+  switch (column.uidt) {
+    case UITypes.SingleLineText:
+    case UITypes.Date:
+    case UITypes.DateTime:
+    case UITypes.Time:
+    case UITypes.Year:
+    case UITypes.PhoneNumber:
+    case UITypes.Email:
+    case UITypes.URL:
+    case UITypes.Number:
+    case UITypes.Currency:
+    case UITypes.Percent:
+    case UITypes.Duration:
+    case UITypes.Formula: {
+      return true;
+    }
+    case UITypes.LongText: {
+      if (ncParseProp(column.meta)?.richMode) {
+        return false;
+      }
+      //Todo: prevent AI Prompt field once it get merged in develop
+      return true;
+    }
+
+    default: {
+      return false;
+    }
+  }
+};
diff --git a/packages/nocodb-sdk/src/lib/helperFunctions.ts b/packages/nocodb-sdk/src/lib/helperFunctions.ts
index cb70719c21..e5a7e3c55c 100644
--- a/packages/nocodb-sdk/src/lib/helperFunctions.ts
+++ b/packages/nocodb-sdk/src/lib/helperFunctions.ts
@@ -228,6 +228,24 @@ export const integrationCategoryNeedDefault = (category: IntegrationsType) => {
   return [IntegrationsType.Ai].includes(category);
 };
 
+export function ncParseProp(v: any): any {
+  if (!v) return {};
+  try {
+    return typeof v === 'string' ? JSON.parse(v) ?? {} : v;
+  } catch {
+    return {};
+  }
+}
+
+export function ncStringifyProp(v: any): string {
+  if (!v) return '{}';
+  try {
+    return typeof v === 'string' ? v : JSON.stringify(v) ?? '{}';
+  } catch {
+    return '{}';
+  }
+}
+
 export function parseHelper(v: any): any {
   try {
     return typeof v === 'string' ? JSON.parse(v) : v;
diff --git a/packages/nocodb-sdk/src/lib/index.ts b/packages/nocodb-sdk/src/lib/index.ts
index 9f66861cd7..9993308c97 100644
--- a/packages/nocodb-sdk/src/lib/index.ts
+++ b/packages/nocodb-sdk/src/lib/index.ts
@@ -24,6 +24,7 @@ export {
   getUITypesForFormulaDataType,
   readonlyMetaAllowedTypes,
   partialUpdateAllowedTypes,
+  isSupportedDisplayValueColumn,
 } from '~/lib/UITypes';
 export { default as CustomAPI, FileType } from '~/lib/CustomAPI';
 export { default as TemplateGenerator } from '~/lib/TemplateGenerator';