Browse Source

fix: Gallery View delete using expanded form (#8595)

* fix: gallery view delete using expanded form

* fix: reload table after delete

* refactor: addressed review comments
nc-fix/duplicate-code
Rohit 1 month ago committed by GitHub
parent
commit
eff1bbd077
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
  1. 5
      packages/nc-gui/components/smartsheet/expanded-form/index.vue
  2. 10
      packages/nc-gui/components/smartsheet/grid/GroupByTable.vue
  3. 2
      packages/nc-gui/composables/useData.ts

5
packages/nc-gui/components/smartsheet/expanded-form/index.vue

@ -445,7 +445,10 @@ const onDeleteRowClick = () => {
const onConfirmDeleteRowClick = async () => {
showDeleteRowModal.value = false
await deleteRowById(primaryKey.value)
// Close expanded form
isExpanded.value = false
await deleteRowById(primaryKey.value || undefined)
message.success(t('msg.rowDeleted'))
await reloadViewDataTrigger.trigger({
shouldShowLoading: false,

10
packages/nc-gui/components/smartsheet/grid/GroupByTable.vue

@ -136,6 +136,14 @@ const pagination = computed(() => {
extraStyle: `margin-left: ${scrollBump.value}px;`,
}
})
async function deleteSelectedRowsWrapper() {
if (!deleteSelectedRows) return
await deleteSelectedRows()
// reload table data
await reloadTableData({ shouldShowLoading: true })
}
</script>
<template>
@ -151,7 +159,7 @@ const pagination = computed(() => {
:expand-form="props.expandForm"
:row-height="rowHeight"
:delete-row="deleteRow"
:delete-selected-rows="deleteSelectedRows"
:delete-selected-rows="deleteSelectedRowsWrapper"
:delete-range-of-rows="deleteRangeOfRows"
:update-or-save-row="updateOrSaveRow"
:remove-row-if-new="removeRowIfNew"

2
packages/nc-gui/composables/useData.ts

@ -11,7 +11,7 @@ export function useData(args: {
callbacks?: {
changePage?: (page: number) => Promise<void>
loadData?: () => Promise<void>
globalCallback?: (...args: any[]) => void
globalCallback?: (...args: any[]) => Promise<void>,
syncCount?: () => Promise<void>
syncPagination?: () => Promise<void>
}

Loading…
Cancel
Save