From b0127e4b9551f66d9d971ec110da62c3bfc9197b Mon Sep 17 00:00:00 2001 From: Wing-Kam Wong Date: Wed, 31 Aug 2022 12:01:54 +0800 Subject: [PATCH 1/2] fix: add missing extension for windows executables --- .github/workflows/release-executables.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release-executables.yml b/.github/workflows/release-executables.yml index 06f52cf6d0..1defd80b19 100644 --- a/.github/workflows/release-executables.yml +++ b/.github/workflows/release-executables.yml @@ -108,7 +108,7 @@ jobs: with: upload_url: ${{ steps.get_release.outputs.upload_url }} asset_path: ./scripts/pkg-executable/dist/Noco-win-arm64.exe - asset_name: Noco-win-arm64 + asset_name: Noco-win-arm64.exe asset_content_type: application/octet-stream - name: Upload win-x64 build to asset @@ -118,7 +118,7 @@ jobs: with: upload_url: ${{ steps.get_release.outputs.upload_url }} asset_path: ./scripts/pkg-executable/dist/Noco-win-x64.exe - asset_name: Noco-win-x64 + asset_name: Noco-win-x64.exe asset_content_type: application/octet-stream - name: Upload linux-arm64 build to asset From 653d5cdbd4c2d6af9779955ed0228c5382255338 Mon Sep 17 00:00:00 2001 From: Wing-Kam Wong Date: Wed, 31 Aug 2022 12:03:43 +0800 Subject: [PATCH 2/2] chore: iwp -> iwr --- .github/workflows/release-pr-v2.yml | 2 +- .github/workflows/release-pr.yml | 2 +- README.md | 4 ++-- packages/noco-docs/content/en/getting-started/installation.md | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/release-pr-v2.yml b/.github/workflows/release-pr-v2.yml index f071b08120..5ad0cd8136 100644 --- a/.github/workflows/release-pr-v2.yml +++ b/.github/workflows/release-pr-v2.yml @@ -119,7 +119,7 @@ jobs: # #### Windows # ```bash - # iwp http://dl.nocodb.com/${{ needs.set-tag.outputs.current_version }}-${{ needs.set-tag.outputs.target_tag }}/Noco-win-arm64.exe + # iwr http://dl.nocodb.com/${{ needs.set-tag.outputs.current_version }}-${{ needs.set-tag.outputs.target_tag }}/Noco-win-arm64.exe # .\Noco-win-arm64.exe # ``` diff --git a/.github/workflows/release-pr.yml b/.github/workflows/release-pr.yml index 2a4861e69c..cef6567386 100644 --- a/.github/workflows/release-pr.yml +++ b/.github/workflows/release-pr.yml @@ -119,7 +119,7 @@ jobs: #### Windows ```bash - iwp http://dl.nocodb.com/${{ needs.set-tag.outputs.current_version }}-${{ needs.set-tag.outputs.target_tag }}/Noco-win-arm64.exe + iwr http://dl.nocodb.com/${{ needs.set-tag.outputs.current_version }}-${{ needs.set-tag.outputs.target_tag }}/Noco-win-arm64.exe .\Noco-win-arm64.exe ``` diff --git a/README.md b/README.md index de68616177..07fbcba32c 100644 --- a/README.md +++ b/README.md @@ -170,13 +170,13 @@ curl http://get.nocodb.com/linux-arm64 -o nocodb -L && chmod +x nocodb && ./noco ##### Windows (x64) ```bash -iwp http://get.nocodb.com/win-x64 +iwr http://get.nocodb.com/win-x64.exe .\Noco-win-x64.exe ``` ##### Windows (arm64) ```bash -iwp http://get.nocodb.com/win-arm64 +iwr http://get.nocodb.com/win-arm64.exe .\Noco-win-arm64.exe ``` diff --git a/packages/noco-docs/content/en/getting-started/installation.md b/packages/noco-docs/content/en/getting-started/installation.md index 1613d046ed..b90855c49a 100644 --- a/packages/noco-docs/content/en/getting-started/installation.md +++ b/packages/noco-docs/content/en/getting-started/installation.md @@ -103,13 +103,13 @@ curl http://get.nocodb.com/linux-arm64 -o nocodb -L \ ##### Windows (x64) ```bash -iwp http://get.nocodb.com/win-x64 +iwr http://get.nocodb.com/win-x64.exe .\Noco-win-x64.exe ``` ##### Windows (arm64) ```bash -iwp http://get.nocodb.com/win-arm64 +iwr http://get.nocodb.com/win-arm64.exe .\Noco-win-arm64.exe ```