Browse Source

fix: handle data url using stream

pull/9722/head
mertmit 1 week ago
parent
commit
e75556c30d
  1. 5
      packages/nocodb/src/plugins/GenericS3/GenericS3.ts
  2. 18
      packages/nocodb/src/plugins/storage/Local.ts
  3. 31
      packages/nocodb/src/services/attachments.service.ts
  4. 8
      packages/nocodb/src/types/nc-plugin/lib/IStorageAdapterV2.ts

5
packages/nocodb/src/plugins/GenericS3/GenericS3.ts

@ -104,7 +104,10 @@ export default class GenericS3 implements IStorageAdapterV2 {
options?: {
mimetype?: string;
},
): Promise<void> {
): Promise<{
url: string | null;
data: any;
}> {
try {
const streamError = new Promise<void>((_, reject) => {
stream.on('error', (err) => {

18
packages/nocodb/src/plugins/storage/Local.ts

@ -70,13 +70,27 @@ export default class Local implements IStorageAdapterV2 {
public async fileCreateByStream(
key: string,
stream: Readable,
): Promise<void> {
): Promise<{
url: string | null;
data: any;
}> {
return new Promise((resolve, reject) => {
const destPath = validateAndNormaliseLocalPath(key);
try {
mkdirp(path.dirname(destPath)).then(() => {
const writableStream = fs.createWriteStream(destPath);
writableStream.on('finish', () => resolve());
writableStream.on('finish', () => {
this.fileRead(destPath)
.then((data) => {
resolve({
url: null,
data,
});
})
.catch((e) => {
reject(e);
});
});
writableStream.on('error', (err) => reject(err));
stream.pipe(writableStream);
});

31
packages/nocodb/src/services/attachments.service.ts

@ -1,5 +1,6 @@
import path from 'path';
import Url from 'url';
import { Readable } from 'stream';
import { AppEvents, PublicAttachmentScope } from 'nocodb-sdk';
import { forwardRef, Inject, Injectable, Logger } from '@nestjs/common';
import { nanoid } from 'nanoid';
@ -280,11 +281,23 @@ export class AttachmentsService {
size,
finalUrl = url;
let base64TempStream: Readable;
if (!url.startsWith('data:')) {
response = await axios.head(url, { maxRedirects: 5 });
mimeType = response.headers['content-type']?.split(';')[0];
size = response.headers['content-length'];
finalUrl = response.request.res.responseUrl;
} else {
const matches = url.match(/^data:(.+);base64,(.+)$/);
if (!matches) throw new Error('Invalid data URL format.');
// Extract MIME type and base64 data
const [, _mimeType, base64Data] = matches;
mimeType = _mimeType;
size = Buffer.byteLength(base64Data, 'base64');
base64TempStream = Readable.from(Buffer.from(base64Data, 'base64'));
}
const parsedUrl = Url.parse(finalUrl, true);
@ -303,7 +316,10 @@ export class AttachmentsService {
mimeType = mime.getType(path.extname(fileNameWithExt).slice(1));
}
const { url: attachmentUrl, data: file } =
let attachmentUrl, file;
if (!base64TempStream) {
const { url: _attachmentUrl, data: _file } =
await storageAdapter.fileCreateByUrl(
slash(path.join(fileDestPath, fileName)),
finalUrl,
@ -315,6 +331,19 @@ export class AttachmentsService {
},
);
attachmentUrl = _attachmentUrl;
file = _file;
} else {
const { url: _attachmentUrl, data: _file } =
(await storageAdapter.fileCreateByStream(
slash(path.join(fileDestPath, fileName)),
base64TempStream,
)) as any;
attachmentUrl = _attachmentUrl;
file = _file;
}
const tempMetadata: {
width?: number;
height?: number;

8
packages/nocodb/src/types/nc-plugin/lib/IStorageAdapterV2.ts

@ -30,7 +30,13 @@ export default interface IStorageAdapterV2<
url: string,
options?: FileCreateByUrlOptions,
): Promise<any>;
fileCreateByStream(destPath: string, readStream: Readable): Promise<void>;
fileCreateByStream(
destPath: string,
readStream: Readable,
): Promise<{
url: string | null;
data: any;
}>;
fileReadByStream(
key: string,
options?: { encoding?: string },

Loading…
Cancel
Save