From e5218981822b3cee477f128c9b0bd6ad2b5f32e8 Mon Sep 17 00:00:00 2001
From: Wing-Kam Wong <wingkwong.code@gmail.com>
Date: Thu, 29 Sep 2022 19:58:58 +0800
Subject: [PATCH] feat(nc-gui): allow downloads for kanban view

#3839
---
 packages/nc-gui/components/smartsheet/Toolbar.vue           | 4 +---
 packages/nc-gui/components/smartsheet/toolbar/ShareView.vue | 6 +++++-
 .../src/lib/meta/api/publicApis/publicDataExportApis.ts     | 4 ++--
 3 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/packages/nc-gui/components/smartsheet/Toolbar.vue b/packages/nc-gui/components/smartsheet/Toolbar.vue
index d2bc843e58..fdc15d7279 100644
--- a/packages/nc-gui/components/smartsheet/Toolbar.vue
+++ b/packages/nc-gui/components/smartsheet/Toolbar.vue
@@ -37,9 +37,7 @@ const { allowCSVDownload } = useSharedView()
 
     <LazySmartsheetToolbarShareView v-if="(isForm || isGrid || isKanban) && !isPublic" />
 
-    <LazySmartsheetToolbarExport
-      v-if="(!isPublic && !isUIAllowed('dataInsert') && !isKanban) || (isPublic && allowCSVDownload && !isKanban)"
-    />
+    <LazySmartsheetToolbarExport v-if="(!isPublic && !isUIAllowed('dataInsert')) || (isPublic && allowCSVDownload)" />
     <div class="flex-1" />
 
     <LazySmartsheetToolbarReload v-if="!isPublic && !isForm" class="mx-1" />
diff --git a/packages/nc-gui/components/smartsheet/toolbar/ShareView.vue b/packages/nc-gui/components/smartsheet/toolbar/ShareView.vue
index 3e76ccd682..2f36c516a3 100644
--- a/packages/nc-gui/components/smartsheet/toolbar/ShareView.vue
+++ b/packages/nc-gui/components/smartsheet/toolbar/ShareView.vue
@@ -173,7 +173,11 @@ watch(passwordProtected, (value) => {
           </div>
           <div>
             <!-- Allow Download -->
-            <a-checkbox v-if="shared && shared.type === ViewTypes.GRID" v-model:checked="allowCSVDownload" class="!text-xs">
+            <a-checkbox
+              v-if="shared && (shared.type === ViewTypes.GRID || shared.type === ViewTypes.KANBAN)"
+              v-model:checked="allowCSVDownload"
+              class="!text-xs"
+            >
               {{ $t('labels.downloadAllowed') }}
             </a-checkbox>
           </div>
diff --git a/packages/nocodb/src/lib/meta/api/publicApis/publicDataExportApis.ts b/packages/nocodb/src/lib/meta/api/publicApis/publicDataExportApis.ts
index f5ed20d574..a12a78a979 100644
--- a/packages/nocodb/src/lib/meta/api/publicApis/publicDataExportApis.ts
+++ b/packages/nocodb/src/lib/meta/api/publicApis/publicDataExportApis.ts
@@ -16,7 +16,7 @@ import getAst from '../../../db/sql-data-mapper/lib/sql/helpers/getAst';
 async function exportExcel(req: Request, res: Response) {
   const view = await View.getByUUID(req.params.publicDataUuid);
   if (!view) NcError.notFound('Not found');
-  if (view.type !== ViewTypes.GRID) NcError.notFound('Not found');
+  if (view.type !== ViewTypes.GRID && view.type !== ViewTypes.KANBAN) NcError.notFound('Not found');
 
   if (view.password && view.password !== req.headers?.['xc-password']) {
     NcError.forbidden(ErrorMessages.INVALID_SHARED_VIEW_PASSWORD);
@@ -47,7 +47,7 @@ async function exportCsv(req: Request, res: Response) {
   const fields = req.query.fields;
 
   if (!view) NcError.notFound('Not found');
-  if (view.type !== ViewTypes.GRID) NcError.notFound('Not found');
+  if (view.type !== ViewTypes.GRID && view.type !== ViewTypes.KANBAN) NcError.notFound('Not found');
 
   if (view.password && view.password !== req.headers?.['xc-password']) {
     NcError.forbidden(ErrorMessages.INVALID_SHARED_VIEW_PASSWORD);