From e520a5da3d21b47f4736fb65bf333dc816b51b78 Mon Sep 17 00:00:00 2001 From: Wing-Kam Wong Date: Thu, 6 Oct 2022 17:36:54 +0800 Subject: [PATCH] fix(nc-gui): allow comments to expand form --- packages/nc-gui/components/smartsheet/Gallery.vue | 2 -- packages/nc-gui/components/smartsheet/Grid.vue | 2 -- packages/nc-gui/components/smartsheet/Kanban.vue | 2 -- 3 files changed, 6 deletions(-) diff --git a/packages/nc-gui/components/smartsheet/Gallery.vue b/packages/nc-gui/components/smartsheet/Gallery.vue index 61d30865a5..8b39514128 100644 --- a/packages/nc-gui/components/smartsheet/Gallery.vue +++ b/packages/nc-gui/components/smartsheet/Gallery.vue @@ -92,8 +92,6 @@ const attachments = (record: any): Attachment[] => { } const expandForm = (row: RowType, state?: Record) => { - if (!isUIAllowed('xcDatatableEditable')) return - const rowId = extractPkFromRow(row.row, meta.value!.columns!) if (rowId) { diff --git a/packages/nc-gui/components/smartsheet/Grid.vue b/packages/nc-gui/components/smartsheet/Grid.vue index a513c770a5..43cfaf9e8a 100644 --- a/packages/nc-gui/components/smartsheet/Grid.vue +++ b/packages/nc-gui/components/smartsheet/Grid.vue @@ -139,8 +139,6 @@ reloadViewDataHook?.on(async (shouldShowLoading) => { const skipRowRemovalOnCancel = ref(false) const expandForm = (row: Row, state?: Record, fromToolbar = false) => { - if (!isUIAllowed('xcDatatableEditable')) return - const rowId = extractPkFromRow(row.row, meta.value?.columns as ColumnType[]) if (rowId) { diff --git a/packages/nc-gui/components/smartsheet/Kanban.vue b/packages/nc-gui/components/smartsheet/Kanban.vue index c12fddf0d4..9291e4e3d2 100644 --- a/packages/nc-gui/components/smartsheet/Kanban.vue +++ b/packages/nc-gui/components/smartsheet/Kanban.vue @@ -106,8 +106,6 @@ reloadViewMetaHook?.on(async () => { }) const expandForm = (row: RowType, state?: Record) => { - if (!hasEditPermission) return - const rowId = extractPkFromRow(row.row, meta.value!.columns!) if (rowId) {