From e5188cad1f78ca45b0b525f1f5f8b636ac91fbc7 Mon Sep 17 00:00:00 2001
From: Wing-Kam Wong <wingkwong.code@gmail.com>
Date: Mon, 5 Sep 2022 15:05:38 +0800
Subject: [PATCH] fix(gui-v2): infinite filter calls

---
 .../smartsheet-toolbar/ColumnFilterMenu.vue       | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/packages/nc-gui-v2/components/smartsheet-toolbar/ColumnFilterMenu.vue b/packages/nc-gui-v2/components/smartsheet-toolbar/ColumnFilterMenu.vue
index 2a16f9cadd..cbb6c4031b 100644
--- a/packages/nc-gui-v2/components/smartsheet-toolbar/ColumnFilterMenu.vue
+++ b/packages/nc-gui-v2/components/smartsheet-toolbar/ColumnFilterMenu.vue
@@ -1,6 +1,6 @@
 <script setup lang="ts">
 import type ColumnFilter from './ColumnFilter.vue'
-import { ActiveViewInj, IsLockedInj, IsPublicInj, computed, inject, ref, useGlobal, useViewFilters, watchEffect } from '#imports'
+import { ActiveViewInj, IsLockedInj, IsPublicInj, computed, inject, ref, useGlobal, useViewFilters } from '#imports'
 
 const isLocked = inject(IsLockedInj, ref(false))
 
@@ -10,8 +10,6 @@ const isPublic = inject(IsPublicInj, ref(false))
 
 const { filterAutoSave } = useGlobal()
 
-const state = useGlobal()
-
 const filterComp = ref<typeof ColumnFilter>()
 
 const { nestedFilters } = useSmartsheetStoreOrThrow()
@@ -27,13 +25,14 @@ const { filters, loadFilters } = useViewFilters(
 
 const filtersLength = ref(0)
 
-watchEffect(async () => {
-  if (activeView?.value && state.signedIn.value) {
+watch(
+  () => activeView?.value,
+  async () => {
     await loadFilters()
-
     filtersLength.value = filters.value.length || 0
-  }
-})
+  },
+  { immediate: true },
+)
 
 const applyChanges = async () => await filterComp.value?.applyChanges()
 </script>