Browse Source

Merge pull request #5869 from nocodb/refactor/5803-remove-delete-confirm

Remove delete confirm dialog
pull/5873/head
Raju Udava 1 year ago committed by GitHub
parent
commit
e46ec7f548
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 19
      packages/nc-gui/components/smartsheet/Grid.vue
  2. 2
      tests/playwright/pages/Dashboard/Grid/index.ts

19
packages/nc-gui/components/smartsheet/Grid.vue

@ -798,20 +798,11 @@ const closeAddColumnDropdown = (scrollToLastCol = false) => {
}
const confirmDeleteRow = (row: number) => {
Modal.confirm({
title: `Do you want to delete this row?`,
wrapClassName: 'nc-modal-row-delete',
okText: 'Yes',
okType: 'danger',
cancelText: 'No',
onOk() {
try {
deleteRow(row)
} catch (e: any) {
message.error(e.message)
}
},
})
try {
deleteRow(row)
} catch (e: any) {
message.error(e.message)
}
}
const deleteSelectedRangeOfRows = () => {

2
tests/playwright/pages/Dashboard/Grid/index.ts

@ -157,7 +157,7 @@ export class GridPage extends BasePage {
// Click text=Delete Row
await this.rootPage.locator('text=Delete Row').click();
await this.rootPage.locator('text=Yes').click();
// todo: improve selector
await this.rootPage
.locator('span.ant-dropdown-menu-title-content > nc-project-menu-item')

Loading…
Cancel
Save