From e413a220dd6983012fbf276bf88a5bc7fe1afd6b Mon Sep 17 00:00:00 2001
From: Muhammed Mustafa <mustafa@nocodb.com>
Date: Fri, 29 Sep 2023 10:35:23 +0530
Subject: [PATCH] fix: i18n for Currnecy

---
 packages/nc-gui/components/cell/Currency.vue         |  4 ++--
 .../components/smartsheet/column/CurrencyOptions.vue | 12 +++++++-----
 packages/nc-gui/lang/en.json                         |  5 +++++
 3 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/packages/nc-gui/components/cell/Currency.vue b/packages/nc-gui/components/cell/Currency.vue
index fc67d9274a..487a594178 100644
--- a/packages/nc-gui/components/cell/Currency.vue
+++ b/packages/nc-gui/components/cell/Currency.vue
@@ -79,7 +79,7 @@ onMounted(() => {
     v-model="vModel"
     type="number"
     class="w-full h-full text-sm border-none rounded-md outline-none"
-    :placeholder="isEditColumn ? '(Optional)' : ''"
+    :placeholder="isEditColumn ? $t('labels.optional') : ''"
     @blur="submitCurrency"
     @keydown.down.stop
     @keydown.left.stop
@@ -93,7 +93,7 @@ onMounted(() => {
     @contextmenu.stop
   />
 
-  <span v-else-if="vModel === null && showNull" class="nc-null">NULL</span>
+  <span v-else-if="vModel === null && showNull" class="nc-null">{{ $t('labels.null') }}</span>
 
   <!-- only show the numeric value as previously string value was accepted -->
   <span v-else-if="!isNaN(vModel)">{{ currency }}</span>
diff --git a/packages/nc-gui/components/smartsheet/column/CurrencyOptions.vue b/packages/nc-gui/components/smartsheet/column/CurrencyOptions.vue
index 63ce4816bd..f19d110c5e 100644
--- a/packages/nc-gui/components/smartsheet/column/CurrencyOptions.vue
+++ b/packages/nc-gui/components/smartsheet/column/CurrencyOptions.vue
@@ -12,6 +12,8 @@ const props = defineProps<{
 
 const emit = defineEmits(['update:value'])
 
+const { t } = useI18n()
+
 const vModel = useVModel(props, 'value', emit)
 
 const validators = {
@@ -20,7 +22,7 @@ const validators = {
       validator: (_: any, locale: any) => {
         return new Promise<void>((resolve, reject) => {
           if (!validateCurrencyLocale(locale)) {
-            return reject(new Error('Invalid locale'))
+            return reject(new Error(t('msg.invalidLocale')))
           }
           resolve()
         })
@@ -32,7 +34,7 @@ const validators = {
       validator: (_: any, currencyCode: any) => {
         return new Promise<void>((resolve, reject) => {
           if (!validateCurrencyCode(currencyCode)) {
-            return reject(new Error('Invalid Currency Code'))
+            return reject(new Error(t('msg.invalidCurrencyCode')))
           }
           resolve()
         })
@@ -54,7 +56,7 @@ const currencyLocaleList = ref<{ text: string; value: string }[]>([])
 const isMoney = computed(() => vModel.value.dt === 'money')
 
 const message = computed(() => {
-  if (isMoney.value && isPg.value) return "PostgreSQL 'money' type has own currency settings"
+  if (isMoney.value && isPg.value) return t('msg.postgresHasItsOwnCurrencySettings')
   return ''
 })
 
@@ -77,7 +79,7 @@ currencyLocales().then((locales) => {
 <template>
   <a-row gutter="8">
     <a-col :span="12">
-      <a-form-item v-bind="validateInfos['meta.currency_locale']" label="Currency Locale">
+      <a-form-item v-bind="validateInfos['meta.currency_locale']" :label="$t('title.currencyLocale')">
         <a-select
           v-model:value="vModel.meta.currency_locale"
           class="w-52"
@@ -94,7 +96,7 @@ currencyLocales().then((locales) => {
     </a-col>
 
     <a-col :span="12">
-      <a-form-item v-bind="validateInfos['meta.currency_code']" label="Currency Code">
+      <a-form-item v-bind="validateInfos['meta.currency_code']" :label="$t('title.currencyCode')">
         <a-select
           v-model:value="vModel.meta.currency_code"
           class="w-52"
diff --git a/packages/nc-gui/lang/en.json b/packages/nc-gui/lang/en.json
index 3a1b6d6ca1..c5666e6898 100644
--- a/packages/nc-gui/lang/en.json
+++ b/packages/nc-gui/lang/en.json
@@ -258,6 +258,8 @@
     "isNotNull": "is not null"
   },
   "title": {
+    "currencyLocale": "Currency Locale",
+    "currencyCode": "Currency Code",
     "searchMembers": "Search Members",
     "noMembersFound": "No members found",
     "dateJoined": "Date Joined",
@@ -764,6 +766,9 @@
     "selectField": "Select field"
   },
   "msg": {
+    "invalidLocale": "Invalid locale",
+    "invalidCurrencyCode": "Invalid Currency Code",
+    "postgresHasItsOwnCurrencySettings": "PostgreSQL 'money' type has own currency settings",
     "validColumnsForBarCode": "The valid Column Types for a Barcode Column are: Number, Single Line Text, Long Text, Phone Number, URL, Email, Decimal. Please create one first.",
     "hm": {
       "title": "Has Many Relation",