Browse Source

chore : view_name column should be a string

re: 647

Signed-off-by: Naveen MR <oof1lab@gmail.com>
pull/653/head
Naveen MR 3 years ago
parent
commit
e0e210fcda
  1. 17
      packages/nocodb/src/lib/noco/common/XcMigrationSource.ts
  2. 38
      packages/nocodb/src/lib/noco/migrations/nc_006_alter_nc_shared_views.ts
  3. 38
      packages/nocodb/src/lib/noco/migrations/nc_007_alter_nc_shared_views_1.ts

17
packages/nocodb/src/lib/noco/common/XcMigrationSource.ts

@ -3,6 +3,8 @@ import * as m2m from '../migrations/nc_002_add_m2m';
import * as fkn from '../migrations/nc_003_add_fkn_column';
import * as viewType from '../migrations/nc_004_add_view_type_column';
import * as viewName from '../migrations/nc_005_add_view_name_column';
import * as nc_006_alter_nc_shared_views from '../migrations/nc_006_alter_nc_shared_views';
import * as nc_007_alter_nc_shared_views_1 from '../migrations/nc_007_alter_nc_shared_views_1';
// Create a custom migration source class
export default class XcMigrationSource {
@ -11,7 +13,15 @@ export default class XcMigrationSource {
// arguments to getMigrationName and getMigration
public getMigrations(): Promise<any> {
// In this example we are just returning migration names
return Promise.resolve(['project', 'm2m', 'fkn', 'viewType', 'viewName']);
return Promise.resolve([
'project',
'm2m',
'fkn',
'viewType',
'viewName',
'nc_006_alter_nc_shared_views',
'nc_007_alter_nc_shared_views_1'
]);
}
public getMigrationName(migration): string {
@ -30,6 +40,11 @@ export default class XcMigrationSource {
return viewType;
case 'viewName':
return viewName;
case 'nc_006_alter_nc_shared_views':
return nc_006_alter_nc_shared_views;
case 'nc_007_alter_nc_shared_views_1':
return nc_007_alter_nc_shared_views_1;
}
}
}

38
packages/nocodb/src/lib/noco/migrations/nc_006_alter_nc_shared_views.ts

@ -0,0 +1,38 @@
import Knex from 'knex';
const up = async (knex: Knex) => {
await knex.schema.alterTable('nc_shared_views', table => {
table.dropColumns('view_name');
});
};
const down = async knex => {
await knex.schema.alterTable('nc_shared_views', table => {
table.integer('view_name');
});
};
export { up, down };
/**
* @copyright Copyright (c) 2021, Xgene Cloud Ltd
*
* @author Naveen MR <oof1lab@gmail.com>
* @author Pranav C Balan <pranavxc@gmail.com>
*
* @license GNU AGPL version 3 or any later version
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as
* published by the Free Software Foundation, either version 3 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/

38
packages/nocodb/src/lib/noco/migrations/nc_007_alter_nc_shared_views_1.ts

@ -0,0 +1,38 @@
import Knex from 'knex';
const up = async (knex: Knex) => {
await knex.schema.alterTable('nc_shared_views', table => {
table.string('view_name',255);
});
};
const down = async knex => {
await knex.schema.alterTable('nc_shared_views', table => {
table.dropColumns('view_name');
});
};
export { up, down };
/**
* @copyright Copyright (c) 2021, Xgene Cloud Ltd
*
* @author Naveen MR <oof1lab@gmail.com>
* @author Pranav C Balan <pranavxc@gmail.com>
*
* @license GNU AGPL version 3 or any later version
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as
* published by the Free Software Foundation, either version 3 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
Loading…
Cancel
Save