From df9fb1f3ee367ec632235f67653d296349b8ac75 Mon Sep 17 00:00:00 2001
From: Pranav C <pranavxc@gmail.com>
Date: Thu, 11 Aug 2022 01:46:56 +0530
Subject: [PATCH] chore(gui-v2): lint

Signed-off-by: Pranav C <pranavxc@gmail.com>
---
 packages/nc-gui-v2/components.d.ts                |  1 +
 .../components/smartsheet/expanded-form/index.vue |  1 -
 .../components/virtual-cell/BelongsTo.vue         |  3 +--
 .../nc-gui-v2/components/virtual-cell/HasMany.vue |  3 +--
 .../components/virtual-cell/ManyToMany.vue        |  3 +--
 .../virtual-cell/components/ItemChip.vue          |  5 ++---
 .../virtual-cell/components/ListChildItems.vue    |  3 +--
 .../virtual-cell/components/ListItems.vue         |  4 +---
 .../nc-gui-v2/composables/useExpandedFormStore.ts | 15 ++++++++++-----
 .../composables/useSmartsheetRowStore.ts          |  9 +++------
 10 files changed, 21 insertions(+), 26 deletions(-)

diff --git a/packages/nc-gui-v2/components.d.ts b/packages/nc-gui-v2/components.d.ts
index 1b40185183..66d7e13522 100644
--- a/packages/nc-gui-v2/components.d.ts
+++ b/packages/nc-gui-v2/components.d.ts
@@ -90,6 +90,7 @@ declare module '@vue/runtime-core' {
     MdiCheck: typeof import('~icons/mdi/check')['default']
     MdiChevronDown: typeof import('~icons/mdi/chevron-down')['default']
     MdiCloseCircle: typeof import('~icons/mdi/close-circle')['default']
+    MdiCloseThick: typeof import('~icons/mdi/close-thick')['default']
     MdiContentCopy: typeof import('~icons/mdi/content-copy')['default']
     MdiContentSave: typeof import('~icons/mdi/content-save')['default']
     MdiDatabase: typeof import('~icons/mdi/database')['default']
diff --git a/packages/nc-gui-v2/components/smartsheet/expanded-form/index.vue b/packages/nc-gui-v2/components/smartsheet/expanded-form/index.vue
index 07e23bb93c..e9aa0a1782 100644
--- a/packages/nc-gui-v2/components/smartsheet/expanded-form/index.vue
+++ b/packages/nc-gui-v2/components/smartsheet/expanded-form/index.vue
@@ -17,7 +17,6 @@ interface Props {
   state?: Record<string, any> | null
   meta: TableType
   loadRow?: boolean
-
   useMetaFields?: boolean
 }
 
diff --git a/packages/nc-gui-v2/components/virtual-cell/BelongsTo.vue b/packages/nc-gui-v2/components/virtual-cell/BelongsTo.vue
index 58dbc63748..90eab444a0 100644
--- a/packages/nc-gui-v2/components/virtual-cell/BelongsTo.vue
+++ b/packages/nc-gui-v2/components/virtual-cell/BelongsTo.vue
@@ -3,8 +3,7 @@ import type { ColumnType } from 'nocodb-sdk'
 import type { Ref } from 'vue'
 import ItemChip from './components/ItemChip.vue'
 import ListItems from './components/ListItems.vue'
-import { useSmartsheetRowStoreOrThrow } from '~/composables/useSmartsheetRowStore'
-import { inject, ref, useProvideLTARStore } from '#imports'
+import { inject, ref, useProvideLTARStore, useSmartsheetRowStoreOrThrow } from '#imports'
 import { CellValueInj, ColumnInj, ReloadViewDataHookInj, RowInj } from '~/context'
 
 const column = inject(ColumnInj)
diff --git a/packages/nc-gui-v2/components/virtual-cell/HasMany.vue b/packages/nc-gui-v2/components/virtual-cell/HasMany.vue
index 44e81dfe9a..ae69d0f2e9 100644
--- a/packages/nc-gui-v2/components/virtual-cell/HasMany.vue
+++ b/packages/nc-gui-v2/components/virtual-cell/HasMany.vue
@@ -4,8 +4,7 @@ import type { Ref } from 'vue'
 import ItemChip from './components/ItemChip.vue'
 import ListChildItems from './components/ListChildItems.vue'
 import ListItems from './components/ListItems.vue'
-import { useSmartsheetRowStoreOrThrow } from '~/composables/useSmartsheetRowStore'
-import { computed, inject, ref, useProvideLTARStore } from '#imports'
+import { computed, inject, ref, useProvideLTARStore, useSmartsheetRowStoreOrThrow } from '#imports'
 import { CellValueInj, ColumnInj, IsFormInj, ReloadViewDataHookInj, RowInj } from '~/context'
 
 const column = inject(ColumnInj)!
diff --git a/packages/nc-gui-v2/components/virtual-cell/ManyToMany.vue b/packages/nc-gui-v2/components/virtual-cell/ManyToMany.vue
index 74da7c9476..5275a8d3ba 100644
--- a/packages/nc-gui-v2/components/virtual-cell/ManyToMany.vue
+++ b/packages/nc-gui-v2/components/virtual-cell/ManyToMany.vue
@@ -4,8 +4,7 @@ import type { Ref } from 'vue'
 import ItemChip from './components/ItemChip.vue'
 import ListChildItems from './components/ListChildItems.vue'
 import ListItems from './components/ListItems.vue'
-import { useSmartsheetRowStoreOrThrow } from '~/composables/useSmartsheetRowStore'
-import { computed, inject, ref, useProvideLTARStore } from '#imports'
+import { computed, inject, ref, useProvideLTARStore, useSmartsheetRowStoreOrThrow } from '#imports'
 import { CellValueInj, ColumnInj, IsFormInj, ReloadViewDataHookInj, RowInj } from '~/context'
 
 const column = inject(ColumnInj)!
diff --git a/packages/nc-gui-v2/components/virtual-cell/components/ItemChip.vue b/packages/nc-gui-v2/components/virtual-cell/components/ItemChip.vue
index b9efafd542..e7f0a5a7f7 100644
--- a/packages/nc-gui-v2/components/virtual-cell/components/ItemChip.vue
+++ b/packages/nc-gui-v2/components/virtual-cell/components/ItemChip.vue
@@ -1,7 +1,6 @@
 <script setup lang="ts">
-import { useLTARStoreOrThrow } from '~/composables'
+import { useLTARStoreOrThrow } from '#imports'
 import { ActiveCellInj, IsFormInj, ReadonlyInj } from '~/context'
-import MdiCloseThickIcon from '~icons/mdi/close-thick'
 
 interface Props {
   value?: string | number | boolean
@@ -29,7 +28,7 @@ const expandedFormDlg = ref(false)
   >
     <span class="name">{{ value }}</span>
     <div v-show="active || isForm" v-if="!readonly" class="flex align-center">
-      <MdiCloseThickIcon class="unlink-icon text-xs text-gray-500/50 group-hover:text-gray-500" @click.stop="emit('unlink')" />
+      <MdiCloseThick class="unlink-icon text-xs text-gray-500/50 group-hover:text-gray-500" @click.stop="emit('unlink')" />
     </div>
 
     <SmartsheetExpandedForm
diff --git a/packages/nc-gui-v2/components/virtual-cell/components/ListChildItems.vue b/packages/nc-gui-v2/components/virtual-cell/components/ListChildItems.vue
index 868a56d750..b23650caa3 100644
--- a/packages/nc-gui-v2/components/virtual-cell/components/ListChildItems.vue
+++ b/packages/nc-gui-v2/components/virtual-cell/components/ListChildItems.vue
@@ -1,8 +1,7 @@
 <script lang="ts" setup>
 import { Modal } from 'ant-design-vue'
 import type { ColumnType } from 'nocodb-sdk'
-import { useLTARStoreOrThrow, useVModel, watch } from '#imports'
-import { useSmartsheetRowStoreOrThrow } from '~/composables/useSmartsheetRowStore'
+import { useLTARStoreOrThrow, useSmartsheetRowStoreOrThrow, useVModel, watch } from '#imports'
 import { ColumnInj, IsFormInj } from '~/context'
 
 const props = defineProps<{ modelValue?: boolean }>()
diff --git a/packages/nc-gui-v2/components/virtual-cell/components/ListItems.vue b/packages/nc-gui-v2/components/virtual-cell/components/ListItems.vue
index 0391df401c..0bda4eb1d0 100644
--- a/packages/nc-gui-v2/components/virtual-cell/components/ListItems.vue
+++ b/packages/nc-gui-v2/components/virtual-cell/components/ListItems.vue
@@ -1,9 +1,7 @@
 <script lang="ts" setup>
 import { RelationTypes, UITypes } from 'nocodb-sdk'
 import type { ColumnType, LinkToAnotherRecordType } from 'nocodb-sdk'
-import { computed } from 'vue'
-import { useLTARStoreOrThrow, useVModel } from '#imports'
-import { useSmartsheetRowStoreOrThrow } from '~/composables/useSmartsheetRowStore'
+import { computed, useLTARStoreOrThrow, useSmartsheetRowStoreOrThrow, useVModel } from '#imports'
 import { ColumnInj } from '~/context'
 
 const props = defineProps<{ modelValue: boolean }>()
diff --git a/packages/nc-gui-v2/composables/useExpandedFormStore.ts b/packages/nc-gui-v2/composables/useExpandedFormStore.ts
index b0a359e459..6c78f9f150 100644
--- a/packages/nc-gui-v2/composables/useExpandedFormStore.ts
+++ b/packages/nc-gui-v2/composables/useExpandedFormStore.ts
@@ -3,12 +3,9 @@ import type { ColumnType, TableType } from 'nocodb-sdk'
 import type { Ref } from 'vue'
 import { message, notification } from 'ant-design-vue'
 import dayjs from 'dayjs'
-import getPlainText from '../../nc-gui/components/project/spreadsheet/helpers/getPlainText'
-import { useProvideSmartsheetRowStore } from '~/composables/useSmartsheetRowStore'
+import { useApi, useInjectionState, useProject, useProvideSmartsheetRowStore } from '#imports'
 import { NOCO } from '~/lib'
 import { useNuxtApp } from '#app'
-import { useInjectionState, useProject } from '#imports'
-import { useApi } from '~/composables/useApi'
 import type { Row } from '~/composables/useViewData'
 import { extractPkFromRow, extractSdkResponseErrorMsg } from '~/utils'
 
@@ -87,8 +84,9 @@ const [useProvideExpandedFormStore, useExpandedFormStore] = useInjectionState((m
       await api.utils.commentRow({
         fk_model_id: meta.value?.id as string,
         row_id: rowId,
+        // todo: swagger type correction
         description: comment.value,
-      })
+      } as any)
 
       comment.value = ''
       message.success('Comment added successfully')
@@ -202,3 +200,10 @@ export function useExpandedFormStoreOrThrow() {
   if (expandedFormStore == null) throw new Error('Please call `useExpandedFormStore` on the appropriate parent component')
   return expandedFormStore
 }
+
+// todo: move to utils
+function getPlainText(htmlString: string) {
+  const div = document.createElement('div')
+  div.textContent = htmlString || ''
+  return div.innerHTML
+}
diff --git a/packages/nc-gui-v2/composables/useSmartsheetRowStore.ts b/packages/nc-gui-v2/composables/useSmartsheetRowStore.ts
index da4dfea60e..c07b52ae79 100644
--- a/packages/nc-gui-v2/composables/useSmartsheetRowStore.ts
+++ b/packages/nc-gui-v2/composables/useSmartsheetRowStore.ts
@@ -1,13 +1,10 @@
 import { notification } from 'ant-design-vue'
 import { UITypes } from 'nocodb-sdk'
-import type { ColumnType, LinkToAnotherRecordType, TableType } from 'nocodb-sdk'
+import type { ColumnType, LinkToAnotherRecordType, RelationTypes, TableType } from 'nocodb-sdk'
 import type { Ref } from 'vue'
 import { useNuxtApp } from '#app'
-import { useInjectionState } from '#imports'
-import { useMetas } from '~/composables/useMetas'
-import { useProject } from '~/composables/useProject'
+import { useInjectionState, useMetas, useProject, useVirtualCell } from '#imports'
 import type { Row } from '~/composables/useViewData'
-import { useVirtualCell } from '~/composables/useVirtualCell'
 import { NOCO } from '~/lib'
 import { extractPkFromRow, extractSdkResponseErrorMsg } from '~/utils'
 
@@ -43,7 +40,7 @@ const [useProvideSmartsheetRowStore, useSmartsheetRowStore] = useInjectionState(
     }
   }
 
-  const linkRecord = async (rowId: string, relatedRowId: string, column: ColumnType, type) => {
+  const linkRecord = async (rowId: string, relatedRowId: string, column: ColumnType, type: RelationTypes) => {
     try {
       await $api.dbTableRow.nestedAdd(
         NOCO,