Browse Source

Merge pull request #5743 from nocodb/fix/sqlite-transaction-stuck

fix: rollback transaction if bulk insert errors
pull/5749/head
Raju Udava 2 years ago committed by GitHub
parent
commit
dc93068546
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 4
      packages/nocodb/src/db/BaseModelSqlv2.ts

4
packages/nocodb/src/db/BaseModelSqlv2.ts

@ -2091,6 +2091,7 @@ class BaseModelSqlv2 {
raw?: boolean;
} = {},
) {
let trx;
try {
// TODO: ag column handling for raw bulk insert
const insertDatas = raw
@ -2115,7 +2116,7 @@ class BaseModelSqlv2 {
// refer : https://www.sqlite.org/limits.html
const chunkSize = this.isSqlite ? 10 : _chunkSize;
const trx = await this.dbDriver.transaction();
trx = await this.dbDriver.transaction();
if (!foreign_key_checks) {
if (this.isPg) {
@ -2146,6 +2147,7 @@ class BaseModelSqlv2 {
return response;
} catch (e) {
await trx?.rollback();
// await this.errorInsertb(e, data, null);
throw e;
}

Loading…
Cancel
Save