From daca01b4797ef3ac9dab1be0acec3eebd836b455 Mon Sep 17 00:00:00 2001 From: Muhammed Mustafa Date: Wed, 27 Sep 2023 13:51:19 +0530 Subject: [PATCH] fix: Upgraded playwright version and minor test fixes --- packages/nc-gui/components.d.ts | 10 ------- pnpm-lock.yaml | 27 ++++++++++++------- tests/playwright/package.json | 2 +- .../pages/Dashboard/ViewSidebar/index.ts | 2 +- 4 files changed, 19 insertions(+), 22 deletions(-) diff --git a/packages/nc-gui/components.d.ts b/packages/nc-gui/components.d.ts index 142768f672..f788dcdca0 100644 --- a/packages/nc-gui/components.d.ts +++ b/packages/nc-gui/components.d.ts @@ -52,7 +52,6 @@ declare module '@vue/runtime-core' { APagination: typeof import('ant-design-vue/es')['Pagination'] APopover: typeof import('ant-design-vue/es')['Popover'] ARadio: typeof import('ant-design-vue/es')['Radio'] - ARadioButton: typeof import('ant-design-vue/es')['RadioButton'] ARadioGroup: typeof import('ant-design-vue/es')['RadioGroup'] ARate: typeof import('ant-design-vue/es')['Rate'] ARow: typeof import('ant-design-vue/es')['Row'] @@ -81,7 +80,6 @@ declare module '@vue/runtime-core' { CilFullscreenExit: typeof import('~icons/cil/fullscreen-exit')['default'] ClaritySuccessLine: typeof import('~icons/clarity/success-line')['default'] IcBaselineMoreVert: typeof import('~icons/ic/baseline-more-vert')['default'] - Icon: typeof import('~icons/ic/on')['default'] IcOutlineInsertDriveFile: typeof import('~icons/ic/outline-insert-drive-file')['default'] IcRoundEdit: typeof import('~icons/ic/round-edit')['default'] IcRoundKeyboardArrowDown: typeof import('~icons/ic/round-keyboard-arrow-down')['default'] @@ -105,12 +103,9 @@ declare module '@vue/runtime-core' { MaterialSymbolsVisibility: typeof import('~icons/material-symbols/visibility')['default'] MaterialSymbolsVisibilityOff: typeof import('~icons/material-symbols/visibility-off')['default'] MaterialSymbolsWarning: typeof import('~icons/material-symbols/warning')['default'] - MdiAccordionUp: typeof import('~icons/mdi/accordion-up')['default'] MdiAccount: typeof import('~icons/mdi/account')['default'] MdiAccountCircleOutline: typeof import('~icons/mdi/account-circle-outline')['default'] - MdiAccountCircleOutlines: typeof import('~icons/mdi/account-circle-outlines')['default'] MdiAccountSupervisorOutline: typeof import('~icons/mdi/account-supervisor-outline')['default'] - MdiAlpha: typeof import('~icons/mdi/alpha')['default'] MdiAppleKeyboardShift: typeof import('~icons/mdi/apple-keyboard-shift')['default'] MdiArrowDownDropCircle: typeof import('~icons/mdi/arrow-down-drop-circle')['default'] MdiArrowDownDropCircleOutline: typeof import('~icons/mdi/arrow-down-drop-circle-outline')['default'] @@ -121,9 +116,7 @@ declare module '@vue/runtime-core' { MdiCardsHeart: typeof import('~icons/mdi/cards-heart')['default'] MdiCellphoneMessage: typeof import('~icons/mdi/cellphone-message')['default'] MdiChat: typeof import('~icons/mdi/chat')['default'] - MdiChatProcessingOutline: typeof import('~icons/mdi/chat-processing-outline')['default'] MdiCheck: typeof import('~icons/mdi/check')['default'] - MdiChevronDown: typeof import('~icons/mdi/chevron-down')['default'] MdiChevronLeft: typeof import('~icons/mdi/chevron-left')['default'] MdiChevronRight: typeof import('~icons/mdi/chevron-right')['default'] MdiChevronUp: typeof import('~icons/mdi/chevron-up')['default'] @@ -151,7 +144,6 @@ declare module '@vue/runtime-core' { MdiMessageOutline: typeof import('~icons/mdi/message-outline')['default'] MdiMicrosoftTeams: typeof import('~icons/mdi/microsoft-teams')['default'] MdiMoonFull: typeof import('~icons/mdi/moon-full')['default'] - MdiMoreVert: typeof import('~icons/mdi/more-vert')['default'] MdiPlus: typeof import('~icons/mdi/plus')['default'] MdiReload: typeof import('~icons/mdi/reload')['default'] MdiRocketLaunchOutline: typeof import('~icons/mdi/rocket-launch-outline')['default'] @@ -168,9 +160,7 @@ declare module '@vue/runtime-core' { MdiWhatsapp: typeof import('~icons/mdi/whatsapp')['default'] MiCircleWarning: typeof import('~icons/mi/circle-warning')['default'] NcIconsInbox: typeof import('~icons/nc-icons/inbox')['default'] - PhLink: typeof import('~icons/ph/link')['default'] PhMagnifyingGlassBold: typeof import('~icons/ph/magnifying-glass-bold')['default'] - PhTriangleFill: typeof import('~icons/ph/triangle-fill')['default'] RiExternalLinkLine: typeof import('~icons/ri/external-link-line')['default'] RouterLink: typeof import('vue-router')['RouterLink'] RouterView: typeof import('vue-router')['RouterView'] diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 02032942b0..ff9b5bda97 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -932,8 +932,8 @@ importers: version: 0.18.5 devDependencies: '@playwright/test': - specifier: 1.36.1 - version: 1.36.1 + specifier: 1.38.0 + version: 1.38.0 '@typescript-eslint/eslint-plugin': specifier: ^6.1.0 version: 6.1.0(@typescript-eslint/parser@6.1.0)(eslint@8.33.0)(typescript@5.2.2) @@ -5610,15 +5610,12 @@ packages: dev: true optional: true - /@playwright/test@1.36.1: - resolution: {integrity: sha512-YK7yGWK0N3C2QInPU6iaf/L3N95dlGdbsezLya4n0ZCh3IL7VgPGxC6Gnznh9ApWdOmkJeleT2kMTcWPRZvzqg==} + /@playwright/test@1.38.0: + resolution: {integrity: sha512-xis/RXXsLxwThKnlIXouxmIvvT3zvQj1JE39GsNieMUrMpb3/GySHDh2j8itCG22qKVD4MYLBp7xB73cUW/UUw==} engines: {node: '>=16'} hasBin: true dependencies: - '@types/node': 20.3.1 - playwright-core: 1.36.1 - optionalDependencies: - fsevents: 2.3.2 + playwright: 1.38.0 dev: true /@polka/url@1.0.0-next.21: @@ -18477,10 +18474,20 @@ packages: mlly: 1.4.1 pathe: 1.1.1 - /playwright-core@1.36.1: - resolution: {integrity: sha512-7+tmPuMcEW4xeCL9cp9KxmYpQYHKkyjwoXRnoeTowaeNat8PoBMk/HwCYhqkH2fRkshfKEOiVus/IhID2Pg8kg==} + /playwright-core@1.38.0: + resolution: {integrity: sha512-f8z1y8J9zvmHoEhKgspmCvOExF2XdcxMW8jNRuX4vkQFrzV4MlZ55iwb5QeyiFQgOFCUolXiRHgpjSEnqvO48g==} + engines: {node: '>=16'} + hasBin: true + dev: true + + /playwright@1.38.0: + resolution: {integrity: sha512-fJGw+HO0YY+fU/F1N57DMO+TmXHTrmr905J05zwAQE9xkuwP/QLDk63rVhmyxh03dYnEhnRbsdbH9B0UVVRB3A==} engines: {node: '>=16'} hasBin: true + dependencies: + playwright-core: 1.38.0 + optionalDependencies: + fsevents: 2.3.2 dev: true /plimit-lit@1.5.0: diff --git a/tests/playwright/package.json b/tests/playwright/package.json index d17657e6b6..b64fb1636f 100644 --- a/tests/playwright/package.json +++ b/tests/playwright/package.json @@ -48,7 +48,7 @@ "xlsx": "^0.18.5" }, "devDependencies": { - "@playwright/test": "1.36.1", + "@playwright/test": "1.38.0", "@typescript-eslint/eslint-plugin": "^6.1.0", "@typescript-eslint/parser": "^6.1.0", "axios": "^0.24.0", diff --git a/tests/playwright/pages/Dashboard/ViewSidebar/index.ts b/tests/playwright/pages/Dashboard/ViewSidebar/index.ts index 35376ff9c3..9f6b7735ed 100644 --- a/tests/playwright/pages/Dashboard/ViewSidebar/index.ts +++ b/tests/playwright/pages/Dashboard/ViewSidebar/index.ts @@ -134,7 +134,7 @@ export class ViewSidebarPage extends BasePage { force: true, }); - await this.rootPage.locator('button:has-text("Delete View"):visible').click(); + await this.rootPage.locator('button:has-text("Delete"):visible').click(); } async renameView({ title, newTitle }: { title: string; newTitle: string }) {