From d7e948c1405a1fb4cbe039c3643128955ab623ab Mon Sep 17 00:00:00 2001 From: Mert E Date: Mon, 20 May 2024 10:26:01 +0300 Subject: [PATCH] fix: match i18n & pw locator for createView (#8528) Signed-off-by: mertmit --- packages/nc-gui/lang/ar.json | 2 +- packages/nc-gui/lang/bn_IN.json | 2 +- packages/nc-gui/lang/da.json | 2 +- packages/nc-gui/lang/en.json | 4 ++-- packages/nc-gui/lang/eu.json | 4 ++-- packages/nc-gui/lang/fa.json | 2 +- packages/nc-gui/lang/fi.json | 2 +- packages/nc-gui/lang/he.json | 2 +- packages/nc-gui/lang/hi.json | 2 +- packages/nc-gui/lang/hr.json | 2 +- packages/nc-gui/lang/id.json | 2 +- packages/nc-gui/lang/ja.json | 2 +- packages/nc-gui/lang/lv.json | 2 +- packages/nc-gui/lang/nl.json | 2 +- packages/nc-gui/lang/no.json | 2 +- packages/nc-gui/lang/pt_BR.json | 2 +- packages/nc-gui/lang/ru.json | 2 +- packages/nc-gui/lang/sk.json | 2 +- packages/nc-gui/lang/sl.json | 2 +- packages/nc-gui/lang/sv.json | 2 +- packages/nc-gui/lang/th.json | 2 +- packages/nc-gui/lang/uk.json | 2 +- packages/nc-gui/lang/vi.json | 2 +- packages/nc-gui/lang/zh-Hant.json | 2 +- tests/playwright/pages/Dashboard/ViewSidebar/index.ts | 2 +- 25 files changed, 27 insertions(+), 27 deletions(-) diff --git a/packages/nc-gui/lang/ar.json b/packages/nc-gui/lang/ar.json index c9816a6c90..c46c92e9e2 100644 --- a/packages/nc-gui/lang/ar.json +++ b/packages/nc-gui/lang/ar.json @@ -589,7 +589,7 @@ "untitledToken": "Untitled token", "tableName": "اسم الجدول", "dashboardName": "Dashboard name", - "createView": "Create a View", + "createView": "Create View", "creatingView": "Creating View", "duplicateView": "Duplicate View", "duplicateGridView": "Duplicate Grid View", diff --git a/packages/nc-gui/lang/bn_IN.json b/packages/nc-gui/lang/bn_IN.json index a4b21b252a..0518ab100c 100644 --- a/packages/nc-gui/lang/bn_IN.json +++ b/packages/nc-gui/lang/bn_IN.json @@ -589,7 +589,7 @@ "untitledToken": "Untitled token", "tableName": "Table name", "dashboardName": "Dashboard name", - "createView": "Create a View", + "createView": "Create View", "creatingView": "Creating View", "duplicateView": "Duplicate View", "duplicateGridView": "Duplicate Grid View", diff --git a/packages/nc-gui/lang/da.json b/packages/nc-gui/lang/da.json index 8f1c9c1647..5f6363bfa7 100644 --- a/packages/nc-gui/lang/da.json +++ b/packages/nc-gui/lang/da.json @@ -589,7 +589,7 @@ "untitledToken": "Untitled token", "tableName": "Tabelnavn.", "dashboardName": "Dashboard name", - "createView": "Create a View", + "createView": "Create View", "creatingView": "Creating View", "duplicateView": "Duplicate View", "duplicateGridView": "Duplicate Grid View", diff --git a/packages/nc-gui/lang/en.json b/packages/nc-gui/lang/en.json index 3708dc34f3..3f8f41530b 100644 --- a/packages/nc-gui/lang/en.json +++ b/packages/nc-gui/lang/en.json @@ -589,7 +589,7 @@ "untitledToken": "Untitled token", "tableName": "Table name", "dashboardName": "Dashboard name", - "createView": "Create a View", + "createView": "Create View", "creatingView": "Creating View", "duplicateView": "Duplicate View", "duplicateGridView": "Duplicate Grid View", @@ -919,7 +919,7 @@ "clearMetadata": "Clear Metadata", "exportToFile": "Export to file", "changePwd": "Change Password", - "createView": "Create a View", + "createView": "Create View", "shareView": "Share View", "findRowByCodeScan": "Find record by scan", "fillByCodeScan": "Fill by scan", diff --git a/packages/nc-gui/lang/eu.json b/packages/nc-gui/lang/eu.json index 4f103e53b6..864c286d1b 100644 --- a/packages/nc-gui/lang/eu.json +++ b/packages/nc-gui/lang/eu.json @@ -589,7 +589,7 @@ "untitledToken": "Untitled token", "tableName": "Taularen izena", "dashboardName": "Dashboard name", - "createView": "Create a View", + "createView": "Create View", "creatingView": "Creating View", "duplicateView": "Duplicate View", "duplicateGridView": "Duplicate Grid View", @@ -919,7 +919,7 @@ "clearMetadata": "Clear Metadata", "exportToFile": "Export to file", "changePwd": "Change Password", - "createView": "Create a View", + "createView": "Create View", "shareView": "Share View", "findRowByCodeScan": "Find row by scan", "fillByCodeScan": "Fill by scan", diff --git a/packages/nc-gui/lang/fa.json b/packages/nc-gui/lang/fa.json index 182b6cb614..f69a76b016 100644 --- a/packages/nc-gui/lang/fa.json +++ b/packages/nc-gui/lang/fa.json @@ -589,7 +589,7 @@ "untitledToken": "Untitled token", "tableName": "نام جدول", "dashboardName": "Dashboard name", - "createView": "Create a View", + "createView": "Create View", "creatingView": "Creating View", "duplicateView": "Duplicate View", "duplicateGridView": "Duplicate Grid View", diff --git a/packages/nc-gui/lang/fi.json b/packages/nc-gui/lang/fi.json index c2c1a55b8e..b2845e1123 100644 --- a/packages/nc-gui/lang/fi.json +++ b/packages/nc-gui/lang/fi.json @@ -589,7 +589,7 @@ "untitledToken": "Untitled token", "tableName": "Taulukon nimi", "dashboardName": "Dashboard name", - "createView": "Create a View", + "createView": "Create View", "creatingView": "Creating View", "duplicateView": "Duplicate View", "duplicateGridView": "Duplicate Grid View", diff --git a/packages/nc-gui/lang/he.json b/packages/nc-gui/lang/he.json index a3c50c8da0..3d254126e5 100644 --- a/packages/nc-gui/lang/he.json +++ b/packages/nc-gui/lang/he.json @@ -589,7 +589,7 @@ "untitledToken": "Untitled token", "tableName": "שם שולחן", "dashboardName": "Dashboard name", - "createView": "Create a View", + "createView": "Create View", "creatingView": "Creating View", "duplicateView": "Duplicate View", "duplicateGridView": "Duplicate Grid View", diff --git a/packages/nc-gui/lang/hi.json b/packages/nc-gui/lang/hi.json index 3b7f700844..3424f6f11e 100644 --- a/packages/nc-gui/lang/hi.json +++ b/packages/nc-gui/lang/hi.json @@ -589,7 +589,7 @@ "untitledToken": "Untitled token", "tableName": "Table name", "dashboardName": "Dashboard name", - "createView": "Create a View", + "createView": "Create View", "creatingView": "Creating View", "duplicateView": "Duplicate View", "duplicateGridView": "Duplicate Grid View", diff --git a/packages/nc-gui/lang/hr.json b/packages/nc-gui/lang/hr.json index a223496746..12f1e0bb4a 100644 --- a/packages/nc-gui/lang/hr.json +++ b/packages/nc-gui/lang/hr.json @@ -589,7 +589,7 @@ "untitledToken": "Untitled token", "tableName": "Tablica", "dashboardName": "Dashboard name", - "createView": "Create a View", + "createView": "Create View", "creatingView": "Creating View", "duplicateView": "Duplicate View", "duplicateGridView": "Duplicate Grid View", diff --git a/packages/nc-gui/lang/id.json b/packages/nc-gui/lang/id.json index 31321c4810..2b79fca3d6 100644 --- a/packages/nc-gui/lang/id.json +++ b/packages/nc-gui/lang/id.json @@ -589,7 +589,7 @@ "untitledToken": "Untitled token", "tableName": "Nama meja", "dashboardName": "Dashboard name", - "createView": "Create a View", + "createView": "Create View", "creatingView": "Creating View", "duplicateView": "Duplicate View", "duplicateGridView": "Duplicate Grid View", diff --git a/packages/nc-gui/lang/ja.json b/packages/nc-gui/lang/ja.json index 9d8459a887..aee36549c9 100644 --- a/packages/nc-gui/lang/ja.json +++ b/packages/nc-gui/lang/ja.json @@ -589,7 +589,7 @@ "untitledToken": "Untitled token", "tableName": "テーブルの名前", "dashboardName": "Dashboard name", - "createView": "Create a View", + "createView": "Create View", "creatingView": "Creating View", "duplicateView": "Duplicate View", "duplicateGridView": "Duplicate Grid View", diff --git a/packages/nc-gui/lang/lv.json b/packages/nc-gui/lang/lv.json index 599a96a98c..75c98ca488 100644 --- a/packages/nc-gui/lang/lv.json +++ b/packages/nc-gui/lang/lv.json @@ -589,7 +589,7 @@ "untitledToken": "Untitled token", "tableName": "Tabulas nosaukums", "dashboardName": "Dashboard name", - "createView": "Create a View", + "createView": "Create View", "creatingView": "Creating View", "duplicateView": "Duplicate View", "duplicateGridView": "Duplicate Grid View", diff --git a/packages/nc-gui/lang/nl.json b/packages/nc-gui/lang/nl.json index 02cf933737..a3373ec2f2 100644 --- a/packages/nc-gui/lang/nl.json +++ b/packages/nc-gui/lang/nl.json @@ -589,7 +589,7 @@ "untitledToken": "Untitled token", "tableName": "Tabelnaam", "dashboardName": "Dashboard name", - "createView": "Create a View", + "createView": "Create View", "creatingView": "Creating View", "duplicateView": "Duplicate View", "duplicateGridView": "Duplicate Grid View", diff --git a/packages/nc-gui/lang/no.json b/packages/nc-gui/lang/no.json index d9468f629a..ba83c50697 100644 --- a/packages/nc-gui/lang/no.json +++ b/packages/nc-gui/lang/no.json @@ -589,7 +589,7 @@ "untitledToken": "Untitled token", "tableName": "Tabellnavn", "dashboardName": "Dashboard name", - "createView": "Create a View", + "createView": "Create View", "creatingView": "Creating View", "duplicateView": "Duplicate View", "duplicateGridView": "Duplicate Grid View", diff --git a/packages/nc-gui/lang/pt_BR.json b/packages/nc-gui/lang/pt_BR.json index 51ea1815e2..17e1f88724 100644 --- a/packages/nc-gui/lang/pt_BR.json +++ b/packages/nc-gui/lang/pt_BR.json @@ -589,7 +589,7 @@ "untitledToken": "Untitled token", "tableName": "Nome da tabela", "dashboardName": "Dashboard name", - "createView": "Create a View", + "createView": "Create View", "creatingView": "Creating View", "duplicateView": "Duplicate View", "duplicateGridView": "Duplicate Grid View", diff --git a/packages/nc-gui/lang/ru.json b/packages/nc-gui/lang/ru.json index cc35a7b4bd..4c0d23963d 100644 --- a/packages/nc-gui/lang/ru.json +++ b/packages/nc-gui/lang/ru.json @@ -589,7 +589,7 @@ "untitledToken": "Untitled token", "tableName": "Название таблицы", "dashboardName": "Dashboard name", - "createView": "Create a View", + "createView": "Create View", "creatingView": "Creating View", "duplicateView": "Duplicate View", "duplicateGridView": "Duplicate Grid View", diff --git a/packages/nc-gui/lang/sk.json b/packages/nc-gui/lang/sk.json index 5a6232e04b..7801241975 100644 --- a/packages/nc-gui/lang/sk.json +++ b/packages/nc-gui/lang/sk.json @@ -589,7 +589,7 @@ "untitledToken": "Untitled token", "tableName": "Názov tabuľky", "dashboardName": "Dashboard name", - "createView": "Create a View", + "createView": "Create View", "creatingView": "Creating View", "duplicateView": "Duplicate View", "duplicateGridView": "Duplicate Grid View", diff --git a/packages/nc-gui/lang/sl.json b/packages/nc-gui/lang/sl.json index fd0485c14d..f905a72718 100644 --- a/packages/nc-gui/lang/sl.json +++ b/packages/nc-gui/lang/sl.json @@ -589,7 +589,7 @@ "untitledToken": "Untitled token", "tableName": "Ime tabele", "dashboardName": "Dashboard name", - "createView": "Create a View", + "createView": "Create View", "creatingView": "Creating View", "duplicateView": "Duplicate View", "duplicateGridView": "Duplicate Grid View", diff --git a/packages/nc-gui/lang/sv.json b/packages/nc-gui/lang/sv.json index 35fe8cbd54..f12f5f3545 100644 --- a/packages/nc-gui/lang/sv.json +++ b/packages/nc-gui/lang/sv.json @@ -589,7 +589,7 @@ "untitledToken": "Untitled token", "tableName": "Tabellnamn", "dashboardName": "Dashboard name", - "createView": "Create a View", + "createView": "Create View", "creatingView": "Creating View", "duplicateView": "Duplicate View", "duplicateGridView": "Duplicate Grid View", diff --git a/packages/nc-gui/lang/th.json b/packages/nc-gui/lang/th.json index e7fd6fb07d..e5321ee2ea 100644 --- a/packages/nc-gui/lang/th.json +++ b/packages/nc-gui/lang/th.json @@ -589,7 +589,7 @@ "untitledToken": "Untitled token", "tableName": "ชื่อตาราง", "dashboardName": "Dashboard name", - "createView": "Create a View", + "createView": "Create View", "creatingView": "Creating View", "duplicateView": "Duplicate View", "duplicateGridView": "Duplicate Grid View", diff --git a/packages/nc-gui/lang/uk.json b/packages/nc-gui/lang/uk.json index 5e1f384a9c..35a56b697c 100644 --- a/packages/nc-gui/lang/uk.json +++ b/packages/nc-gui/lang/uk.json @@ -589,7 +589,7 @@ "untitledToken": "Untitled token", "tableName": "Назва таблиці", "dashboardName": "Dashboard name", - "createView": "Create a View", + "createView": "Create View", "creatingView": "Creating View", "duplicateView": "Duplicate View", "duplicateGridView": "Duplicate Grid View", diff --git a/packages/nc-gui/lang/vi.json b/packages/nc-gui/lang/vi.json index 6d386ecaf0..fc93cccc58 100644 --- a/packages/nc-gui/lang/vi.json +++ b/packages/nc-gui/lang/vi.json @@ -589,7 +589,7 @@ "untitledToken": "Untitled token", "tableName": "Tên bảng.", "dashboardName": "Dashboard name", - "createView": "Create a View", + "createView": "Create View", "creatingView": "Creating View", "duplicateView": "Duplicate View", "duplicateGridView": "Duplicate Grid View", diff --git a/packages/nc-gui/lang/zh-Hant.json b/packages/nc-gui/lang/zh-Hant.json index 827fd9447c..45966d85e3 100644 --- a/packages/nc-gui/lang/zh-Hant.json +++ b/packages/nc-gui/lang/zh-Hant.json @@ -589,7 +589,7 @@ "untitledToken": "Untitled token", "tableName": "表名稱", "dashboardName": "Dashboard name", - "createView": "Create a View", + "createView": "Create View", "creatingView": "Creating View", "duplicateView": "Duplicate View", "duplicateGridView": "Duplicate Grid View", diff --git a/tests/playwright/pages/Dashboard/ViewSidebar/index.ts b/tests/playwright/pages/Dashboard/ViewSidebar/index.ts index fa6af9c9ee..1b4d918932 100644 --- a/tests/playwright/pages/Dashboard/ViewSidebar/index.ts +++ b/tests/playwright/pages/Dashboard/ViewSidebar/index.ts @@ -161,7 +161,7 @@ export class ViewSidebarPage extends BasePage { force: true, }); const submitAction = () => - this.rootPage.locator('.ant-modal-content').locator('button:has-text("Create view"):visible').click(); + this.rootPage.locator('.ant-modal-content').locator('button:has-text("Create View"):visible').click(); await this.waitForResponse({ httpMethodsToMatch: ['POST'], requestUrlPathToMatch: '/api/v1/db/meta/tables/',