From d74b9a46c1406aa0c197efbc4e22aefe15745ef4 Mon Sep 17 00:00:00 2001 From: mertmit Date: Sun, 8 Oct 2023 22:42:49 +0530 Subject: [PATCH] fix: s3 attachment path Signed-off-by: mertmit --- packages/nocodb/src/db/BaseModelSqlv2.ts | 5 +++-- packages/nocodb/src/services/attachments.service.ts | 4 +++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/packages/nocodb/src/db/BaseModelSqlv2.ts b/packages/nocodb/src/db/BaseModelSqlv2.ts index af6bfe9e48..035eae8c8c 100644 --- a/packages/nocodb/src/db/BaseModelSqlv2.ts +++ b/packages/nocodb/src/db/BaseModelSqlv2.ts @@ -4073,8 +4073,9 @@ class BaseModelSqlv2 { ); } else if (attachment?.url) { if (attachment.url.includes('.amazonaws.com/')) { - const relativePath = - attachment.url.split('.amazonaws.com/')[1]; + const relativePath = decodeURI( + attachment.url.split('.amazonaws.com/')[1], + ); promises.push( PresignedUrl.getSignedUrl({ path: relativePath, diff --git a/packages/nocodb/src/services/attachments.service.ts b/packages/nocodb/src/services/attachments.service.ts index 3f964dc521..873c86c103 100644 --- a/packages/nocodb/src/services/attachments.service.ts +++ b/packages/nocodb/src/services/attachments.service.ts @@ -67,7 +67,9 @@ export class AttachmentsService { ); } else { if (attachment.url.includes('.amazonaws.com/')) { - const relativePath = attachment.url.split('.amazonaws.com/')[1]; + const relativePath = decodeURI( + attachment.url.split('.amazonaws.com/')[1], + ); promises.push( PresignedUrl.getSignedUrl({ path: relativePath,