From d716cc0070efb93ad04807e4298ff580993d4edc Mon Sep 17 00:00:00 2001 From: Wing-Kam Wong Date: Mon, 13 Mar 2023 18:42:21 +0800 Subject: [PATCH] refactor(nocodb): revise response message --- packages/nocodb/src/lib/controllers/dbData/data.ctl.ts | 5 ++--- .../nocodb/src/lib/controllers/dbData/dataAliasNested.ctl.ts | 4 ++-- packages/nocodb/src/lib/controllers/modelVisibility.ctl.ts | 2 +- packages/nocodb/src/lib/controllers/orgUser.ctl.ts | 4 ++-- 4 files changed, 7 insertions(+), 8 deletions(-) diff --git a/packages/nocodb/src/lib/controllers/dbData/data.ctl.ts b/packages/nocodb/src/lib/controllers/dbData/data.ctl.ts index 882e6c7bec..d1eb3c6a1c 100644 --- a/packages/nocodb/src/lib/controllers/dbData/data.ctl.ts +++ b/packages/nocodb/src/lib/controllers/dbData/data.ctl.ts @@ -118,10 +118,9 @@ async function relationDataDelete(req, res) { cookie: req, }); - res.json({ msg: 'success' }); + res.json({ msg: 'The relation data has been deleted successfully' }); } -//@ts-ignore async function relationDataAdd(req, res) { await dataService.relationDataAdd({ viewId: req.params.viewId, @@ -131,7 +130,7 @@ async function relationDataAdd(req, res) { cookie: req, }); - res.json({ msg: 'success' }); + res.json({ msg: 'The relation data has been created successfully' }); } const router = Router({ mergeParams: true }); diff --git a/packages/nocodb/src/lib/controllers/dbData/dataAliasNested.ctl.ts b/packages/nocodb/src/lib/controllers/dbData/dataAliasNested.ctl.ts index 9b4660d31d..04cf3e38ee 100644 --- a/packages/nocodb/src/lib/controllers/dbData/dataAliasNested.ctl.ts +++ b/packages/nocodb/src/lib/controllers/dbData/dataAliasNested.ctl.ts @@ -77,7 +77,7 @@ async function relationDataRemove(req, res) { refRowId: req.params.refRowId, }); - res.json({ msg: 'success' }); + res.json({ msg: 'The relation data has been deleted successfully' }); } //@ts-ignore @@ -92,7 +92,7 @@ async function relationDataAdd(req, res) { refRowId: req.params.refRowId, }); - res.json({ msg: 'success' }); + res.json({ msg: 'The relation data has been created successfully' }); } const router = Router({ mergeParams: true }); diff --git a/packages/nocodb/src/lib/controllers/modelVisibility.ctl.ts b/packages/nocodb/src/lib/controllers/modelVisibility.ctl.ts index 6af9a71506..43b1b3440b 100644 --- a/packages/nocodb/src/lib/controllers/modelVisibility.ctl.ts +++ b/packages/nocodb/src/lib/controllers/modelVisibility.ctl.ts @@ -9,7 +9,7 @@ async function xcVisibilityMetaSetAll(req, res) { projectId: req.params.projectId, }); - res.json({ msg: 'success' }); + res.json({ msg: 'UI ACL has been created successfully' }); } const router = Router({ mergeParams: true }); diff --git a/packages/nocodb/src/lib/controllers/orgUser.ctl.ts b/packages/nocodb/src/lib/controllers/orgUser.ctl.ts index 5300007330..db4f229e32 100644 --- a/packages/nocodb/src/lib/controllers/orgUser.ctl.ts +++ b/packages/nocodb/src/lib/controllers/orgUser.ctl.ts @@ -33,7 +33,7 @@ async function userDelete(req, res) { await orgUserService.userDelete({ userId: req.params.userId, }); - res.json({ msg: 'success' }); + res.json({ msg: 'The user has been deleted successfully' }); } async function userAdd(req, res) { @@ -57,7 +57,7 @@ async function userInviteResend(req, res): Promise { req, }); - res.json({ msg: 'success' }); + res.json({ msg: 'The invitation has been sent to the user' }); } async function generateResetUrl(req, res) {