From 1b33ebecfba3e23182c7b275aeb6744f2deb2d0a Mon Sep 17 00:00:00 2001
From: Pranav C <pranavxc@gmail.com>
Date: Mon, 6 May 2024 06:39:19 +0000
Subject: [PATCH 1/8] feat: enable one-to-one relation

---
 .../smartsheet/column/LinkedToAnotherRecordOptions.vue      | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/packages/nc-gui/components/smartsheet/column/LinkedToAnotherRecordOptions.vue b/packages/nc-gui/components/smartsheet/column/LinkedToAnotherRecordOptions.vue
index 4afa80f212..be5c4ea679 100644
--- a/packages/nc-gui/components/smartsheet/column/LinkedToAnotherRecordOptions.vue
+++ b/packages/nc-gui/components/smartsheet/column/LinkedToAnotherRecordOptions.vue
@@ -53,8 +53,6 @@ const refTables = computed(() => {
 const filterOption = (value: string, option: { key: string }) => option.key.toLowerCase().includes(value.toLowerCase())
 
 const isLinks = computed(() => vModel.value.uidt === UITypes.Links && vModel.value.type !== RelationTypes.ONE_TO_ONE)
-
-const oneToOneEnabled = ref(false)
 </script>
 
 <template>
@@ -62,9 +60,9 @@ const oneToOneEnabled = ref(false)
     <div class="border-2 p-6">
       <a-form-item v-bind="validateInfos.type" class="nc-ltar-relation-type">
         <a-radio-group v-model:value="vModel.type" name="type" v-bind="validateInfos.type" class="!flex flex-col gap-2">
-          <a-radio value="hm" @dblclick="oneToOneEnabled = !oneToOneEnabled">{{ $t('title.hasMany') }}</a-radio>
+          <a-radio value="hm">{{ $t('title.hasMany') }}</a-radio>
           <a-radio value="mm">{{ $t('title.manyToMany') }}</a-radio>
-          <a-radio v-if="oneToOneEnabled" value="oo">{{ $t('title.oneToOne') }}</a-radio>
+          <a-radio value="oo">{{ $t('title.oneToOne') }}</a-radio>
         </a-radio-group>
       </a-form-item>
 

From ba47522286d0137538a6c47c042c600808f5faff Mon Sep 17 00:00:00 2001
From: Pranav C <pranavxc@gmail.com>
Date: Mon, 6 May 2024 06:39:19 +0000
Subject: [PATCH 2/8] fix: one-to-one column delete bug

---
 packages/nocodb/src/services/columns.service.ts | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/packages/nocodb/src/services/columns.service.ts b/packages/nocodb/src/services/columns.service.ts
index dbd49a8aa5..a471021c9b 100644
--- a/packages/nocodb/src/services/columns.service.ts
+++ b/packages/nocodb/src/services/columns.service.ts
@@ -5,6 +5,7 @@ import {
   isCreatedOrLastModifiedTimeCol,
   isLinksOrLTAR,
   isVirtualCol,
+  RelationTypes,
   substituteColumnAliasWithIdInFormula,
   substituteColumnIdWithAliasInFormula,
   UITypes,
@@ -18,7 +19,6 @@ import type {
   ColumnReqType,
   LinkToAnotherColumnReqType,
   LinkToAnotherRecordType,
-  RelationTypes,
   UserType,
 } from 'nocodb-sdk';
 import type CustomKnex from '~/db/CustomKnex';
@@ -2417,9 +2417,9 @@ export class ColumnsService {
       };
 
       await sqlMgr.sqlOpPlus(source, 'tableUpdate', tableUpdateBody);
+      // delete foreign key column
+      await Column.delete(childColumn.id, ncMeta);
     }
-    // delete foreign key column
-    await Column.delete(childColumn.id, ncMeta);
   };
 
   deleteOoRelation = async (
@@ -2492,7 +2492,7 @@ export class ColumnsService {
     const columnsInRelatedTable: Column[] = await relationColOpt
       .getRelatedTable(ncMeta)
       .then((m) => m.getColumns(ncMeta));
-    const relType = relationColOpt.type === 'bt' ? 'hm' : 'bt';
+    const relType = RelationTypes.ONE_TO_ONE;
     for (const c of columnsInRelatedTable) {
       if (c.uidt !== UITypes.LinkToAnotherRecord) continue;
       const colOpt = await c.getColOptions<LinkToAnotherRecordColumn>(ncMeta);
@@ -2562,9 +2562,10 @@ export class ColumnsService {
       };
 
       await sqlMgr.sqlOpPlus(source, 'tableUpdate', tableUpdateBody);
+
+      // delete foreign key column
+      await Column.delete(childColumn.id, ncMeta);
     }
-    // delete foreign key column
-    await Column.delete(childColumn.id, ncMeta);
   };
 
   async createLTARColumn(param: {

From 99e55162c906364d5cd3dd1be3fe32e106809c13 Mon Sep 17 00:00:00 2001
From: Raju Udava <86527202+dstala@users.noreply.github.com>
Date: Mon, 6 May 2024 06:39:20 +0000
Subject: [PATCH 3/8] fix: order of link types

---
 .../smartsheet/column/LinkedToAnotherRecordOptions.vue          | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/nc-gui/components/smartsheet/column/LinkedToAnotherRecordOptions.vue b/packages/nc-gui/components/smartsheet/column/LinkedToAnotherRecordOptions.vue
index be5c4ea679..fc33c23ccf 100644
--- a/packages/nc-gui/components/smartsheet/column/LinkedToAnotherRecordOptions.vue
+++ b/packages/nc-gui/components/smartsheet/column/LinkedToAnotherRecordOptions.vue
@@ -60,9 +60,9 @@ const isLinks = computed(() => vModel.value.uidt === UITypes.Links && vModel.val
     <div class="border-2 p-6">
       <a-form-item v-bind="validateInfos.type" class="nc-ltar-relation-type">
         <a-radio-group v-model:value="vModel.type" name="type" v-bind="validateInfos.type" class="!flex flex-col gap-2">
+          <a-radio value="oo">{{ $t('title.oneToOne') }}</a-radio>
           <a-radio value="hm">{{ $t('title.hasMany') }}</a-radio>
           <a-radio value="mm">{{ $t('title.manyToMany') }}</a-radio>
-          <a-radio value="oo">{{ $t('title.oneToOne') }}</a-radio>
         </a-radio-group>
       </a-form-item>
 

From 3195d88c8284bb7a78c84aa7ead63277c0d6ad7b Mon Sep 17 00:00:00 2001
From: Pranav C <pranavxc@gmail.com>
Date: Mon, 6 May 2024 06:39:20 +0000
Subject: [PATCH 4/8] fix: one-to-one relation in nested add new row option

---
 packages/nc-gui/components/virtual-cell/OneToOne.vue     | 4 +++-
 .../components/virtual-cell/components/UnLinkedItems.vue | 2 +-
 packages/nocodb/src/db/BaseModelSqlv2.ts                 | 9 +++++----
 3 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/packages/nc-gui/components/virtual-cell/OneToOne.vue b/packages/nc-gui/components/virtual-cell/OneToOne.vue
index 9f3188a2aa..5a24791cd9 100644
--- a/packages/nc-gui/components/virtual-cell/OneToOne.vue
+++ b/packages/nc-gui/components/virtual-cell/OneToOne.vue
@@ -55,7 +55,9 @@ const value = computed(() => {
   if (cellValue?.value) {
     return cellValue?.value
   } else if (isNew.value) {
-    return state?.value?.[column?.value.title as string]
+    return Array.isArray(state?.value?.[column?.value.title as string])
+      ? state?.value?.[column?.value.title as string][0]
+      : state?.value?.[column?.value.title as string]
   }
   return null
 })
diff --git a/packages/nc-gui/components/virtual-cell/components/UnLinkedItems.vue b/packages/nc-gui/components/virtual-cell/components/UnLinkedItems.vue
index c93597ff24..0b04b65f1b 100644
--- a/packages/nc-gui/components/virtual-cell/components/UnLinkedItems.vue
+++ b/packages/nc-gui/components/virtual-cell/components/UnLinkedItems.vue
@@ -142,7 +142,7 @@ const newRowState = computed(() => {
   const relatedTableColOpt = colInRelatedTable?.colOptions as LinkToAnotherRecordType
   if (!relatedTableColOpt) return {}
 
-  if (relatedTableColOpt.type === RelationTypes.BELONGS_TO) {
+  if (relatedTableColOpt.type === RelationTypes.BELONGS_TO || relatedTableColOpt.type === RelationTypes.ONE_TO_ONE) {
     return {
       [colInRelatedTable.title as string]: row?.value?.row,
     }
diff --git a/packages/nocodb/src/db/BaseModelSqlv2.ts b/packages/nocodb/src/db/BaseModelSqlv2.ts
index 27e321661c..2babe1eab5 100644
--- a/packages/nocodb/src/db/BaseModelSqlv2.ts
+++ b/packages/nocodb/src/db/BaseModelSqlv2.ts
@@ -3314,16 +3314,17 @@ class BaseModelSqlv2 {
               await childModel.getColumns();
 
               if (isBt) {
+                // if array then extract value from first element
+                const colVal = Array.isArray(nestedData)
+                  ? nestedData[0]?.[childModel.primaryKey.title]
+                  : nestedData[childModel.primaryKey.title];
                 // todo: unlink the ref record
                 preInsertOps.push(async () => {
                   return this.dbDriver(this.getTnPath(childModel.table_name))
                     .update({
                       [childCol.column_name]: null,
                     })
-                    .where(
-                      childCol.column_name,
-                      nestedData[childModel.primaryKey.title],
-                    )
+                    .where(childCol.column_name, colVal)
                     .toQuery();
                 });
 

From 413b91a192bc1646dab5886c9c36d5c3b16edac7 Mon Sep 17 00:00:00 2001
From: Pranav C <pranavxc@gmail.com>
Date: Mon, 6 May 2024 06:39:20 +0000
Subject: [PATCH 5/8] test: correction

---
 tests/playwright/pages/Dashboard/Details/FieldsPage.ts | 2 +-
 tests/playwright/pages/Dashboard/Grid/Column/index.ts  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/playwright/pages/Dashboard/Details/FieldsPage.ts b/tests/playwright/pages/Dashboard/Details/FieldsPage.ts
index 7bb3163f33..0f3946afcb 100644
--- a/tests/playwright/pages/Dashboard/Details/FieldsPage.ts
+++ b/tests/playwright/pages/Dashboard/Details/FieldsPage.ts
@@ -186,7 +186,7 @@ export class FieldsPage extends BasePage {
       case 'Links':
         await this.addOrEditColumn
           .locator('.nc-ltar-relation-type >> .ant-radio')
-          .nth(relationType === 'Has Many' ? 0 : 1)
+          .nth(relationType === 'Has Many' ? 1 : 2)
           .click();
         await this.addOrEditColumn.locator('.ant-select-single').nth(1).click();
         await this.rootPage.locator(`.nc-ltar-child-table >> input[type="search"]`).fill(childTable);
diff --git a/tests/playwright/pages/Dashboard/Grid/Column/index.ts b/tests/playwright/pages/Dashboard/Grid/Column/index.ts
index da7fe10b91..e49b360a80 100644
--- a/tests/playwright/pages/Dashboard/Grid/Column/index.ts
+++ b/tests/playwright/pages/Dashboard/Grid/Column/index.ts
@@ -173,7 +173,7 @@ export class ColumnPageObject extends BasePage {
       case 'Links':
         await this.get()
           .locator('.nc-ltar-relation-type >> .ant-radio')
-          .nth(relationType === 'Has Many' ? 0 : 1)
+          .nth(relationType === 'Has Many' ? 1 : 2)
           .click();
         await this.get().locator('.ant-select-single').nth(1).click();
         await this.rootPage.locator(`.nc-ltar-child-table >> input[type="search"]`).fill(childTable);

From 3792a9a0b6872127d7ee96cff0949399df9d3d51 Mon Sep 17 00:00:00 2001
From: Pranav C <pranavxc@gmail.com>
Date: Mon, 6 May 2024 06:39:21 +0000
Subject: [PATCH 6/8] fix: always show tooltip for links, formula,rollup and
 lookup

---
 .../components/smartsheet/header/VirtualCell.vue | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/packages/nc-gui/components/smartsheet/header/VirtualCell.vue b/packages/nc-gui/components/smartsheet/header/VirtualCell.vue
index 9c38fa490b..3e6171d8b7 100644
--- a/packages/nc-gui/components/smartsheet/header/VirtualCell.vue
+++ b/packages/nc-gui/components/smartsheet/header/VirtualCell.vue
@@ -1,5 +1,13 @@
 <script setup lang="ts">
-import type { ColumnReqType, ColumnType, FormulaType, LinkToAnotherRecordType, LookupType, RollupType } from 'nocodb-sdk'
+import {
+  type ColumnReqType,
+  type ColumnType,
+  type FormulaType,
+  isLinksOrLTAR,
+  type LinkToAnotherRecordType,
+  type LookupType,
+  type RollupType
+} from 'nocodb-sdk'
 import { RelationTypes, UITypes, UITypesName, substituteColumnIdWithAliasInFormula } from 'nocodb-sdk'
 import {
   ColumnInj,
@@ -116,6 +124,10 @@ const tooltipMsg = computed(() => {
   return column?.value?.title || ''
 })
 
+const showTooltipAlways = computed(() => {
+  return isLinksOrLTAR(column.value) || isFormula(column.value) || isRollup(column.value) || isLookup(column.value)
+})
+
 const columnOrder = ref<Pick<ColumnReqType, 'column_order'> | null>(null)
 
 const columnTypeName = computed(() => {
@@ -172,7 +184,7 @@ const openDropDown = (e: Event) => {
       </NcTooltip>
       <LazySmartsheetHeaderVirtualCellIcon v-else />
     </template>
-    <NcTooltip placement="bottom" class="truncate name pl-1" show-on-truncate-only>
+    <NcTooltip placement="bottom" class="truncate name pl-1" :show-on-truncate-only="!showTooltipAlways">
       <template #title>
         {{ tooltipMsg }}
       </template>

From b72ee443790cc15da48ea3e78d6ec3a88c71e282 Mon Sep 17 00:00:00 2001
From: Pranav C <pranavxc@gmail.com>
Date: Mon, 6 May 2024 06:39:21 +0000
Subject: [PATCH 7/8] fix: add missing tooltip for one to one

---
 .../nc-gui/components/smartsheet/header/VirtualCell.vue  | 9 ++++++---
 packages/nc-gui/lang/en.json                             | 1 +
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/packages/nc-gui/components/smartsheet/header/VirtualCell.vue b/packages/nc-gui/components/smartsheet/header/VirtualCell.vue
index 3e6171d8b7..e01a84b878 100644
--- a/packages/nc-gui/components/smartsheet/header/VirtualCell.vue
+++ b/packages/nc-gui/components/smartsheet/header/VirtualCell.vue
@@ -3,10 +3,10 @@ import {
   type ColumnReqType,
   type ColumnType,
   type FormulaType,
-  isLinksOrLTAR,
   type LinkToAnotherRecordType,
   type LookupType,
-  type RollupType
+  type RollupType,
+  isLinksOrLTAR,
 } from 'nocodb-sdk'
 import { RelationTypes, UITypes, UITypesName, substituteColumnIdWithAliasInFormula } from 'nocodb-sdk'
 import {
@@ -20,6 +20,7 @@ import {
   isHm,
   isLookup,
   isMm,
+  isOo,
   isRollup,
   isVirtualColRequired,
   provide,
@@ -65,7 +66,7 @@ const colOptions = computed(() => column.value?.colOptions)
 const tableTile = computed(() => meta?.value?.title)
 
 const relationColumnOptions = computed<LinkToAnotherRecordType | null>(() => {
-  if (isMm(column.value) || isHm(column.value) || isBt(column.value)) {
+  if (isLinksOrLTAR(column.value)) {
     return column.value?.colOptions as LinkToAnotherRecordType
   } else if ((column?.value?.colOptions as LookupType | RollupType)?.fk_relation_column_id) {
     return meta?.value?.columns?.find(
@@ -109,6 +110,8 @@ const tooltipMsg = computed(() => {
     return `'${tableTile.value}' & '${relatedTableTitle.value}' ${t('labels.manyToMany')}`
   } else if (isBt(column.value)) {
     return `'${column?.value?.title}' ${t('labels.belongsTo')} '${relatedTableTitle.value}'`
+  } else if (isOo(column.value)) {
+    return `'${tableTile.value}' & '${relatedTableTitle.value}' ${t('labels.oneToOne')}`
   } else if (isLookup(column.value)) {
     return `'${childColumn.value.title}' from '${relatedTableTitle.value}' (${childColumn.value.uidt})`
   } else if (isFormula(column.value)) {
diff --git a/packages/nc-gui/lang/en.json b/packages/nc-gui/lang/en.json
index 790bca109b..0fa54be92c 100644
--- a/packages/nc-gui/lang/en.json
+++ b/packages/nc-gui/lang/en.json
@@ -714,6 +714,7 @@
     "hasMany": "has many",
     "belongsTo": "belongs to",
     "manyToMany": "have many to many relation",
+    "oneToOne": "have one to one relation",
     "extraConnectionParameters": "Extra connection parameters",
     "commentsOnly": "Comments only",
     "documentation": "Documentation",

From 03c1e429aaaa4e0b2ae99129555a480f2254abbc Mon Sep 17 00:00:00 2001
From: Pranav C <pranavxc@gmail.com>
Date: Mon, 6 May 2024 06:39:21 +0000
Subject: [PATCH 8/8] refactor: use variables to improve readability

---
 packages/nc-gui/components/virtual-cell/OneToOne.vue | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/packages/nc-gui/components/virtual-cell/OneToOne.vue b/packages/nc-gui/components/virtual-cell/OneToOne.vue
index 5a24791cd9..269c00f71a 100644
--- a/packages/nc-gui/components/virtual-cell/OneToOne.vue
+++ b/packages/nc-gui/components/virtual-cell/OneToOne.vue
@@ -55,9 +55,9 @@ const value = computed(() => {
   if (cellValue?.value) {
     return cellValue?.value
   } else if (isNew.value) {
-    return Array.isArray(state?.value?.[column?.value.title as string])
-      ? state?.value?.[column?.value.title as string][0]
-      : state?.value?.[column?.value.title as string]
+    const columnTitle = column?.value.title as string
+    const columnValue = state?.value?.[columnTitle]
+    return Array.isArray(columnValue) ? columnValue[0] : columnValue
   }
   return null
 })