From d4cb044efef556f3186b75dd25093b4de614615b Mon Sep 17 00:00:00 2001 From: Muhammed Mustafa Date: Wed, 30 Nov 2022 14:50:09 +0530 Subject: [PATCH] fix(playwright): NC_ATTACHMENT_FIELD_SIZE defaulting logic improved and added in docs --- .../noco-docs/content/en/getting-started/installation.md | 1 + packages/nocodb/src/lib/constants/index.ts | 5 ++--- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/noco-docs/content/en/getting-started/installation.md b/packages/noco-docs/content/en/getting-started/installation.md index 2f341aee2a..f019870064 100644 --- a/packages/noco-docs/content/en/getting-started/installation.md +++ b/packages/noco-docs/content/en/getting-started/installation.md @@ -509,6 +509,7 @@ It is mandatory to configure `NC_DB` environment variables for production usecas | NC_S3_ACCESS_KEY | No | For S3 storage plugin - AWS access key credential for accessing resource | | | | NC_S3_ACCESS_SECRET | No | For S3 storage plugin - AWS access secret credential for accessing resource | | | | NC_ADMIN_EMAIL | No | For updating/creating super admin with provided email and password | | | +| NC_ATTACHMENT_FIELD_SIZE | No | For setting the attachment field size(in Bytes) | Defaults to 20MB | | | NC_ADMIN_PASSWORD | No | For updating/creating super admin with provided email and password. Your password should have at least 8 letters with one uppercase, one number and one special letter(Allowed special chars $&+,:;=?@#|'.^*()%!_-" ) | | | | NODE_OPTIONS | No | For passing Node.js [options](https://nodejs.org/api/cli.html#node_optionsoptions) to instance | | | | NC_MINIMAL_DBS | No | Create a new SQLite file for each project. All the db files are stored in `nc_minimal_dbs` folder in current working directory. (This option restricts project creation on external sources) | | | diff --git a/packages/nocodb/src/lib/constants/index.ts b/packages/nocodb/src/lib/constants/index.ts index ed009d8237..c2fdcb32cf 100644 --- a/packages/nocodb/src/lib/constants/index.ts +++ b/packages/nocodb/src/lib/constants/index.ts @@ -1,5 +1,4 @@ export const NC_LICENSE_KEY = 'nc-license-key'; export const NC_APP_SETTINGS = 'nc-app-settings'; -export const NC_ATTACHMENT_FIELD_SIZE = process.env['NC_ATTACHMENT_FIELD_SIZE'] - ? Number(process.env['NC_ATTACHMENT_FIELD_SIZE']) - : 20 * 1024 * 1024; // 20 MB +export const NC_ATTACHMENT_FIELD_SIZE = + +process.env['NC_ATTACHMENT_FIELD_SIZE'] || 20 * 1024 * 1024; // 20 MB