From d003b39e0091912d9bf6e07406bf1e6c965397e9 Mon Sep 17 00:00:00 2001
From: Wing-Kam Wong <wingkwong.code@gmail.com>
Date: Sat, 13 Aug 2022 16:36:02 +0800
Subject: [PATCH] fix(gui-v2): add editEnabled for select cells

---
 packages/nc-gui-v2/components/cell/MultiSelect.vue  | 6 +++---
 packages/nc-gui-v2/components/cell/SingleSelect.vue | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/packages/nc-gui-v2/components/cell/MultiSelect.vue b/packages/nc-gui-v2/components/cell/MultiSelect.vue
index 28d81ec758..1f8bd8118b 100644
--- a/packages/nc-gui-v2/components/cell/MultiSelect.vue
+++ b/packages/nc-gui-v2/components/cell/MultiSelect.vue
@@ -1,7 +1,7 @@
 <script lang="ts" setup>
 import type { Select as AntSelect } from 'ant-design-vue'
 import type { SelectOptionType } from 'nocodb-sdk'
-import { ActiveCellInj, ColumnInj, computed, inject } from '#imports'
+import { ActiveCellInj, ColumnInj, ReadonlyInj, computed, inject } from '#imports'
 import MdiCloseCircle from '~icons/mdi/close-circle'
 
 interface Props {
@@ -18,8 +18,7 @@ const column = inject(ColumnInj)
 
 // const isForm = inject<boolean>('isForm', false)
 
-// FIXME: use editEnabled to control the UI permission
-// const editEnabled = inject(ReadonlyInj)
+const editEnabled = inject(ReadonlyInj)
 
 const active = inject(ActiveCellInj, ref(false))
 
@@ -117,6 +116,7 @@ watch(isOpen, (n, _o) => {
     show-arrow
     :show-search="false"
     :open="isOpen"
+    :disabled="!editEnabled"
     @keydown="handleKeys"
     @click="isOpen = !isOpen"
   >
diff --git a/packages/nc-gui-v2/components/cell/SingleSelect.vue b/packages/nc-gui-v2/components/cell/SingleSelect.vue
index 1ca67fb876..7e2f613956 100644
--- a/packages/nc-gui-v2/components/cell/SingleSelect.vue
+++ b/packages/nc-gui-v2/components/cell/SingleSelect.vue
@@ -1,7 +1,7 @@
 <script lang="ts" setup>
 import type { Select as AntSelect } from 'ant-design-vue'
 import type { SelectOptionType } from 'nocodb-sdk'
-import { ActiveCellInj, ColumnInj, computed, inject } from '#imports'
+import { ActiveCellInj, ColumnInj, ReadonlyInj, computed, inject } from '#imports'
 
 interface Props {
   modelValue: string | undefined
@@ -15,8 +15,7 @@ const column = inject(ColumnInj)
 
 // const isForm = inject<boolean>('isForm', false)
 
-// FIXME: use editEnabled to control the UI permission
-// const editEnabled = inject(ReadonlyInj)
+const editEnabled = inject(ReadonlyInj)
 
 const active = inject(ActiveCellInj, ref(false))
 
@@ -76,6 +75,7 @@ watch(isOpen, (n, _o) => {
     placeholder="Select an option"
     :bordered="false"
     :open="isOpen"
+    :disabled="!editEnabled"
     @select="isOpen = false"
     @keydown="handleKeys"
     @click="isOpen = !isOpen"