From ce93117f890ceb2348ffd7da2f8b1fe3645fbb49 Mon Sep 17 00:00:00 2001
From: mertmit <mertmit99@gmail.com>
Date: Tue, 26 Jul 2022 20:44:28 +0300
Subject: [PATCH] feat(gui-v2): improved UI ACL table role handling

Signed-off-by: mertmit <mertmit99@gmail.com>
---
 .../components/dashboard/settings/UIAcl.vue   | 53 ++++++-------------
 1 file changed, 15 insertions(+), 38 deletions(-)

diff --git a/packages/nc-gui-v2/components/dashboard/settings/UIAcl.vue b/packages/nc-gui-v2/components/dashboard/settings/UIAcl.vue
index b361ded48f..c50ff05a51 100644
--- a/packages/nc-gui-v2/components/dashboard/settings/UIAcl.vue
+++ b/packages/nc-gui-v2/components/dashboard/settings/UIAcl.vue
@@ -10,6 +10,7 @@ const { $api, $e } = useNuxtApp()
 const { project } = useProject()
 const toast = useToast()
 
+const roles = $ref<Array<string>>(['editor', 'commenter', 'viewer'])
 let isLoading = $ref(false)
 let tables = $ref<Array<any>>([])
 let searchInput = $ref<string>('')
@@ -123,44 +124,20 @@ const columns = [
               {{ record.title }}
             </div>
           </div>
-          <div v-if="column.name === 'editor'">
-            <a-tooltip>
-              <template #title>Click to hide '{{ record.title }}' for role:Editor in UI dashboard</template>
-              <a-checkbox
-                :checked="!record.disabled.editor"
-                @change="
-                  // eslint-disable-next-line prettier/prettier
-                  record.disabled.editor = !record.disabled.editor;
-                  record.edited = true
-                "
-              ></a-checkbox>
-            </a-tooltip>
-          </div>
-          <div v-if="column.name === 'commenter'">
-            <a-tooltip>
-              <template #title>Click to hide '{{ record.title }}' for role:Commenter in UI dashboard</template>
-              <a-checkbox
-                :checked="!record.disabled.commenter"
-                @change="
-                  // eslint-disable-next-line prettier/prettier
-                  record.disabled.commenter = !record.disabled.commenter;
-                  record.edited = true
-                "
-              ></a-checkbox>
-            </a-tooltip>
-          </div>
-          <div v-if="column.name === 'viewer'">
-            <a-tooltip>
-              <template #title>Click to hide '{{ record.title }}' for role:Viewer in UI dashboard</template>
-              <a-checkbox
-                :checked="!record.disabled.viewer"
-                @change="
-                  // eslint-disable-next-line prettier/prettier
-                  record.disabled.viewer = !record.disabled.viewer;
-                  record.edited = true
-                "
-              ></a-checkbox>
-            </a-tooltip>
+          <div v-for="role in roles" :key="role">
+            <div v-if="column.name === role">
+              <a-tooltip>
+                <template #title>Click to hide '{{ record.title }}' for role:{{ role }} in UI dashboard</template>
+                <a-checkbox
+                  :checked="!record.disabled[role]"
+                  @change="
+                    // eslint-disable-next-line prettier/prettier
+                    record.disabled[role] = !record.disabled[role];
+                    record.edited = true
+                  "
+                ></a-checkbox>
+              </a-tooltip>
+            </div>
           </div>
         </template>
       </a-table>