From cd064619519d157dee61f87c6da38c2bc24cb9fd Mon Sep 17 00:00:00 2001
From: Pranav C <pranavxc@gmail.com>
Date: Thu, 4 Jan 2024 13:19:25 +0000
Subject: [PATCH] fix: Upgrader - remove trigger(pg) and remove default value

---
 .../ncXcdbCreatedAndUpdatedTimeUpgrader.ts    | 39 +++++++++++++++++--
 1 file changed, 35 insertions(+), 4 deletions(-)

diff --git a/packages/nocodb/src/version-upgrader/ncXcdbCreatedAndUpdatedTimeUpgrader.ts b/packages/nocodb/src/version-upgrader/ncXcdbCreatedAndUpdatedTimeUpgrader.ts
index 490e4160b8..6c5f564df6 100644
--- a/packages/nocodb/src/version-upgrader/ncXcdbCreatedAndUpdatedTimeUpgrader.ts
+++ b/packages/nocodb/src/version-upgrader/ncXcdbCreatedAndUpdatedTimeUpgrader.ts
@@ -17,6 +17,26 @@ import { Altered } from '~/services/columns.service';
 
 const logger = new Logger('ncXcdbCreatedAndUpdatedTimeUpgrader');
 
+async function deletePgTrigger({
+  column,
+  ncMeta,
+  model,
+}: {
+  ncMeta: MetaService;
+  column: Column;
+  model: Model;
+}) {
+  // delete pg trigger
+  const triggerFnName = `xc_au_${model.table_name}_${column.column_name}`;
+  const triggerName = `xc_trigger_${model.table_name}_${column.column_name}`;
+
+  await ncMeta.knex.raw(`DROP TRIGGER IF EXISTS ?? ON ??;`, [
+    triggerName,
+    model.table_name,
+  ]);
+  await ncMeta.knex.raw(`DROP FUNCTION IF EXISTS ??()`, [triggerFnName]);
+}
+
 async function upgradeModels({
   ncMeta,
   source,
@@ -35,6 +55,7 @@ async function upgradeModels({
   await Promise.all(
     models.map(async (model: any) => {
       const columns = await model.getColumns(ncMeta);
+      const oldColumns = columns.map((c) => ({ ...c, cn: c.column_name }));
       let isCreatedTimeExists = false;
       let isLastModifiedTimeExists = false;
       for (const column of columns) {
@@ -49,14 +70,27 @@ async function upgradeModels({
             },
             ncMeta,
           );
+
+          if (source.type === 'pg') {
+            // delete pg trigger if exists
+            await deletePgTrigger({ column, ncMeta, model });
+          }
         }
         if (column.uidt === 'updated_at') {
           isLastModifiedTimeExists = true;
+          Object.assign(column, {
+            uidt: UITypes.LastModifiedTime,
+            system: true,
+            cdf: '',
+            au: false,
+          });
           await Column.update(
             column.id,
             {
               uidt: UITypes.LastModifiedTime,
               system: true,
+              cdf: '',
+              au: false,
             },
             ncMeta,
           );
@@ -103,10 +137,7 @@ async function upgradeModels({
         const tableUpdateBody = {
           ...model,
           tn: model.table_name,
-          originalColumns: model.columns.map((c) => ({
-            ...c,
-            cn: c.column_name,
-          })),
+          originalColumns: oldColumns,
           columns: [
             ...columns.map((c) => ({ ...c, cn: c.column_name })),
             ...newColumns,