From ccf17249d40a82ec33a0f9f2609a49d75e85ce08 Mon Sep 17 00:00:00 2001 From: Wing-Kam Wong Date: Fri, 16 Jun 2023 12:56:48 +0800 Subject: [PATCH] fix(playwright): remove unnecessary async n await --- tests/playwright/pages/Account/AppStore.ts | 4 ++-- tests/playwright/pages/Account/License.ts | 2 +- tests/playwright/pages/Account/Settings.ts | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/playwright/pages/Account/AppStore.ts b/tests/playwright/pages/Account/AppStore.ts index d95378be4f..0941de0377 100644 --- a/tests/playwright/pages/Account/AppStore.ts +++ b/tests/playwright/pages/Account/AppStore.ts @@ -10,8 +10,8 @@ export class AccountAppStorePage extends BasePage { this.accountPage = accountPage; } - async goto() { - await this.waitForResponse({ + goto() { + return this.waitForResponse({ uiAction: async () => await this.rootPage.goto('/#/account/apps'), httpMethodsToMatch: ['GET'], requestUrlPathToMatch: 'api/v1/db/meta/plugins', diff --git a/tests/playwright/pages/Account/License.ts b/tests/playwright/pages/Account/License.ts index 03cf8f1e11..11874ceaa9 100644 --- a/tests/playwright/pages/Account/License.ts +++ b/tests/playwright/pages/Account/License.ts @@ -13,7 +13,7 @@ export class AccountLicensePage extends BasePage { return this.rootPage.goto('/#/account/license'); } - async waitUntilContentLoads() { + waitUntilContentLoads() { return this.rootPage.waitForResponse(resp => resp.url().includes('api/v1/license') && resp.status() === 200); } diff --git a/tests/playwright/pages/Account/Settings.ts b/tests/playwright/pages/Account/Settings.ts index 0bf7e1589c..cd3b0c5dad 100644 --- a/tests/playwright/pages/Account/Settings.ts +++ b/tests/playwright/pages/Account/Settings.ts @@ -10,8 +10,8 @@ export class AccountSettingsPage extends BasePage { this.accountPage = accountPage; } - async goto() { - await this.waitForResponse({ + goto() { + return this.waitForResponse({ uiAction: async () => await this.rootPage.goto('/#/account/users/settings'), httpMethodsToMatch: ['GET'], requestUrlPathToMatch: `api/v1/app-settings`,