Browse Source

refactor: suggested changes

Signed-off-by: Pranav C <pranavxc@gmail.com>
pull/6445/head
Pranav C 1 year ago
parent
commit
cceae26f79
  1. 1
      packages/nocodb/src/db/BaseModelSqlv2.ts
  2. 2
      tests/playwright/tests/utils/general.ts

1
packages/nocodb/src/db/BaseModelSqlv2.ts

@ -1600,7 +1600,6 @@ class BaseModelSqlv2 {
}); });
const self: BaseModelSqlv2 = this; const self: BaseModelSqlv2 = this;
// const childColumn = await colOptions.getChildColumn();
proto[ proto[
column.uidt === UITypes.Links column.uidt === UITypes.Links
? `_nc_lk_${column.title}` ? `_nc_lk_${column.title}`

2
tests/playwright/tests/utils/general.ts

@ -37,6 +37,8 @@ function isSubset(obj, potentialSubset) {
if (!isSubset(objValue, potentialValue)) { if (!isSubset(objValue, potentialValue)) {
return false; return false;
} }
// skip strict type check since different database returns number values in string/number type
// todo: revert back to strict type check once we are consistent with type
// eslint-disable-next-line no-prototype-builtins // eslint-disable-next-line no-prototype-builtins
} else if (!obj.hasOwnProperty(prop) || objValue != potentialValue) { } else if (!obj.hasOwnProperty(prop) || objValue != potentialValue) {
return false; return false;

Loading…
Cancel
Save