From c880e9012d8db5ba0f34fa01112862f4a3047d8a Mon Sep 17 00:00:00 2001
From: Pranav C <pranavxc@gmail.com>
Date: Tue, 12 Apr 2022 17:19:00 +0530
Subject: [PATCH] fix: csv download with filter , sort and fields option

re #1660

Signed-off-by: Pranav C <pranavxc@gmail.com>
---
 .../spreadsheet/components/moreActions.vue    | 11 ++++++-
 .../project/spreadsheet/public/xcTable.vue    |  2 +-
 .../lib/dataMapper/lib/sql/BaseModelSqlv2.ts  |  2 +-
 .../api/publicApis/publicDataExportApis.ts    | 30 +++++++++++++------
 4 files changed, 33 insertions(+), 12 deletions(-)

diff --git a/packages/nc-gui/components/project/spreadsheet/components/moreActions.vue b/packages/nc-gui/components/project/spreadsheet/components/moreActions.vue
index fe5ad1faff..630f94eb7c 100644
--- a/packages/nc-gui/components/project/spreadsheet/components/moreActions.vue
+++ b/packages/nc-gui/components/project/spreadsheet/components/moreActions.vue
@@ -240,7 +240,16 @@ export default {
             res = await this.$api.public.csvExport(this.publicViewId, ExportTypes.CSV, {
               responseType: 'blob',
               query: {
-                offset
+                fields: this.queryParams && this.queryParams.fieldsOrder && this.queryParams.fieldsOrder.filter(c => this.queryParams.showFields[c]),
+                offset,
+                sortArrJson: JSON.stringify(this.reqPayload && this.reqPayload.sorts && this.reqPayload.sorts.map(({
+                  fk_column_id,
+                  direction
+                }) => ({
+                  direction,
+                  fk_column_id
+                }))),
+                filterArrJson: JSON.stringify(this.reqPayload && this.reqPayload.filters)
               },
               headers: {
                 'xc-password': this.reqPayload && this.reqPayload.password
diff --git a/packages/nc-gui/components/project/spreadsheet/public/xcTable.vue b/packages/nc-gui/components/project/spreadsheet/public/xcTable.vue
index b7a5020302..fdbdd2ed5b 100644
--- a/packages/nc-gui/components/project/spreadsheet/public/xcTable.vue
+++ b/packages/nc-gui/components/project/spreadsheet/public/xcTable.vue
@@ -49,7 +49,7 @@
 
           <csv-export-import
             :is-view="isView"
-            :query-params="{...queryParams, showFields}"
+            :query-params="{...queryParams, showFields, fieldsOrder}"
             :public-view-id="$route.params.id"
             :meta="meta"
             :req-payload="{filters, sorts, password}"
diff --git a/packages/nocodb/src/lib/dataMapper/lib/sql/BaseModelSqlv2.ts b/packages/nocodb/src/lib/dataMapper/lib/sql/BaseModelSqlv2.ts
index 68e70dafa9..fe5d8d34c6 100644
--- a/packages/nocodb/src/lib/dataMapper/lib/sql/BaseModelSqlv2.ts
+++ b/packages/nocodb/src/lib/dataMapper/lib/sql/BaseModelSqlv2.ts
@@ -290,7 +290,7 @@ class BaseModelSqlv2 {
               allowedCols && (!includePkByDefault || !col.pk)
                 ? allowedCols[col.id] &&
                   (!isSystemColumn(col) || view.show_system_fields) &&
-                  (!fields?.length || fields.include(col.title))
+                  (!fields?.length || fields.includes(col.title))
                 : 1
           }),
           {}
diff --git a/packages/nocodb/src/lib/noco/meta/api/publicApis/publicDataExportApis.ts b/packages/nocodb/src/lib/noco/meta/api/publicApis/publicDataExportApis.ts
index 4ffce25ba8..c39fb20343 100644
--- a/packages/nocodb/src/lib/noco/meta/api/publicApis/publicDataExportApis.ts
+++ b/packages/nocodb/src/lib/noco/meta/api/publicApis/publicDataExportApis.ts
@@ -34,6 +34,15 @@ async function exportCsv(req: Request, res: Response) {
 
   if (!model) NcError.notFound('Table not found');
 
+  const fields = req.query.fields;
+  const listArgs: any = { ...req.query };
+  try {
+    listArgs.filterArr = JSON.parse(listArgs.filterArrJson);
+  } catch (e) {}
+  try {
+    listArgs.sortArr = JSON.parse(listArgs.sortArrJson);
+  } catch (e) {}
+
   const base = await Base.get(model.base_id);
   const baseModel = await Model.getBaseModelSQL({
     id: model.id,
@@ -61,7 +70,6 @@ async function exportCsv(req: Request, res: Response) {
       temp = process.hrtime(startTime),
       elapsed = temp[0] * 1000 + temp[1] / 1000000
   ) {
-    console.time('nocoExecute');
     const rows = (
       await nocoExecute(
         requestObj,
@@ -71,14 +79,9 @@ async function exportCsv(req: Request, res: Response) {
           }
         },
         {},
-
         {
           nested: {
-            [key]: {
-              ...req.query,
-              sortArr: req.body?.sorts,
-              filterArr: req.body?.filters
-            }
+            [key]: listArgs
           }
         }
       )
@@ -100,12 +103,21 @@ async function exportCsv(req: Request, res: Response) {
       }
       csvRows.push(csvRow);
     }
-    console.timeEnd('nocoExecute');
   }
 
   const data = papaparse.unparse(
     {
-      fields: model.columns.map(c => c.title),
+      fields: model.columns
+        .sort((c1, c2) =>
+          Array.isArray(fields)
+            ? fields.indexOf(c1.title as any) - fields.indexOf(c2.title as any)
+            : 0
+        )
+        .filter(
+          c =>
+            !fields || !Array.isArray(fields) || fields.includes(c.title as any)
+        )
+        .map(c => c.title),
       data: csvRows
     },
     {