From c58af561139edeaf7ee3ab8960dd40dae64dc6f7 Mon Sep 17 00:00:00 2001 From: mertmit Date: Mon, 15 Jan 2024 01:32:27 +0300 Subject: [PATCH] fix: remove unused code Signed-off-by: mertmit --- packages/nocodb/src/models/BarcodeColumn.ts | 23 +-------------------- packages/nocodb/src/models/QrCodeColumn.ts | 21 ------------------- 2 files changed, 1 insertion(+), 43 deletions(-) diff --git a/packages/nocodb/src/models/BarcodeColumn.ts b/packages/nocodb/src/models/BarcodeColumn.ts index 90e1a5dfdb..7cd81d6778 100644 --- a/packages/nocodb/src/models/BarcodeColumn.ts +++ b/packages/nocodb/src/models/BarcodeColumn.ts @@ -27,6 +27,7 @@ export default class BarcodeColumn { return this.read(barcodeColumn.fk_column_id, ncMeta); } + public static async read(columnId: string, ncMeta = Noco.ncMeta) { let column = columnId && @@ -47,28 +48,6 @@ export default class BarcodeColumn { return column ? new BarcodeColumn(column) : null; } - static async update( - id: string, - barcode: Partial, - ncMeta = Noco.ncMeta, - ) { - const updateObj = extractProps(barcode, [ - 'fk_column_id', - 'fk_barcode_value_column_id', - 'barcode_format', - ]); - // get existing cache - const key = `${CacheScope.COL_BARCODE}:${id}`; - let o = await NocoCache.get(key, CacheGetType.TYPE_OBJECT); - if (o) { - o = { ...o, ...updateObj }; - // set cache - await NocoCache.set(key, o); - } - // set meta - await ncMeta.metaUpdate(null, null, MetaTable.COL_BARCODE, updateObj, id); - } - async getValueColumn() { return Column.get({ colId: this.fk_barcode_value_column_id, diff --git a/packages/nocodb/src/models/QrCodeColumn.ts b/packages/nocodb/src/models/QrCodeColumn.ts index 947f610a4f..aa597145b2 100644 --- a/packages/nocodb/src/models/QrCodeColumn.ts +++ b/packages/nocodb/src/models/QrCodeColumn.ts @@ -47,27 +47,6 @@ export default class QrCodeColumn { id: string; - static async update( - id: string, - qrCode: Partial, - ncMeta = Noco.ncMeta, - ) { - const updateObj = extractProps(qrCode, [ - 'fk_column_id', - 'fk_qr_value_column_id', - ]); - // get existing cache - const key = `${CacheScope.COL_QRCODE}:${id}`; - let o = await NocoCache.get(key, CacheGetType.TYPE_OBJECT); - if (o) { - o = { ...o, ...updateObj }; - // set cache - await NocoCache.set(key, o); - } - // set meta - await ncMeta.metaUpdate(null, null, MetaTable.COL_QRCODE, updateObj, id); - } - async getValueColumn() { return Column.get({ colId: this.fk_qr_value_column_id,