refactor: review suggestions

6 months ago · c467598895
1 changed files with 1 additions and 6 deletions
--- a/packages/nocodb/src/models/Model.ts
+++ b/packages/nocodb/src/models/Model.ts
@ -237,11 +237,6 @@ export default class Model implements TableType {
    let { list: modelList } = cachedList;
    const { isNoneList } = cachedList;

-    let condition;
-    if(source_id){
-      condition = { source_id }
-    }
-
    if (!isNoneList && !modelList.length) {
      modelList = await ncMeta.metaList2(
        context.workspace_id,
@ -251,7 +246,7 @@ export default class Model implements TableType {
          orderBy: {
            order: 'asc',
          },
-          condition,
+          ...(source_id ? { condition: { source_id } } : {}),
        },
      );