From c30e437943850b32eebdaade640d4d791f1407b3 Mon Sep 17 00:00:00 2001 From: Wing-Kam Wong Date: Wed, 15 Mar 2023 19:19:46 +0800 Subject: [PATCH] fix(nc-gui): useViewFilter type issues --- packages/nc-gui/composables/useViewFilters.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/nc-gui/composables/useViewFilters.ts b/packages/nc-gui/composables/useViewFilters.ts index 45c9394324..486ed25b8d 100644 --- a/packages/nc-gui/composables/useViewFilters.ts +++ b/packages/nc-gui/composables/useViewFilters.ts @@ -162,10 +162,9 @@ export function useViewFilters( const placeholderFilter = (): Filter => { return { - // TODO: fix type comparison_op: comparisonOpList(options.value?.[0].uidt as UITypes).filter((compOp) => isComparisonOpAllowed({ fk_column_id: options.value?.[0].id }, compOp), - )?.[0].value, + )?.[0].value as FilterType['comparison_op'], value: '', status: 'create', logical_op: 'and', @@ -281,7 +280,6 @@ export function useViewFilters( comparison: filter.comparison_op, }) } else { - // todo: return type of dbTableFilter is void? filters.value[i] = await $api.dbTableFilter.create(view.value.id!, { ...filter, fk_parent_id: parentId,