From c01458ee5171803815d93f14e0b134c7339be140 Mon Sep 17 00:00:00 2001 From: Ramesh Mane <101566080+rameshmane7218@users.noreply.github.com> Date: Wed, 13 Mar 2024 21:16:13 +0000 Subject: [PATCH] fix(nc-gui): pr review changes --- packages/nc-gui/components/monaco/Editor.vue | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/packages/nc-gui/components/monaco/Editor.vue b/packages/nc-gui/components/monaco/Editor.vue index 66420b4bfb..49831adebf 100644 --- a/packages/nc-gui/components/monaco/Editor.vue +++ b/packages/nc-gui/components/monaco/Editor.vue @@ -15,20 +15,18 @@ interface Props { autoFocus?: boolean } -const props = withDefaults(defineProps(), { - modelValue: '', - lang: 'json', - validate: true, - disableDeepCompare: false, - autoFocus: true, -}) +const { + hideMinimap, + lang = 'json', + validate = true, + disableDeepCompare = false, + readOnly, + autoFocus = true, + modelValue = '', +} = defineProps() const emits = defineEmits(['update:modelValue']) -const { modelValue } = toRefs(props) - -const { hideMinimap, lang, validate, disableDeepCompare, readOnly, autoFocus } = props - const vModel = computed({ get: () => { if (typeof modelValue === 'object') {