fix(gui-v2): requested changes for PR

Signed-off-by: mertmit <mertmit99@gmail.com>

packages/nc-gui-v2/components/dashboard/settings/Metadata.vue

@@ -10,11 +10,12 @@ const toast = useToast()
 
 let isLoading = $ref(false)
 let isDifferent = $ref(false)
-let metadiff = $ref<Array<any>>([])
+let metadiff = $ref<any[]>([])
 
 async function loadMetaDiff() {
   try {
     if (!project.value?.id) return
+
     isLoading = true
     isDifferent = false
     metadiff = await $api.project.metaDiffGet(project.value?.id)
@@ -34,6 +35,7 @@ async function loadMetaDiff() {
 async function syncMetaDiff() {
   try {
     if (!project.value?.id || !isDifferent) return
+
     isLoading = true
     await $api.project.metaDiffSync(project.value.id)
     toast.info(`Table metadata recreated successfully`)

packages/nc-gui-v2/components/dashboard/settings/UIAcl.vue

@@ -10,14 +10,23 @@ const { $api, $e } = useNuxtApp()
 const { project } = useProject()
 const toast = useToast()
 
-const roles = $ref<Array<string>>(['editor', 'commenter', 'viewer'])
+const roles = $ref<string[]>(['editor', 'commenter', 'viewer'])
 let isLoading = $ref(false)
-let tables = $ref<Array<any>>([])
-let searchInput = $ref<string>('')
+let tables = $ref<any[]>([])
+let searchInput = $ref('')
+
+const filteredTables = computed(() =>
+  tables.filter(
+    (el) =>
+      (typeof el?._ptn === 'string' && el._ptn.toLowerCase().includes(searchInput.toLowerCase())) ||
+      (typeof el?.title === 'string' && el.title.toLowerCase().includes(searchInput.toLowerCase())),
+  ),
+)
 
 async function loadTableList() {
   try {
     if (!project.value?.id) return
+
     isLoading = true
     // TODO includeM2M
     tables = await $api.project.modelVisibilityList(project.value?.id, {
@@ -33,6 +42,7 @@ async function loadTableList() {
 async function saveUIAcl() {
   try {
     if (!project.value?.id) return
+
     await $api.project.modelVisibilitySet(
       project.value.id,
       tables.filter((t) => t.edited),
@@ -44,6 +54,11 @@ async function saveUIAcl() {
   $e('a:proj-meta:ui-acl')
 }
 
+const onRoleCheck = (record: any, role: string) => {
+  record.disabled[role] = !record.disabled[role]
+  record.edited = true
+}
+
 onMounted(async () => {
   if (tables.length === 0) {
     await loadTableList()
@@ -102,20 +117,7 @@ const columns = [
           </div>
         </a-button>
       </div>
-      <a-table
-        class="w-full"
-        :data-source="
-          tables.filter(
-            (el) =>
-              (typeof el?._ptn === 'string' && el._ptn.toLowerCase().includes(searchInput.toLowerCase())) ||
-              (typeof el?.title === 'string' && el.title.toLowerCase().includes(searchInput.toLowerCase())),
-          )
-        "
-        :columns="columns"
-        :pagination="false"
-        :loading="isLoading"
-        bordered
-      >
+      <a-table class="w-full" :data-source="filteredTables" :columns="columns" :pagination="false" :loading="isLoading" bordered>
         <template #bodyCell="{ record, column }">
           <div v-if="column.name === 'table_name'">{{ record._ptn }}</div>
           <div v-if="column.name === 'view_name'">
@@ -128,14 +130,7 @@ const columns = [
             <div v-if="column.name === role">
               <a-tooltip>
                 <template #title>Click to hide '{{ record.title }}' for role:{{ role }} in UI dashboard</template>
-                <a-checkbox
-                  :checked="!record.disabled[role]"
-                  @change="
-                    // eslint-disable-next-line prettier/prettier
-                    record.disabled[role] = !record.disabled[role];
-                    record.edited = true
-                  "
-                ></a-checkbox>
+                <a-checkbox :checked="!record.disabled[role]" @change="onRoleCheck(record, role)"></a-checkbox>
               </a-tooltip>
             </div>
           </div>