From b95be12114a96942f03ca2d346a952e1269e9d02 Mon Sep 17 00:00:00 2001
From: Wing-Kam Wong <wingkwong.code@gmail.com>
Date: Tue, 18 Oct 2022 13:53:13 +0800
Subject: [PATCH] refactor(nc-gui): revise templateGenerator logic & move 
 getData to handleImport

---
 .../nc-gui/components/dlg/QuickImport.vue     | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/packages/nc-gui/components/dlg/QuickImport.vue b/packages/nc-gui/components/dlg/QuickImport.vue
index 2753f3418b..a0b47e6ddb 100644
--- a/packages/nc-gui/components/dlg/QuickImport.vue
+++ b/packages/nc-gui/components/dlg/QuickImport.vue
@@ -2,6 +2,7 @@
 import type { TableType } from 'nocodb-sdk'
 import type { UploadChangeParam, UploadFile } from 'ant-design-vue'
 import {
+  CSVTemplateAdapter,
   ExcelTemplateAdapter,
   ExcelUrlTemplateAdapter,
   Form,
@@ -136,6 +137,8 @@ const modalWidth = computed(() => {
   return 'max(60vw, 600px)'
 })
 
+let templateGenerator: CSVTemplateAdapter | JSONTemplateAdapter | ExcelTemplateAdapter | null
+
 async function handlePreImport() {
   preImportLoading.value = true
   isParsingData.value = true
@@ -161,7 +164,13 @@ async function handlePreImport() {
 
 async function handleImport() {
   try {
+    if (!templateGenerator) {
+      message.error(t('msg.error.templateGeneratorNotFound'))
+      return
+    }
+
     importLoading.value = true
+    importData.value = templateGenerator.getData()
     await templateEditorRef.value.importTemplate()
   } catch (e: any) {
     return message.error(await extractSdkResponseErrorMsg(e))
@@ -178,7 +187,7 @@ async function parseAndExtractData2(val: UploadFile[]) {
     importData.value = null
     importColumns.value = []
 
-    const templateGenerator = getAdapter(val)
+    templateGenerator = getAdapter(val)
 
     if (!templateGenerator) {
       message.error(t('msg.error.templateGeneratorNotFound'))
@@ -188,10 +197,9 @@ async function parseAndExtractData2(val: UploadFile[]) {
     await templateGenerator.init()
 
     templateGenerator.parse(() => {
-      templateData.value = templateGenerator.getTemplate()
+      templateData.value = templateGenerator!.getTemplate()
+      // TODO(import): remove
       // templateData.value.tables[0].table_name = populateUniqueTableName()
-      // importData.value = templateGenerator.getData()
-
       // if (importOnly) importColumns.value = templateGenerator.getColumns()
       templateEditorModal.value = true
       isParsingData.value = false
@@ -218,9 +226,8 @@ async function parseAndExtractData(val: string | ArrayBuffer) {
 
     templateGenerator.parse(() => {})
     templateData.value = templateGenerator.getTemplate()
-    templateData.value.tables[0].table_name = populateUniqueTableName()
-    importData.value = templateGenerator.getData()
 
+    // TODO(import): check
     if (importOnly) importColumns.value = templateGenerator.getColumns()
 
     templateEditorModal.value = true