From b8ac1605e9034fd0f2fc9952f2a86fdc0afd7bf4 Mon Sep 17 00:00:00 2001
From: Pranav C <pranavxc@gmail.com>
Date: Fri, 1 Jul 2022 12:48:58 +0530
Subject: [PATCH] wip: navigation correction

Signed-off-by: Pranav C <pranavxc@gmail.com>
---
 .../components/dashboard/TabView.vue          |  9 +--
 .../components/dashboard/TreeView.vue         |  6 +-
 packages/nc-gui-v2/composables/tabs.ts        |  7 +-
 packages/nc-gui-v2/composables/user.ts        | 23 +++++-
 packages/nc-gui-v2/helpers/errorUtils.ts      |  2 +-
 packages/nc-gui-v2/layouts/default.vue        | 12 +--
 .../nc-gui-v2/pages/dashboard/[projectId].vue | 15 +++-
 packages/nc-gui-v2/pages/index.vue            | 36 ++-------
 packages/nc-gui-v2/pages/projects/index.vue   | 73 ++++++++++++++-----
 packages/nc-gui-v2/pages/signin.vue           |  9 ++-
 packages/nc-gui-v2/pages/signup.vue           |  6 +-
 11 files changed, 124 insertions(+), 74 deletions(-)

diff --git a/packages/nc-gui-v2/components/dashboard/TabView.vue b/packages/nc-gui-v2/components/dashboard/TabView.vue
index 2d02d1b0e2..304e25046e 100644
--- a/packages/nc-gui-v2/components/dashboard/TabView.vue
+++ b/packages/nc-gui-v2/components/dashboard/TabView.vue
@@ -1,8 +1,8 @@
 <template>
   <div>
-    <TabMenu :model="tabItems" v-model:activeIndex="activeIndex"/>
-    <template v-if="tabItems && tabItems[activeIndex]">
-     <TabsSmartsheet :tab-meta="tabs[activeIndex]" :key="tabs[activeIndex].id"/>
+    <TabMenu :model="tabItems" v-model:activeIndex="activeTab"/>
+    <template v-if="tabItems && tabItems[activeTab]">
+     <TabsSmartsheet :tab-meta="tabs[activeTab]" :key="tabs[activeTab].id"/>
     </template>
   </div>
 </template>
@@ -11,8 +11,7 @@
 
 import {useTabs} from "~/composables/tabs";
 
-const {tabs} = useTabs()
-const activeIndex = ref(0)
+const {tabs,activeTab} = useTabs()
 
 const tabItems = computed(() => {
   return tabs.value.map(tab => {
diff --git a/packages/nc-gui-v2/components/dashboard/TreeView.vue b/packages/nc-gui-v2/components/dashboard/TreeView.vue
index 89aa2917c5..fe51636337 100644
--- a/packages/nc-gui-v2/components/dashboard/TreeView.vue
+++ b/packages/nc-gui-v2/components/dashboard/TreeView.vue
@@ -1,7 +1,7 @@
 <template>
   <div>
 
-    <div v-for="table in tables" class="p-2 text-sm"
+    <div v-for="table in tables" class="p-2 text-sm pointer"
          @click="addTab({type:'table',title:table.title, id:table.id})">
       {{ table.title }}
     </div>
@@ -18,5 +18,7 @@ const {addTab} = useTabs()
 </script>
 
 <style scoped>
-
+.pointer{
+  cursor: pointer;
+}
 </style>
diff --git a/packages/nc-gui-v2/composables/tabs.ts b/packages/nc-gui-v2/composables/tabs.ts
index 2fec3df13a..d8cbd311a3 100644
--- a/packages/nc-gui-v2/composables/tabs.ts
+++ b/packages/nc-gui-v2/composables/tabs.ts
@@ -8,10 +8,15 @@ interface TabItem {
 
 export const useTabs = () => {
   const tabs = useState<Array<TabItem>>('tabs', () => [])
+  const activeTab = useState<number>('activeTab', ()=>0)
 
   const addTab = (tabMeta: TabItem) => {
     tabs.value = [...(tabs.value || []), tabMeta]
+    activeTab.value = tabs.value.length - 1
+  }
+  const clearTabs = () => {
+    tabs.value = []
   }
 
-  return {tabs, addTab}
+  return {tabs, addTab, activeTab, clearTabs}
 }
diff --git a/packages/nc-gui-v2/composables/user.ts b/packages/nc-gui-v2/composables/user.ts
index 7cb1d641de..4d77a28103 100644
--- a/packages/nc-gui-v2/composables/user.ts
+++ b/packages/nc-gui-v2/composables/user.ts
@@ -1,15 +1,32 @@
 import {store} from 'nuxt3-store'
+import {Api} from "nocodb-sdk";
+import {useNuxtApp} from "#app";
 
 export  const useUser = () =>{
   const user =  store({
     name: 'user',
     type: 'localstorage',
-    value: {token: null},
+    value: {token: null, user : null},
     reactiveType: 'reactive',
     version: '1.0.0'
   })
 
-  const setToken = (token) => { user.token = token }
+  const {$api}: { $api: Api<any> } = useNuxtApp() as any
 
-  return {user,setToken}
+
+  const getUser =async (args = {}) => {
+    const userInfo = await $api.auth.me(args, {
+      headers: {
+        'xc-auth': user.value.token
+      }
+    })
+
+    user.user = userInfo
+  }
+
+  const setToken =  (token) => {
+    user.token = token
+  }
+
+  return {user,setToken, getUser}
 }
diff --git a/packages/nc-gui-v2/helpers/errorUtils.ts b/packages/nc-gui-v2/helpers/errorUtils.ts
index 7bcc605e4e..a3a5f8cfd5 100644
--- a/packages/nc-gui-v2/helpers/errorUtils.ts
+++ b/packages/nc-gui-v2/helpers/errorUtils.ts
@@ -8,7 +8,7 @@ export async function extractSdkResponseErrorMsg(e:Error & {response:any}) {
       msg = 'Some internal error occurred'
     }
   } else {
-    msg = e.response.data.msg || 'Some internal error occurred'
+    msg = e.response.data.msg || e.response.data.message || 'Some internal error occurred'
   }
   return msg || 'Some error occurred'
 }
diff --git a/packages/nc-gui-v2/layouts/default.vue b/packages/nc-gui-v2/layouts/default.vue
index 03cb32c75d..bbe65cec47 100644
--- a/packages/nc-gui-v2/layouts/default.vue
+++ b/packages/nc-gui-v2/layouts/default.vue
@@ -1,12 +1,12 @@
 <template>
   <div class="">
-    <div class="topbar">
-    </div>
-    <div class="sidebar">
-    </div>
-    <div class="content">
+<!--    <div class="topbar">-->
+<!--    </div>-->
+<!--    <div class="sidebar">-->
+<!--    </div>-->
+<!--    <div class="content">-->
       <slot></slot>
-    </div>
+<!--    </div>-->
   </div>
 </template>
 
diff --git a/packages/nc-gui-v2/pages/dashboard/[projectId].vue b/packages/nc-gui-v2/pages/dashboard/[projectId].vue
index e5853f1ade..7f7772dcef 100644
--- a/packages/nc-gui-v2/pages/dashboard/[projectId].vue
+++ b/packages/nc-gui-v2/pages/dashboard/[projectId].vue
@@ -1,4 +1,5 @@
 <template>
+  <!--  todo: move to layout or create a reusable component -->
   <div class="nc-container">
     <div class="nc-topbar shadow-2">
     </div>
@@ -12,11 +13,13 @@
 </template>
 
 <script setup lang="ts">
-import {useNuxtApp} from "#app";
 import {useProject} from "~/composables/project";
+import {watch} from "vue";
+import {useTabs} from "~/composables/tabs";
 
 const route = useRoute()
 const {loadProject, loadTables} = useProject()
+const {clearTabs} = useTabs()
 
 
 onMounted(async () => {
@@ -24,6 +27,14 @@ onMounted(async () => {
   await loadTables()
 })
 
+watch(() => route.params.projectId, async (newVal, oldVal) => {
+  if (newVal && newVal !== oldVal) {
+    clearTabs()
+    await loadProject(newVal as string)
+    await loadTables()
+  }
+})
+
 </script>
 
 <style scoped lang="scss">
@@ -34,7 +45,7 @@ onMounted(async () => {
     left: 0;
     height: 50px;
     width: 100%;
-
+    z-index: 5;
   }
 
   .nc-sidebar {
diff --git a/packages/nc-gui-v2/pages/index.vue b/packages/nc-gui-v2/pages/index.vue
index 15deef18a9..f7ffddb01a 100644
--- a/packages/nc-gui-v2/pages/index.vue
+++ b/packages/nc-gui-v2/pages/index.vue
@@ -1,41 +1,17 @@
 <template>
   <div class="container">
-    <div>
-      <img alt="Vue logo" src="../assets/icon.png" width="50">
-      <Toast />
 
-      <div >
-        <form @submit.prevent="greet">
-          <InputText type="text" v-model="text"/>
-          <Button type="submit" label="Submit"/>
-        </form>
-      </div>
-    </div>
   </div>
 </template>
 
 <script setup lang="ts">
-import { ref } from 'vue';
-import { useToast } from "primevue/usetoast";
-const text = ref();
-const toast = useToast();
-const greet = () => {
-  toast.add({severity: 'info', summary: 'Hello '  + text.value});
-}
+import {useRouter} from "#app";
+
+const $router = useRouter()
+
+$router.replace('/projects')
 </script>
 
 <style lang="scss">
-.container {
-  margin: 0 auto;
-  min-height: 100vh;
-  display: flex;
-  justify-content: center;
-  align-items: center;
-  div {
-    display: flex;
-    flex-direction: column;
-    align-items: center;
-    margin-top: 1rem;
-  }
-}
+
 </style>
diff --git a/packages/nc-gui-v2/pages/projects/index.vue b/packages/nc-gui-v2/pages/projects/index.vue
index e030b6e9cc..2dc5fe0bb3 100644
--- a/packages/nc-gui-v2/pages/projects/index.vue
+++ b/packages/nc-gui-v2/pages/projects/index.vue
@@ -1,31 +1,45 @@
 <template>
-  <div>
 
-    <div class="grid">
-      <div class="col-3 p-3" v-for="project in projects" :key="project.id">
 
-        <Card @click="navigateToDashboard(project)">
-          <template #content>
-            <div class="text-center">
-              <h3>{{ project.title }}</h3>
-            </div>
-          </template>
-        </Card>
+  <!--  todo: move to layout or create a reusable component -->
+  <div class="nc-container">
+    <div class="nc-topbar shadow-2">
+    </div>
+    <div class="nc-sidebar shadow-2 p-4 overflow-y-auto">
 
-      </div>
     </div>
+    <div class="nc-content p-4 overflow-auto">
+      <div class="grid">
+        <div class="col-3 p-3" v-for="project in projects" :key="project.id">
 
+          <Card @click="navigateToDashboard(project)">
+            <template #content>
+              <div class="text-center">
+                <h3>{{ project.title }}</h3>
+              </div>
+            </template>
+          </Card>
+
+        </div>
+      </div>
+    </div>
   </div>
+
 </template>
 
 <script setup lang="ts">
 
-import {Api} from "nocodb-sdk";
+import {useRouter} from "#app";
 
-const {$api, $router}= useNuxtApp()
-const projects = ref()
+const {$api} = useNuxtApp()
 const {user} = useUser()
 
+
+
+const $router = useRouter()
+
+const projects = ref()
+
 const loadProjects = async () => {
   const projectsResponse = await $api.project.list({}, {
     headers: {
@@ -36,9 +50,7 @@ const loadProjects = async () => {
 }
 
 const navigateToDashboard = async (project) => {
-  await $router.push({
-    path: '/dashboard/'  + project.id
-  })
+  await $router.push('/dashboard/' + project.id)
 }
 
 onMounted(async () => {
@@ -46,6 +58,31 @@ onMounted(async () => {
 })
 </script>
 
-<style scoped>
+<style scoped lang="scss">
+.nc-container {
+  .nc-topbar {
+    position: fixed;
+    top: 0;
+    left: 0;
+    height: 50px;
+    width: 100%;
+    z-index: 5;
+  }
+
+  .nc-sidebar {
+    position: fixed;
+    top: 50px;
+    left: 0;
+    height: calc(100% - 50px);
+    width: 250px;
+  }
 
+  .nc-content {
+    position: fixed;
+    top: 50px;
+    left: 250px;
+    height: calc(100% - 50px);
+    width: calc(100% - 250px);
+  }
+}
 </style>
diff --git a/packages/nc-gui-v2/pages/signin.vue b/packages/nc-gui-v2/pages/signin.vue
index 0d770e1914..e2f644b4c8 100644
--- a/packages/nc-gui-v2/pages/signin.vue
+++ b/packages/nc-gui-v2/pages/signin.vue
@@ -35,9 +35,11 @@
 import {ref, reactive} from 'vue'
 import {useUser} from "~/composables/user";
 import {extractSdkResponseErrorMsg} from "~/helpers/errorUtils";
-import {useNuxtApp} from "#app";
+import {useNuxtApp, useRouter} from "#app";
+
+const { $api} = useNuxtApp()
+const $router = useRouter()
 
-const {$api} = useNuxtApp()
 const valid = ref()
 const error = ref()
 const form = reactive({
@@ -50,7 +52,8 @@ const signIn = async () => {
   error.value = null
   try {
     const {token} = await $api.auth.signin(form)
-    setToken(token)
+    await setToken(token)
+    await $router.push('/projects')
   } catch (e) {
     error.value = await extractSdkResponseErrorMsg(e)
   }
diff --git a/packages/nc-gui-v2/pages/signup.vue b/packages/nc-gui-v2/pages/signup.vue
index 7b52b3cbbf..473fae580f 100644
--- a/packages/nc-gui-v2/pages/signup.vue
+++ b/packages/nc-gui-v2/pages/signup.vue
@@ -34,10 +34,9 @@
 <script setup lang="ts">
 import {ref, reactive} from 'vue'
 import {useUser} from "~/composables/user";
-import {Api} from "nocodb-sdk";
 import {extractSdkResponseErrorMsg} from "~/helpers/errorUtils";
 
-const {$api}: { $api: Api<any> } = useNuxtApp() as any
+const {$api, $router} = useNuxtApp()
 const valid = ref()
 const error = ref()
 const form = reactive({
@@ -50,7 +49,8 @@ const signUp = async () => {
   error.value = null
   try {
     const {token} = await $api.auth.signup(form)
-    setToken(token)
+    await setToken(token)
+    $router.push('/projects')
   } catch (e) {
     error.value = await extractSdkResponseErrorMsg(e)
   }