From b862043ce25ff49926754ea05282a300278ec746 Mon Sep 17 00:00:00 2001
From: Pranav C <pranavxc@gmail.com>
Date: Fri, 29 Dec 2023 17:12:22 +0530
Subject: [PATCH] fix: use withDefaults for setting default prop value

---
 packages/nc-gui/components/cell/Duration.vue    |  2 +-
 packages/nc-gui/components/cell/YearPicker.vue  |  2 +-
 packages/nc-gui/components/dlg/QuickImport.vue  |  2 +-
 packages/nc-gui/components/general/Overlay.vue  |  7 ++++++-
 packages/nc-gui/components/general/Share.vue    | 17 +++++++----------
 packages/nc-gui/components/general/Sponsors.vue |  2 +-
 .../nc-gui/components/general/TruncateText.vue  |  2 +-
 packages/nc-gui/components/monaco/Editor.vue    |  6 +++++-
 .../virtual-cell/components/ItemChip.vue        |  9 ++++++++-
 packages/nc-gui/pages/projects/index/index.vue  |  4 +++-
 packages/nc-gui/pages/projects/index/list.vue   |  4 +++-
 11 files changed, 37 insertions(+), 20 deletions(-)

diff --git a/packages/nc-gui/components/cell/Duration.vue b/packages/nc-gui/components/cell/Duration.vue
index b4bf77263c..84d2c9e407 100644
--- a/packages/nc-gui/components/cell/Duration.vue
+++ b/packages/nc-gui/components/cell/Duration.vue
@@ -20,7 +20,7 @@ interface Props {
   showValidationError?: boolean
 }
 
-const { modelValue, showValidationError = true } = defineProps<Props>()
+const { modelValue, showValidationError } = withDefaults(defineProps<Props>(), { showValidationError: true })
 
 const emit = defineEmits(['update:modelValue'])
 
diff --git a/packages/nc-gui/components/cell/YearPicker.vue b/packages/nc-gui/components/cell/YearPicker.vue
index 69e3302912..ad70fa1767 100644
--- a/packages/nc-gui/components/cell/YearPicker.vue
+++ b/packages/nc-gui/components/cell/YearPicker.vue
@@ -18,7 +18,7 @@ interface Props {
   isPk?: boolean
 }
 
-const { modelValue, isPk = false } = defineProps<Props>()
+const { modelValue, isPk = false } = withDefaults(defineProps<Props>(), { isPk: false })
 
 const emit = defineEmits(['update:modelValue'])
 
diff --git a/packages/nc-gui/components/dlg/QuickImport.vue b/packages/nc-gui/components/dlg/QuickImport.vue
index d49f72f209..c38a48cb08 100644
--- a/packages/nc-gui/components/dlg/QuickImport.vue
+++ b/packages/nc-gui/components/dlg/QuickImport.vue
@@ -45,7 +45,7 @@ interface Props {
   importDataOnly?: boolean
 }
 
-const { importType, importDataOnly = false, sourceId, ...rest } = defineProps<Props>()
+const { importType, importDataOnly, sourceId, ...rest } = withDefaults(defineProps<Props>(), { importDataOnly: false })
 
 const emit = defineEmits(['update:modelValue'])
 
diff --git a/packages/nc-gui/components/general/Overlay.vue b/packages/nc-gui/components/general/Overlay.vue
index 2c1ac4f157..b202c4add8 100644
--- a/packages/nc-gui/components/general/Overlay.vue
+++ b/packages/nc-gui/components/general/Overlay.vue
@@ -22,7 +22,12 @@ interface Emits {
   (event: 'open'): void
 }
 
-const { transition = true, teleportDisabled = false, inline = false, target, zIndex = 100, ...rest } = defineProps<Props>()
+const { transition, teleportDisabled, inline, target, zIndex, ...rest } = withDefaults(defineProps<Props>(), {
+  transition: true,
+  teleportDisabled: false,
+  inline: false,
+  zIndex: 100,
+})
 
 const emits = defineEmits<Emits>()
 
diff --git a/packages/nc-gui/components/general/Share.vue b/packages/nc-gui/components/general/Share.vue
index db92bdd0ee..018a578089 100644
--- a/packages/nc-gui/components/general/Share.vue
+++ b/packages/nc-gui/components/general/Share.vue
@@ -12,16 +12,13 @@ interface Props {
   width?: string
 }
 
-const {
-  url,
-  socialMedias,
-  title = 'NocoDB',
-  summary,
-  hashTags = '',
-  css = '',
-  iconClass = '',
-  width = '45px',
-} = defineProps<Props>()
+const { url, socialMedias, title, summary, hashTags, css, iconClass, width } = withDefaults(defineProps<Props>(), {
+  title: 'NocoDB',
+  hashTags: '',
+  css: '',
+  iconClass: '',
+  width: '45px',
+})
 
 const summaryArr = [
   'Instant #Rest & #GraphQL APIs on any #SQL Database (Supports : MySQL, PostgresSQL, MsSQL, SQLite, MariaDB) #nocodb ',
diff --git a/packages/nc-gui/components/general/Sponsors.vue b/packages/nc-gui/components/general/Sponsors.vue
index 5885217b57..6f502c72a9 100644
--- a/packages/nc-gui/components/general/Sponsors.vue
+++ b/packages/nc-gui/components/general/Sponsors.vue
@@ -3,7 +3,7 @@ interface Props {
   nav?: boolean
 }
 
-const { nav = false } = defineProps<Props>()
+const { nav } = withDefaults(defineProps<Props>(), { nav: false })
 </script>
 
 <template>
diff --git a/packages/nc-gui/components/general/TruncateText.vue b/packages/nc-gui/components/general/TruncateText.vue
index 9b01c85898..551d8afbdb 100644
--- a/packages/nc-gui/components/general/TruncateText.vue
+++ b/packages/nc-gui/components/general/TruncateText.vue
@@ -18,7 +18,7 @@ interface Props {
   length?: number
 }
 
-const { placement = 'bottom', length = 20 } = defineProps<Props>()
+const { placement, length } = withDefaults(defineProps<Props>(), { placement: 'bottom', length: 20 })
 
 const text = ref<HTMLDivElement>()
 
diff --git a/packages/nc-gui/components/monaco/Editor.vue b/packages/nc-gui/components/monaco/Editor.vue
index a353cbca43..c8c6a7f0a2 100644
--- a/packages/nc-gui/components/monaco/Editor.vue
+++ b/packages/nc-gui/components/monaco/Editor.vue
@@ -14,7 +14,11 @@ interface Props {
   readOnly?: boolean
 }
 
-const { hideMinimap, lang = 'json', validate = true, disableDeepCompare = false, modelValue, readOnly } = defineProps<Props>()
+const { hideMinimap, lang, validate, disableDeepCompare, modelValue, readOnly } = withDefaults(defineProps<Props>(), {
+  lang: 'json',
+  validate: true,
+  disableDeepCompare: false,
+})
 
 const emits = defineEmits(['update:modelValue'])
 
diff --git a/packages/nc-gui/components/virtual-cell/components/ItemChip.vue b/packages/nc-gui/components/virtual-cell/components/ItemChip.vue
index 51d6e688b6..3f715f93a5 100644
--- a/packages/nc-gui/components/virtual-cell/components/ItemChip.vue
+++ b/packages/nc-gui/components/virtual-cell/components/ItemChip.vue
@@ -22,7 +22,14 @@ interface Props {
   readonly?: boolean
 }
 
-const { value, item, column, showUnlinkButton, border = true, readonly: readonlyProp } = defineProps<Props>()
+const {
+  value,
+  item,
+  column,
+  showUnlinkButton,
+  border,
+  readonly: readonlyProp,
+} = withDefaults(defineProps<Props>(), { border: true })
 
 const emit = defineEmits(['unlink'])
 
diff --git a/packages/nc-gui/pages/projects/index/index.vue b/packages/nc-gui/pages/projects/index/index.vue
index a8b5484727..c49e7df107 100644
--- a/packages/nc-gui/pages/projects/index/index.vue
+++ b/packages/nc-gui/pages/projects/index/index.vue
@@ -6,7 +6,9 @@ interface Props {
   bases?: BaseType[]
 }
 
-const { bases = [] } = defineProps<Props>()
+const { bases } = withDefaults(defineProps<Props>(), {
+  bases: () => [],
+})
 
 const emit = defineEmits(['delete-base'])
 
diff --git a/packages/nc-gui/pages/projects/index/list.vue b/packages/nc-gui/pages/projects/index/list.vue
index 07e5fe436e..e85df6df2f 100644
--- a/packages/nc-gui/pages/projects/index/list.vue
+++ b/packages/nc-gui/pages/projects/index/list.vue
@@ -6,7 +6,9 @@ interface Props {
   bases?: BaseType[]
 }
 
-const { bases = [] } = defineProps<Props>()
+const { bases } = withDefaults(defineProps<Props>(), {
+  bases: () => [],
+})
 
 const emit = defineEmits(['delete-base'])