From b6d2e5438581962d3f41ba2d04fda40bc7cfab95 Mon Sep 17 00:00:00 2001
From: Pranav C <pranavxc@gmail.com>
Date: Tue, 27 Aug 2024 07:23:44 +0000
Subject: [PATCH] refactor: suggested changes

---
 .../components/account/setup/AppIcon.vue      |  4 +---
 .../components/account/setup/Config.vue       | 11 +++++++++-
 .../components/nc/form-builder/index.vue      | 20 ++++++++++++++++++-
 3 files changed, 30 insertions(+), 5 deletions(-)

diff --git a/packages/nc-gui/components/account/setup/AppIcon.vue b/packages/nc-gui/components/account/setup/AppIcon.vue
index 69f5a26aac..aca7b4cadc 100644
--- a/packages/nc-gui/components/account/setup/AppIcon.vue
+++ b/packages/nc-gui/components/account/setup/AppIcon.vue
@@ -8,8 +8,6 @@ defineProps<{
 </script>
 
 <template>
-  <img v-if="app.title !== 'SMTP'" class="icon" :alt="app.title" :src="app.logo" />
+  <img v-if="app.title !== 'SMTP'" class="object-contain" :alt="app.title" :src="app.logo" />
   <GeneralIcon v-else class="text-gray-500" icon="mail" />
 </template>
-
-<style scoped lang="scss"></style>
diff --git a/packages/nc-gui/components/account/setup/Config.vue b/packages/nc-gui/components/account/setup/Config.vue
index 87fc7ce8f3..aa978437ac 100644
--- a/packages/nc-gui/components/account/setup/Config.vue
+++ b/packages/nc-gui/components/account/setup/Config.vue
@@ -1,4 +1,6 @@
 <script setup lang="ts">
+import dayjs from 'dayjs'
+
 const props = defineProps<{
   id: string
   modelValue?: boolean
@@ -131,7 +133,7 @@ const isValid = computed(() => {
 
           <a href="httpd://docs.nocodb.com" rel="noopener noreferrer" target="_blank" class="!no-underline !text-current">
             <GeneralIcon icon="bookOpen" class="text-gray-500" />
-            Workspace Setup
+            Application Setup
           </a>
           <a
             v-for="doc of plugin.formDetails?.docs || []"
@@ -144,6 +146,13 @@ const isValid = computed(() => {
             <GeneralIcon icon="bookOpen" class="text-gray-500" />
             {{ doc.title }}
           </a>
+
+          <NcDivider />
+
+          <div class="text-gray-500 text-capitalize">Modified on</div>
+          <div class="">
+            {{ dayjs(plugin.created_at).format('DD MMM YYYY HH:mm') }}
+          </div>
         </div>
       </div>
     </div>
diff --git a/packages/nc-gui/components/nc/form-builder/index.vue b/packages/nc-gui/components/nc/form-builder/index.vue
index 287833b97a..8f45fd182c 100644
--- a/packages/nc-gui/components/nc/form-builder/index.vue
+++ b/packages/nc-gui/components/nc/form-builder/index.vue
@@ -59,13 +59,18 @@ const setFormState = (path: string, value: any) => {
                   </template>
                   <template v-if="field.type === FormBuilderInputType.Input">
                     <a-input
+                      autocomplete="off"
                       class="!w-full"
                       :value="deepReference(field.model)"
                       @update:value="setFormState(field.model, $event)"
                     />
                   </template>
                   <template v-else-if="field.type === FormBuilderInputType.Password">
-                    <a-input-password :value="deepReference(field.model)" @update:value="setFormState(field.model, $event)" />
+                    <a-input-password
+                      autocomplete="off"
+                      :value="deepReference(field.model)"
+                      @update:value="setFormState(field.model, $event)"
+                    />
                   </template>
                   <template v-else-if="field.type === FormBuilderInputType.Select">
                     <NcSelect
@@ -122,6 +127,7 @@ const setFormState = (path: string, value: any) => {
 :deep(.ant-collapse-header) {
   @apply !-mt-4 !p-0 flex items-center !cursor-default children:first:flex;
 }
+
 :deep(.ant-collapse-icon-position-right > .ant-collapse-item > .ant-collapse-header .ant-collapse-arrow) {
   @apply !right-0;
 }
@@ -162,9 +168,11 @@ const setFormState = (path: string, value: any) => {
   .nc-form-section {
     @apply flex flex-col gap-3;
   }
+
   .nc-form-section-title {
     @apply text-sm font-bold text-gray-800;
   }
+
   .nc-form-section-body {
     @apply flex flex-col gap-3;
   }
@@ -179,9 +187,11 @@ const setFormState = (path: string, value: any) => {
         &:not(:hover):not(:focus):not(:disabled) {
           @apply shadow-default;
         }
+
         &:hover:not(:focus):not(:disabled) {
           @apply shadow-hover;
         }
+
         &:focus {
           @apply shadow-error ring-0;
         }
@@ -192,34 +202,42 @@ const setFormState = (path: string, value: any) => {
         &:not(:hover):not(:focus-within):not(:disabled) {
           @apply shadow-default;
         }
+
         &:hover:not(:focus-within):not(:disabled) {
           @apply shadow-hover;
         }
+
         &:focus-within {
           @apply shadow-error ring-0;
         }
       }
     }
+
     &:not(.ant-form-item-has-error) {
       &:not(:has(.ant-input-password)) .ant-input {
         &:not(:hover):not(:focus):not(:disabled) {
           @apply shadow-default border-gray-200;
         }
+
         &:hover:not(:focus):not(:disabled) {
           @apply border-gray-200 shadow-hover;
         }
+
         &:focus {
           @apply shadow-selected ring-0;
         }
       }
+
       .ant-input-number,
       .ant-input-affix-wrapper.ant-input-password {
         &:not(:hover):not(:focus-within):not(:disabled) {
           @apply shadow-default border-gray-200;
         }
+
         &:hover:not(:focus-within):not(:disabled) {
           @apply border-gray-200 shadow-hover;
         }
+
         &:focus-within {
           @apply shadow-selected ring-0;
         }