From b56c585572cf2751add6e7044a3d22cc2b2bded3 Mon Sep 17 00:00:00 2001
From: Ramesh Mane <101566080+rameshmane7218@users.noreply.github.com>
Date: Sat, 6 Jul 2024 07:07:47 +0530
Subject: [PATCH] fix: load expnaded form row on cliking on bt, ltar cell chip
 (#8950)

* fix(nc-gui): load expnaded form row on cliking on bt, ltar cell chip

* fix(nc-gui): chip content alignment issue
---
 .../components/virtual-cell/BelongsTo.vue     |  4 +-
 .../components/virtual-cell/HasMany.vue       |  2 +-
 .../components/virtual-cell/ManyToMany.vue    |  2 +-
 .../components/virtual-cell/OneToOne.vue      |  4 +-
 .../virtual-cell/components/ItemChip.vue      | 49 ++++++++++++++++++-
 5 files changed, 54 insertions(+), 7 deletions(-)

diff --git a/packages/nc-gui/components/virtual-cell/BelongsTo.vue b/packages/nc-gui/components/virtual-cell/BelongsTo.vue
index 8f5cc35e58..667a14d4dd 100644
--- a/packages/nc-gui/components/virtual-cell/BelongsTo.vue
+++ b/packages/nc-gui/components/virtual-cell/BelongsTo.vue
@@ -87,8 +87,8 @@ watch(value, (next) => {
 <template>
   <div class="flex w-full chips-wrapper items-center" :class="{ active }">
     <LazyVirtualCellComponentsLinkRecordDropdown v-model:is-open="isOpen">
-      <div class="flex items-center w-full">
-        <div class="nc-cell-field chips flex items-center flex-1" :class="{ 'max-w-[calc(100%_-_16px)]': !isUnderLookup }">
+      <div class="nc-cell-field flex items-center w-full">
+        <div class="chips flex items-center flex-1" :class="{ 'max-w-[calc(100%_-_16px)]': !isUnderLookup }">
           <template v-if="value && (relatedTableDisplayValueProp || relatedTableDisplayValuePropId)">
             <VirtualCellComponentsItemChip
               :item="value"
diff --git a/packages/nc-gui/components/virtual-cell/HasMany.vue b/packages/nc-gui/components/virtual-cell/HasMany.vue
index db6606b0c6..c7b525d9cc 100644
--- a/packages/nc-gui/components/virtual-cell/HasMany.vue
+++ b/packages/nc-gui/components/virtual-cell/HasMany.vue
@@ -127,7 +127,7 @@ watch(
 
 <template>
   <LazyVirtualCellComponentsLinkRecordDropdown v-model:is-open="isOpen">
-    <div class="flex items-center gap-1 w-full chips-wrapper min-h-4">
+    <div class="nc-cell-field flex items-center gap-1 w-full chips-wrapper min-h-4">
       <div class="chips flex items-center img-container flex-1 hm-items flex-nowrap min-w-0 overflow-hidden">
         <template v-if="cells">
           <VirtualCellComponentsItemChip
diff --git a/packages/nc-gui/components/virtual-cell/ManyToMany.vue b/packages/nc-gui/components/virtual-cell/ManyToMany.vue
index 0c42e0bac6..a25fdf9b86 100644
--- a/packages/nc-gui/components/virtual-cell/ManyToMany.vue
+++ b/packages/nc-gui/components/virtual-cell/ManyToMany.vue
@@ -126,7 +126,7 @@ watch(
 
 <template>
   <LazyVirtualCellComponentsLinkRecordDropdown v-model:is-open="isOpen">
-    <div class="flex items-center gap-1 w-full chips-wrapper min-h-4">
+    <div class="nc-cell-field flex items-center gap-1 w-full chips-wrapper min-h-4">
       <div class="chips flex items-center img-container flex-1 hm-items flex-nowrap min-w-0 overflow-hidden">
         <template v-if="cells">
           <VirtualCellComponentsItemChip
diff --git a/packages/nc-gui/components/virtual-cell/OneToOne.vue b/packages/nc-gui/components/virtual-cell/OneToOne.vue
index ea5d4a6b25..01e4b397c7 100644
--- a/packages/nc-gui/components/virtual-cell/OneToOne.vue
+++ b/packages/nc-gui/components/virtual-cell/OneToOne.vue
@@ -84,8 +84,8 @@ watch(
 
 <template>
   <LazyVirtualCellComponentsLinkRecordDropdown v-model:is-open="isOpen">
-    <div class="flex w-full chips-wrapper items-center min-h-4" :class="{ active }">
-      <div class="nc-cell-field chips flex items-center flex-1 max-w-[calc(100%_-_16px)]">
+    <div class="nc-cell-field flex w-full chips-wrapper items-center min-h-4" :class="{ active }">
+      <div class="chips flex items-center flex-1 max-w-[calc(100%_-_16px)]">
         <template v-if="value && (relatedTableDisplayValueProp || relatedTableDisplayValuePropId)">
           <VirtualCellComponentsItemChip
             :item="value"
diff --git a/packages/nc-gui/components/virtual-cell/components/ItemChip.vue b/packages/nc-gui/components/virtual-cell/components/ItemChip.vue
index 8f9f9b1d53..08d42cf4e7 100644
--- a/packages/nc-gui/components/virtual-cell/components/ItemChip.vue
+++ b/packages/nc-gui/components/virtual-cell/components/ItemChip.vue
@@ -27,6 +27,8 @@ const isForm = inject(IsFormInj)!
 
 const isExpandedForm = inject(IsExpandedFormOpenInj, ref(false))
 
+const isPublic = inject(IsPublicInj, ref(false))
+
 const { open } = useExpandedFormDetached()
 
 function openExpandedForm() {
@@ -40,6 +42,7 @@ function openExpandedForm() {
       meta: relatedTableMeta.value,
       rowId,
       useMetaFields: true,
+      loadRow: !isPublic.value,
     })
   }
 }
@@ -58,7 +61,7 @@ export default {
     :class="{ active, 'border-1 py-1 px-2': isAttachment(column) }"
     @click="openExpandedForm"
   >
-    <div class="text-ellipsis overflow-hidden">
+    <div class="text-ellipsis overflow-hidden pointer-events-none">
       <span class="name">
         <!-- Render virtual cell -->
         <div v-if="isVirtualCol(column)">
@@ -112,5 +115,49 @@ export default {
     white-space: nowrap;
     word-break: keep-all;
   }
+  :deep(.nc-action-icon) {
+    @apply invisible;
+  }
+
+  :deep(.nc-cell) {
+    &.nc-cell-longtext {
+      .long-text-wrapper {
+        @apply min-h-1;
+        .nc-readonly-rich-text-wrapper {
+          @apply !min-h-1;
+        }
+        .nc-rich-text {
+          @apply pl-0;
+          .tiptap.ProseMirror {
+            @apply -ml-1 min-h-1;
+          }
+        }
+      }
+    }
+    &.nc-cell-checkbox {
+      @apply children:pl-0;
+      & > div {
+        @apply !h-auto;
+      }
+    }
+    &.nc-cell-singleselect .nc-cell-field > div {
+      @apply flex items-center;
+    }
+    &.nc-cell-multiselect .nc-cell-field > div {
+      @apply h-5;
+    }
+    &.nc-cell-email,
+    &.nc-cell-phonenumber {
+      @apply flex items-center;
+    }
+
+    &.nc-cell-email,
+    &.nc-cell-phonenumber,
+    &.nc-cell-url {
+      .nc-cell-field-link {
+        @apply py-0;
+      }
+    }
+  }
 }
 </style>