diff --git a/.all-contributorsrc b/.all-contributorsrc
index 1787418b03..d473b894eb 100644
--- a/.all-contributorsrc
+++ b/.all-contributorsrc
@@ -864,6 +864,15 @@
"contributions": [
"code"
]
+ },
+ {
+ "login": "dolsem",
+ "name": "Denis Olsem",
+ "avatar_url": "https://avatars.githubusercontent.com/u/14323955?v=4",
+ "profile": "https://github.com/dolsem",
+ "contributions": [
+ "code"
+ ]
}
],
"contributorsPerLine": 7,
diff --git a/README.md b/README.md
index 4534588a55..b7a0a980f9 100644
--- a/README.md
+++ b/README.md
@@ -453,6 +453,7 @@ Our mission is to provide the most powerful no-code interface for databases whic
Santam Chakraborty 🌍 |
Ikko Ashimine 💻 |
Asheer Rizvi 💻 |
+ Denis Olsem 💻 |
diff --git a/packages/nc-gui/components/cell/Checkbox.vue b/packages/nc-gui/components/cell/Checkbox.vue
index 0705a02495..abc49e68d5 100644
--- a/packages/nc-gui/components/cell/Checkbox.vue
+++ b/packages/nc-gui/components/cell/Checkbox.vue
@@ -42,9 +42,15 @@ function onClick() {
-
+
import type { VNodeRef } from '@vue/runtime-core'
import { message } from 'ant-design-vue'
-import { useI18n } from 'vue-i18n'
-import { CellUrlDisableOverlayInj, ColumnInj, EditModeInj, computed, inject, isValidURL, ref } from '#imports'
-import MiCircleWarning from '~icons/mi/circle-warning'
+import {
+ CellUrlDisableOverlayInj,
+ ColumnInj,
+ EditModeInj,
+ computed,
+ inject,
+ isValidURL,
+ ref,
+ useCellUrlConfig,
+ useI18n,
+ watch,
+} from '#imports'
-const { modelValue: value } = defineProps()
-const emit = defineEmits(['update:modelValue'])
-const { t } = useI18n()
interface Props {
modelValue?: string | null
}
+const { modelValue: value } = defineProps()
+
+const emit = defineEmits(['update:modelValue'])
+
+const { t } = useI18n()
+
const column = inject(ColumnInj)!
const editEnabled = inject(EditModeInj)!
const disableOverlay = inject(CellUrlDisableOverlayInj)
+
// Used in the logic of when to display error since we are not storing the url if its not valid
const localState = ref(value)
@@ -40,7 +53,8 @@ const url = computed(() => {
return `https://${value}`
})
-const urlOptions = useCellUrlConfig(url)
+
+const { cellUrlOptions } = useCellUrlConfig(url)
const focus: VNodeRef = (el) => (el as HTMLInputElement)?.focus()
@@ -62,20 +76,20 @@ watch(
{{ value }}
- {{ urlOptions.overlay }}
+ {{ cellUrlOptions.overlay }}
{{ value }}
diff --git a/packages/nc-gui/components/dashboard/TreeView.vue b/packages/nc-gui/components/dashboard/TreeView.vue
index b4f93a7778..a40f81fd54 100644
--- a/packages/nc-gui/components/dashboard/TreeView.vue
+++ b/packages/nc-gui/components/dashboard/TreeView.vue
@@ -286,7 +286,7 @@ function openTableCreateDialog() {