From aa6b4177fd89b07cbc787f63047df57b16ab3f68 Mon Sep 17 00:00:00 2001
From: Wing-Kam Wong <wingkwong.code@gmail.com>
Date: Fri, 8 Jul 2022 12:28:43 +0800
Subject: [PATCH] refactor: remove duplicate logic

---
 .../sql-data-mapper/lib/sql/BaseModelSqlv2.ts | 42 +++++++++----------
 1 file changed, 19 insertions(+), 23 deletions(-)

diff --git a/packages/nocodb/src/lib/db/sql-data-mapper/lib/sql/BaseModelSqlv2.ts b/packages/nocodb/src/lib/db/sql-data-mapper/lib/sql/BaseModelSqlv2.ts
index f4d59d6025..416ffed12f 100644
--- a/packages/nocodb/src/lib/db/sql-data-mapper/lib/sql/BaseModelSqlv2.ts
+++ b/packages/nocodb/src/lib/db/sql-data-mapper/lib/sql/BaseModelSqlv2.ts
@@ -1381,10 +1381,10 @@ class BaseModelSqlv2 {
   }
 
   async hasLTARData(rowId, model: Model): Promise<any> {
+    const res = [];
     const LTARColumns = (await model.getColumns()).filter(
       (c) => c.uidt === UITypes.LinkToAnotherRecord
     );
-    const res = [];
     let i = 0;
     for (const column of LTARColumns) {
       const colOptions =
@@ -1395,32 +1395,28 @@ class BaseModelSqlv2 {
       await childModel.getColumns();
       const parentModel = await parentColumn.getModel();
       await parentModel.getColumns();
+      let cnt = 0;
       if (colOptions.type === RelationTypes.HAS_MANY) {
-        const selectHmCount = await this.dbDriver(childModel.table_name)
-          .count(childColumn.column_name, { as: 'cnt' })
-          .where(childColumn.column_name, rowId);
-        const cnt = (await selectHmCount)[0].cnt;
-        if (cnt) {
-          res.push(
-            `${i++ + 1}. ${model.title}.${
-              column.title
-            } is a LinkToAnotherRecord of ${childModel.title}`
-          );
-        }
+        cnt = +(
+          await this.dbDriver(childModel.table_name)
+            .count(childColumn.column_name, { as: 'cnt' })
+            .where(childColumn.column_name, rowId)
+        )[0].cnt;
       } else if (colOptions.type === RelationTypes.MANY_TO_MANY) {
         const mmModel = await colOptions.getMMModel();
         const mmChildColumn = await colOptions.getMMChildColumn();
-        const selectMmCount = await this.dbDriver(mmModel.table_name)
-          .where(`${mmModel.table_name}.${mmChildColumn.column_name}`, rowId)
-          .count(mmChildColumn.column_name, { as: 'cnt' });
-        const cnt = (await selectMmCount)[0].cnt;
-        if (cnt) {
-          res.push(
-            `${i++ + 1}. ${model.title}.${
-              column.title
-            } is a LinkToAnotherRecord of ${parentModel.title}`
-          );
-        }
+        cnt = +(
+          await this.dbDriver(mmModel.table_name)
+            .where(`${mmModel.table_name}.${mmChildColumn.column_name}`, rowId)
+            .count(mmChildColumn.column_name, { as: 'cnt' })
+        )[0].cnt;
+      }
+      if (cnt) {
+        res.push(
+          `${i++ + 1}. ${model.title}.${
+            column.title
+          } is a LinkToAnotherRecord of ${childModel.title}`
+        );
       }
     }
     return res;