From a8c3e6603b0f278376b945184659cbae344ce27d Mon Sep 17 00:00:00 2001
From: Ramesh Mane <101566080+rameshmane7218@users.noreply.github.com>
Date: Sat, 2 Mar 2024 07:32:43 +0000
Subject: [PATCH] feat(nc-gui): option to hide from banner

---
 .../nc-gui/components/smartsheet/Form.vue     | 32 +++++++++++++++++--
 .../[typeOrId]/form/[viewId]/index/index.vue  |  2 +-
 2 files changed, 30 insertions(+), 4 deletions(-)

diff --git a/packages/nc-gui/components/smartsheet/Form.vue b/packages/nc-gui/components/smartsheet/Form.vue
index a2b8d946c1..02741bbae2 100644
--- a/packages/nc-gui/components/smartsheet/Form.vue
+++ b/packages/nc-gui/components/smartsheet/Form.vue
@@ -392,6 +392,7 @@ function setFormData() {
     meta: {
       hide_branding: false,
       background_color: '#F9F9FA',
+      hide_banner: false,
       ...(parseProp(formViewData.value?.meta) ?? {}),
     },
   }
@@ -684,7 +685,10 @@ useEventListener(
         data-testid="nc-form-wrapper-submit"
       >
         <div class="max-w-[max(33%,688px)] mx-auto">
-          <GeneralFormBanner :banner-image-url="formViewData?.banner_image_url" />
+          <GeneralFormBanner
+            v-if="!parseProp(formViewData?.meta).hide_banner"
+            :banner-image-url="formViewData?.banner_image_url"
+          />
 
           <div
             class="transition-all duration-300 ease-in relative my-6 bg-white rounded-3xl border-1 border-gray-200 px-4 py-8 lg:p-12 md:(p-8 dark:bg-slate-700)"
@@ -766,7 +770,7 @@ useEventListener(
                 @submit="handleOnUploadImage"
               ></GeneralImageCropper>
               <!-- cover image -->
-              <div class="group relative max-w-[max(33%,688px)] mx-auto">
+              <div v-if="!parseProp(formViewData?.meta).hide_banner" class="group relative max-w-[max(33%,688px)] mx-auto">
                 <GeneralFormBanner :banner-image-url="formViewData.banner_image_url" />
                 <div class="absolute bottom-0 right-0 hidden group-hover:block">
                   <div class="flex items-center space-x-1 m-2">
@@ -1519,7 +1523,7 @@ useEventListener(
                     <!-- Hide NocoDB Branding -->
                     <a-switch
                       v-if="isEeUI"
-                      v-e="[`a:form-view:submit-another-form`]"
+                      v-e="[`a:form-view:hide-branding`]"
                       :checked="parseProp(formViewData.meta)?.hide_branding"
                       size="small"
                       class="nc-form-hide-branding"
@@ -1544,6 +1548,28 @@ useEventListener(
                     </NcTooltip>
                     <span class="ml-4">{{ $t('labels.hideNocodbBranding') }}</span>
                   </div>
+                  <div class="flex items-center">
+                    <!-- Hide Banner -->
+                    <a-switch
+                      v-if="isEeUI"
+                      v-e="[`a:form-view:hide-banner`]"
+                      :checked="parseProp(formViewData.meta)?.hide_banner"
+                      size="small"
+                      class="nc-form-hide-banner"
+                      data-testid="nc-form-hide-banner"
+                      :disabled="isLocked || !isEditable"
+                      @change="
+                      (value) => {
+                        if (isLocked || !isEditable) return
+
+                        (formViewData!.meta as Record<string,any>).hide_banner = value
+                        updateView()
+                      }
+                    "
+                    />
+
+                    <span class="ml-4">{{ $t('general.hide') }} {{ $t('general.banner') }}</span>
+                  </div>
                 </div>
 
                 <div class="p-4 flex flex-col space-y-4">
diff --git a/packages/nc-gui/pages/index/[typeOrId]/form/[viewId]/index/index.vue b/packages/nc-gui/pages/index/[typeOrId]/form/[viewId]/index/index.vue
index 7b527cc138..ac9aa25d17 100644
--- a/packages/nc-gui/pages/index/[typeOrId]/form/[viewId]/index/index.vue
+++ b/packages/nc-gui/pages/index/[typeOrId]/form/[viewId]/index/index.vue
@@ -81,7 +81,7 @@ const onDecode = async (scannedCodeValue: string) => {
 <template>
   <div class="h-full flex flex-col items-center w-full max-w-[max(33%,688px)] mx-auto">
     <GeneralFormBanner
-      v-if="sharedFormView"
+      v-if="sharedFormView && !parseProp(sharedFormView?.meta).hide_banner"
       :banner-image-url="sharedFormView.banner_image_url"
       class="flex-none dark:border-none"
     />