From a828a4be434ec26e1a89f5540656bccbb4de6742 Mon Sep 17 00:00:00 2001 From: Pranav C Date: Wed, 7 Sep 2022 13:53:30 +0530 Subject: [PATCH] fix(gui-v2): use relative path as base url to avoid issue when using proxy Signed-off-by: Pranav C --- packages/nc-gui/composables/useApi/index.ts | 5 +++-- packages/nc-gui/composables/useGlobal/state.ts | 3 ++- packages/nc-gui/lib/constants.ts | 1 + 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/packages/nc-gui/composables/useApi/index.ts b/packages/nc-gui/composables/useApi/index.ts index 444c1bb401..532d785871 100644 --- a/packages/nc-gui/composables/useApi/index.ts +++ b/packages/nc-gui/composables/useApi/index.ts @@ -3,14 +3,15 @@ import { Api } from 'nocodb-sdk' import type { Ref } from 'vue' import type { CreateApiOptions, UseApiProps, UseApiReturn } from './types' import { addAxiosInterceptors } from './interceptors' +import { BASE_URL } from '~/lib' import { createEventHook, ref, unref, useCounter, useGlobal, useNuxtApp } from '#imports' -export function createApiInstance(options: CreateApiOptions = {}): Api { +export function createApiInstance({ baseURL = BASE_URL }: CreateApiOptions = {}): Api { const { appInfo } = $(useGlobal()) return addAxiosInterceptors( new Api({ - baseURL: options.baseURL ?? appInfo.ncSiteUrl, + baseURL: baseURL ?? appInfo.ncSiteUrl, }), ) } diff --git a/packages/nc-gui/composables/useGlobal/state.ts b/packages/nc-gui/composables/useGlobal/state.ts index 037a9f84ca..56316f62fb 100644 --- a/packages/nc-gui/composables/useGlobal/state.ts +++ b/packages/nc-gui/composables/useGlobal/state.ts @@ -2,6 +2,7 @@ import { usePreferredLanguages, useStorage } from '@vueuse/core' import { useJwt } from '@vueuse/integrations/useJwt' import type { JwtPayload } from 'jwt-decode' import type { AppInfo, State, StoredState } from './types' +import { BASE_URL } from '~/lib' import { computed, ref, toRefs, useCounter, useNuxtApp, useTimestamp } from '#imports' import type { User } from '~/lib' @@ -77,7 +78,7 @@ export function useGlobalState(storageKey = 'nocodb-gui-v2'): State { }) const appInfo = ref({ - ncSiteUrl: process.env.NC_BACKEND_URL || (process.env.NODE_ENV === 'production' ? '..' : 'http://localhost:8080'), + ncSiteUrl: BASE_URL, authType: 'jwt', connectToExternalDB: false, defaultLimit: 0, diff --git a/packages/nc-gui/lib/constants.ts b/packages/nc-gui/lib/constants.ts index 7b6465b2aa..875684598d 100644 --- a/packages/nc-gui/lib/constants.ts +++ b/packages/nc-gui/lib/constants.ts @@ -1,3 +1,4 @@ export const NOCO = 'noco' export const USER_PROJECT_ROLES = 'user_project_roles' export const SYSTEM_COLUMNS = ['id', 'title', 'created_at', 'updated_at'] +export const BASE_URL = process.env.NC_BACKEND_URL || (process.env.NODE_ENV === 'production' ? '..' : 'http://localhost:8080')