Merge pull request #5767 from nocodb/fix/5766-shared-grid-gallery-missing-lookup-meta

fix: include lookup related metas in shared view meta api

packages/nc-gui/components/smartsheet/Gallery.vue

@@ -7,6 +7,7 @@ import {
   IsFormInj,
   IsGalleryInj,
   IsGridInj,
+  IsPublicInj,
   MetaInj,
   NavigateDir,
   OpenNewRecordFormHookInj,
@@ -62,6 +63,8 @@ provide(IsGridInj, ref(false))
 provide(PaginationDataInj, paginationData)
 provide(ChangePageInj, changePage)
 
+const isPublic = inject(IsPublicInj, ref(false))
+
 const fields = inject(FieldsInj, ref([]))
 
 const route = useRoute()
@@ -125,6 +128,10 @@ const attachments = (record: any): Attachment[] => {
 }
 
 const expandForm = (row: RowType, state?: Record<string, any>) => {
+  if (isPublic.value) {
+    return
+  }
+
   const rowId = extractPkFromRow(row.row, meta.value!.columns!)
 
   if (rowId) {
@@ -234,6 +241,7 @@ watch(view, async (nextView) => {
               :data-testid="`nc-gallery-card-${record.row.id}`"
               @click="expandFormClick($event, record)"
               @contextmenu="showContextMenu($event, { row: rowIndex })"
+              :style="isPublic ? { cursor: 'default' } : { cursor: 'pointer' }"
             >
               <template v-if="galleryData?.fk_cover_image_col_id" #cover>
                 <a-carousel v-if="!reloadAttachments && attachments(record).length" autoplay class="gallery-carousel" arrows>

packages/nc-gui/components/smartsheet/header/Cell.vue

@@ -52,7 +52,7 @@ const openHeaderMenu = () => {
     <span
       v-if="column"
       class="name"
-      :class="{ 'cursor-pointer': !isForm && isUIAllowed('edit-column') }"
+      :class="{ 'cursor-pointer': !isForm && isUIAllowed('edit-column') && !hideMenu }"
       style="white-space: nowrap"
       :title="column.title"
       @dblclick="openHeaderMenu"

packages/nc-gui/components/virtual-cell/BelongsTo.vue

@@ -7,6 +7,7 @@ import {
   ColumnInj,
   IsFormInj,
   IsLockedInj,
+  IsUnderLookupInj,
   ReadonlyInj,
   ReloadRowDataHookInj,
   RowInj,
@@ -36,6 +37,8 @@ const isForm = inject(IsFormInj, ref(false))
 
 const isLocked = inject(IsLockedInj, ref(false))
 
+const isUnderLookup = inject(IsUnderLookupInj, ref(false))
+
 const { isUIAllowed } = useUIPermission()
 
 const listItemsDlg = ref(false)
@@ -89,7 +92,7 @@ useSelectedCellKeyupListener(active, (e: KeyboardEvent) => {
     </div>
 
     <div
-      v-if="!readOnly && !isLocked && (isUIAllowed('xcDatatableEditable') || isForm)"
+      v-if="!readOnly && !isLocked && (isUIAllowed('xcDatatableEditable') || isForm) && !isUnderLookup"
       class="flex justify-end gap-1 min-h-[30px] items-center"
     >
       <GeneralIcon

packages/nc-gui/components/virtual-cell/HasMany.vue

@@ -16,6 +16,7 @@ import {
   useSelectedCellKeyupListener,
   useSmartsheetRowStoreOrThrow,
   useUIPermission,
+  IsUnderLookupInj
 } from '#imports'
 
 const column = inject(ColumnInj)!
@@ -32,6 +33,8 @@ const readOnly = inject(ReadonlyInj, ref(false))
 
 const isLocked = inject(IsLockedInj)
 
+const isUnderLookup = inject(IsUnderLookupInj, ref(false))
+
 const listItemsDlg = ref(false)
 
 const childListDlg = ref(false)
@@ -112,7 +115,7 @@ useSelectedCellKeyupListener(inject(ActiveCellInj, ref(false)), (e: KeyboardEven
         </template>
       </div>
 
-      <div v-if="!isLocked" class="flex justify-end gap-1 min-h-[30px] items-center">
+      <div v-if="!isLocked && !isUnderLookup" class="flex justify-end gap-1 min-h-[30px] items-center">
         <GeneralIcon
           icon="expand"
           class="select-none transform text-sm nc-action-icon text-gray-500/50 hover:text-gray-500 nc-arrow-expand"

packages/nc-gui/components/virtual-cell/Lookup.vue

@@ -5,6 +5,7 @@ import {
   CellUrlDisableOverlayInj,
   CellValueInj,
   ColumnInj,
+  IsUnderLookupInj,
   MetaInj,
   computed,
   inject,
@@ -70,6 +71,8 @@ const arrValue = computed(() => {
 
 provide(MetaInj, lookupTableMeta)
 
+provide(IsUnderLookupInj, ref(true))
+
 provide(CellUrlDisableOverlayInj, ref(true))
 
 const { showEditNonEditableFieldWarning, showClearNonEditableFieldWarning, activateShowEditNonEditableFieldWarning } =

packages/nc-gui/components/virtual-cell/ManyToMany.vue

@@ -7,6 +7,7 @@ import {
   ColumnInj,
   IsFormInj,
   IsLockedInj,
+  IsUnderLookupInj,
   ReadonlyInj,
   ReloadRowDataHookInj,
   RowInj,
@@ -34,6 +35,8 @@ const readOnly = inject(ReadonlyInj, ref(false))
 
 const isLocked = inject(IsLockedInj)
 
+const isUnderLookup = inject(IsUnderLookupInj, ref(false))
+
 const listItemsDlg = ref(false)
 
 const childListDlg = ref(false)
@@ -114,7 +117,7 @@ useSelectedCellKeyupListener(inject(ActiveCellInj, ref(false)), (e: KeyboardEven
         </template>
       </div>
 
-      <div v-if="!isLocked" class="flex justify-end gap-1 min-h-[30px] items-center">
+      <div v-if="!isLocked && !isUnderLookup" class="flex justify-end gap-1 min-h-[30px] items-center">
         <GeneralIcon
           icon="expand"
           class="text-sm nc-action-icon text-gray-500/50 hover:text-gray-500 nc-arrow-expand"

packages/nc-gui/composables/useApi/interceptors.ts

@@ -67,9 +67,8 @@ export function addAxiosInterceptors(api: Api<any>) {
         })
         .catch(async (error) => {
           await state.signOut()
-          // todo: handle new user
 
-          navigateTo('/signIn')
+          if (!route.meta.public) navigateTo('/signIn')
 
           return Promise.reject(error)
         })

packages/nc-gui/context/index.ts

@@ -38,3 +38,4 @@ export const ToggleDialogInj: InjectionKey<Function> = Symbol('toggle-dialog-inj
 export const CellClickHookInj: InjectionKey<EventHook<MouseEvent> | undefined> = Symbol('cell-click-injection')
 export const SaveRowInj: InjectionKey<(() => void) | undefined> = Symbol('save-row-injection')
 export const CurrentCellInj: InjectionKey<Ref<Element | undefined>> = Symbol('current-cell-injection')
+export const IsUnderLookupInj: InjectionKey<Ref<boolean>> = Symbol('is-under-lookup-injection')

packages/nocodb/src/services/public-metas.service.ts

@@ -2,7 +2,7 @@ import { Injectable } from '@nestjs/common';
 import { ErrorMessages, RelationTypes, UITypes } from 'nocodb-sdk';
 import { NcError } from '../helpers/catchError';
 import { Base, Column, Model, Project, View } from '../models';
-import type { LinkToAnotherRecordColumn } from '../models';
+import type { LinkToAnotherRecordColumn, LookupColumn } from '../models';
 import type { LinkToAnotherRecordType } from 'nocodb-sdk';
 
 @Injectable()
@@ -63,23 +63,88 @@ export class PublicMetasService {
 
     // load related table metas
     for (const col of view.model.columns) {
-      if (UITypes.LinkToAnotherRecord === col.uidt) {
-        const colOpt = await col.getColOptions<LinkToAnotherRecordType>();
-        relatedMetas[colOpt.fk_related_model_id] = await Model.getWithInfo({
-          id: colOpt.fk_related_model_id,
-        });
-        if (colOpt.type === 'mm') {
-          relatedMetas[colOpt.fk_mm_model_id] = await Model.getWithInfo({
-            id: colOpt.fk_mm_model_id,
-          });
-        }
-      }
+      await this.extractRelatedMetas({ col, relatedMetas });
     }
 
     view.relatedMetas = relatedMetas;
 
     return view;
   }
+
+  private async extractRelatedMetas({
+    col,
+    relatedMetas = {},
+  }: {
+    col: Column<any>;
+    relatedMetas: Record<string, Model>;
+  }) {
+    if (UITypes.LinkToAnotherRecord === col.uidt) {
+      await this.extractLTARRelatedMetas({
+        ltarColOption: await col.getColOptions<LinkToAnotherRecordColumn>(),
+        relatedMetas,
+      });
+    } else if (UITypes.Lookup === col.uidt) {
+      await this.extractLookupRelatedMetas({
+        lookupColOption: await col.getColOptions<LookupColumn>(),
+        relatedMetas,
+      });
+    }
+  }
+
+  private async extractLTARRelatedMetas({
+    ltarColOption,
+    relatedMetas = {},
+  }: {
+    ltarColOption: LinkToAnotherRecordColumn;
+    relatedMetas: { [key: string]: Model };
+  }) {
+    relatedMetas[ltarColOption.fk_related_model_id] = await Model.getWithInfo({
+      id: ltarColOption.fk_related_model_id,
+    });
+    if (ltarColOption.type === 'mm') {
+      relatedMetas[ltarColOption.fk_mm_model_id] = await Model.getWithInfo({
+        id: ltarColOption.fk_mm_model_id,
+      });
+    }
+  }
+
+  private async extractLookupRelatedMetas({
+    lookupColOption,
+    relatedMetas = {},
+  }: {
+    lookupColOption: LookupColumn;
+    relatedMetas: { [key: string]: Model };
+  }) {
+    const relationCol = await Column.get({
+      colId: lookupColOption.fk_relation_column_id,
+    });
+    const lookedUpCol = await Column.get({
+      colId: lookupColOption.fk_lookup_column_id,
+    });
+
+    // extract meta for table which belongs the relation column
+    // if not already extracted
+    if (!relatedMetas[relationCol.fk_model_id]) {
+      relatedMetas[relationCol.fk_model_id] = await Model.getWithInfo({
+        id: relationCol.fk_model_id,
+      });
+    }
+
+    // extract meta for table in which looked up column belongs
+    // if not already extracted
+    if (!relatedMetas[lookedUpCol.fk_model_id]) {
+      relatedMetas[lookedUpCol.fk_model_id] = await Model.getWithInfo({
+        id: lookedUpCol.fk_model_id,
+      });
+    }
+
+    // extract metas related to the looked up column
+    await this.extractRelatedMetas({
+      col: lookedUpCol,
+      relatedMetas,
+    });
+  }
+
   async publicSharedBaseGet(param: { sharedBaseUuid: string }): Promise<any> {
     const project = await Project.getByUuid(param.sharedBaseUuid);