From 4df59e85336449b73f26013844b9c636792147db Mon Sep 17 00:00:00 2001
From: mertmit <mertmit99@gmail.com>
Date: Mon, 16 Sep 2024 15:35:15 +0000
Subject: [PATCH] fix: handle type diff while comparing pks

---
 packages/nocodb/src/db/BaseModelSqlv2.ts | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/packages/nocodb/src/db/BaseModelSqlv2.ts b/packages/nocodb/src/db/BaseModelSqlv2.ts
index 4030a15195..ae341dd118 100644
--- a/packages/nocodb/src/db/BaseModelSqlv2.ts
+++ b/packages/nocodb/src/db/BaseModelSqlv2.ts
@@ -88,6 +88,9 @@ const GROUP_COL = '__nc_group_id';
 
 const nanoidv2 = customAlphabet('1234567890abcdefghijklmnopqrstuvwxyz', 14);
 
+const isPrimitiveType = (val) =>
+  typeof val === 'string' || typeof val === 'number';
+
 export async function populatePk(
   context: NcContext,
   model: Model,
@@ -4830,6 +4833,12 @@ class BaseModelSqlv2 {
   }
 
   comparePks(pk1, pk2) {
+    // If either pk1 or pk2 is a string or number, convert both to strings and compare
+    if (isPrimitiveType(pk1) || isPrimitiveType(pk2)) {
+      return `${pk1}` === `${pk2}`;
+    }
+
+    // If both are objects (composite keys), compare them using deep equality check
     return equal(pk1, pk2);
   }