From a2cabc5b912d43a3a956fdb7ac3731dc0b82a9d3 Mon Sep 17 00:00:00 2001 From: Wing-Kam Wong Date: Wed, 11 Jan 2023 16:18:03 +0800 Subject: [PATCH] chore(nocodb-sdk): remove unnecessary replace in formula --- packages/nocodb-sdk/src/lib/formulaHelpers.ts | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/packages/nocodb-sdk/src/lib/formulaHelpers.ts b/packages/nocodb-sdk/src/lib/formulaHelpers.ts index 14d50009d5..e10e491dea 100644 --- a/packages/nocodb-sdk/src/lib/formulaHelpers.ts +++ b/packages/nocodb-sdk/src/lib/formulaHelpers.ts @@ -67,11 +67,7 @@ export async function substituteColumnAliasWithIdInFormula( }; // register jsep curly hook jsep.plugins.register(jsepCurlyHook); - const parsedFormula = jsep( - // formula may include double curly brackets in previous version - // convert to single curly bracket here for compatibility - formula.replaceAll('{{', '{').replaceAll('}}', '}') - ); + const parsedFormula = jsep(formula); await substituteId(parsedFormula); return jsepTreeToFormula(parsedFormula); } @@ -106,11 +102,7 @@ export function substituteColumnIdWithAliasInFormula( // register jsep curly hook jsep.plugins.register(jsepCurlyHook); - const parsedFormula = jsep( - // formula may include double curly brackets in previous version - // convert to single curly bracket here for compatibility - formula.replaceAll('{{', '{').replaceAll('}}', '}') - ); + const parsedFormula = jsep(formula); const parsedRawFormula = rawFormula && jsep(rawFormula); substituteId(parsedFormula, parsedRawFormula); return jsepTreeToFormula(parsedFormula);