From a1969be7d04a44178bc63ae734cf2ac9cbd6d8db Mon Sep 17 00:00:00 2001
From: Ramesh Mane <101566080+rameshmane7218@users.noreply.github.com>
Date: Sat, 27 Jan 2024 10:42:32 +0000
Subject: [PATCH] fix: allow renaming of belongs to column nocodb/nocodb#7441

---
 .../components/smartsheet/column/EditOrAdd.vue       |  4 ++--
 packages/nocodb-sdk/src/lib/helperFunctions.ts       | 12 ++++++++++++
 2 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/packages/nc-gui/components/smartsheet/column/EditOrAdd.vue b/packages/nc-gui/components/smartsheet/column/EditOrAdd.vue
index 213205ed9c..f3f80bfc79 100644
--- a/packages/nc-gui/components/smartsheet/column/EditOrAdd.vue
+++ b/packages/nc-gui/components/smartsheet/column/EditOrAdd.vue
@@ -1,6 +1,6 @@
 <script lang="ts" setup>
 import type { ColumnReqType, ColumnType } from 'nocodb-sdk'
-import { UITypes, isLinksOrLTAR, isSystemColumn, isVirtualCol } from 'nocodb-sdk'
+import { UITypes, isLinksOrLTAR, isSystemColumn, isVirtualCol, isSelfReferencingTableColumn } from 'nocodb-sdk'
 import {
   IsFormInj,
   IsKanbanInj,
@@ -172,7 +172,7 @@ onMounted(() => {
     if (formState.value.pk) {
       message.info(t('msg.info.editingPKnotSupported'))
       emit('cancel')
-    } else if (isSystemColumn(formState.value)) {
+    } else if (isSystemColumn(formState.value) && !isSelfReferencingTableColumn(formState.value)) {
       message.info(t('msg.info.editingSystemKeyNotSupported'))
       emit('cancel')
     }
diff --git a/packages/nocodb-sdk/src/lib/helperFunctions.ts b/packages/nocodb-sdk/src/lib/helperFunctions.ts
index 0de069461d..decd5bc7f7 100644
--- a/packages/nocodb-sdk/src/lib/helperFunctions.ts
+++ b/packages/nocodb-sdk/src/lib/helperFunctions.ts
@@ -22,6 +22,17 @@ const isSystemColumn = (col): boolean =>
     (col.pk && col.meta && col.meta.ag) ||
     col.system);
 
+const isSelfReferencingTableColumn = (col): boolean => {
+  return (
+    col &&
+    (col.uidt === UITypes.Links || col.uidt === UITypes.LinkToAnotherRecord) &&
+    (col?.fk_model_id || col?.colOptions?.fk_model_id) &&
+    col?.colOptions?.fk_related_model_id &&
+    (col?.fk_model_id || col?.colOptions?.fk_model_id) ===
+      col.colOptions.fk_related_model_id
+  );
+};
+
 const extractRolesObj = (roles: RolesType): RolesObj => {
   if (!roles) return null;
 
@@ -89,6 +100,7 @@ export {
   getSystemColumnsIds,
   getSystemColumns,
   isSystemColumn,
+  isSelfReferencingTableColumn,
   extractRolesObj,
   stringifyRolesObj,
   getAvailableRollupForUiType,